From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) by dpdk.org (Postfix) with ESMTP id 0D8345F1A for ; Tue, 9 Apr 2019 11:55:29 +0200 (CEST) Received: by mail-vs1-f53.google.com with SMTP id w13so9428803vsc.4 for ; Tue, 09 Apr 2019 02:55:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bn9+MZfIsFwowDqo7kndrGZaLW5tuqMB7zt4QARVtec=; b=Xl6Xl1KItZAj6hVZoErmAIRrA8l683DR5KHRqmy5sOgkEyacUKyTp4LtI/Cka23HyL d8sILGWsufox7n+uqGXVtMBGc+8pmfupotTSidVM4ZOIh3hCgQYD0K13QUSbdQJOpXMe xdsNZ4Sh4tSSxdGH8MtPx3InrHHVpx61JYUJxCbGDimAhjjLKMg5IYD/uWP0RbSczWc+ 2Dr33gXWCNI3qhrUl/JFmgZMhuBZqOFIe3fVrr/I8lrTUDLWC6+Yvkp4cl8H7/bWa1qE DTTjYf5xcpVAFSQzmoN7lWo9kcekgnwHgP0qOp41TeI0idVhBVvwbQcL28+YQiNMs10g FwoA== X-Gm-Message-State: APjAAAWBR6tg1FFGuO0ZISxEQ6h6qW5BGtxoq5oRFXphhL1AMFKcgS5V FUCLZoGsxR5cq24vPiyOtUAJ7lfYJS5p6QS4NJ0Img== X-Google-Smtp-Source: APXvYqwEplPlh+KtRkU+dze3m/rbtW8hA5poW7HJLbdRpR0IlwMwP7DRmmMTj6hWjQoRKgVZQOkzsy3aL082yofBnKo= X-Received: by 2002:a67:f588:: with SMTP id i8mr16079387vso.91.1554803728340; Tue, 09 Apr 2019 02:55:28 -0700 (PDT) MIME-Version: 1.0 References: <20190409092933.55356-1-bruce.richardson@intel.com> In-Reply-To: <20190409092933.55356-1-bruce.richardson@intel.com> From: David Marchand Date: Tue, 9 Apr 2019 11:55:17 +0200 Message-ID: To: Bruce Richardson Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 0/5] small cleanup and fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 09:55:29 -0000 On Tue, Apr 9, 2019 at 11:29 AM Bruce Richardson wrote: > Made some small changes to meson to shorten the code and increase > readability. While testing, found a number of issues on FreeBSD builds, > which are fixed in this set too. > > Bruce Richardson (5): > build: simplify subdirectory detection for EAL > build: increase readability via shortcut variables > distributor: skip building if power library not found > examples/l2fwd-cat: fix build on FreeBSD > devtools/test-meson-builds: fix support for FreeBSD > I have some small comments in patch 4 and patch 5 (sent separately), but the rest looks good to me. Reviewed-by: David Marchand -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 5EA36A0096 for ; Tue, 9 Apr 2019 11:55:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A7FB25F20; Tue, 9 Apr 2019 11:55:30 +0200 (CEST) Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) by dpdk.org (Postfix) with ESMTP id 0D8345F1A for ; Tue, 9 Apr 2019 11:55:29 +0200 (CEST) Received: by mail-vs1-f53.google.com with SMTP id w13so9428803vsc.4 for ; Tue, 09 Apr 2019 02:55:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bn9+MZfIsFwowDqo7kndrGZaLW5tuqMB7zt4QARVtec=; b=Xl6Xl1KItZAj6hVZoErmAIRrA8l683DR5KHRqmy5sOgkEyacUKyTp4LtI/Cka23HyL d8sILGWsufox7n+uqGXVtMBGc+8pmfupotTSidVM4ZOIh3hCgQYD0K13QUSbdQJOpXMe xdsNZ4Sh4tSSxdGH8MtPx3InrHHVpx61JYUJxCbGDimAhjjLKMg5IYD/uWP0RbSczWc+ 2Dr33gXWCNI3qhrUl/JFmgZMhuBZqOFIe3fVrr/I8lrTUDLWC6+Yvkp4cl8H7/bWa1qE DTTjYf5xcpVAFSQzmoN7lWo9kcekgnwHgP0qOp41TeI0idVhBVvwbQcL28+YQiNMs10g FwoA== X-Gm-Message-State: APjAAAWBR6tg1FFGuO0ZISxEQ6h6qW5BGtxoq5oRFXphhL1AMFKcgS5V FUCLZoGsxR5cq24vPiyOtUAJ7lfYJS5p6QS4NJ0Img== X-Google-Smtp-Source: APXvYqwEplPlh+KtRkU+dze3m/rbtW8hA5poW7HJLbdRpR0IlwMwP7DRmmMTj6hWjQoRKgVZQOkzsy3aL082yofBnKo= X-Received: by 2002:a67:f588:: with SMTP id i8mr16079387vso.91.1554803728340; Tue, 09 Apr 2019 02:55:28 -0700 (PDT) MIME-Version: 1.0 References: <20190409092933.55356-1-bruce.richardson@intel.com> In-Reply-To: <20190409092933.55356-1-bruce.richardson@intel.com> From: David Marchand Date: Tue, 9 Apr 2019 11:55:17 +0200 Message-ID: To: Bruce Richardson Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 0/5] small cleanup and fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190409095517.UfRHRm19d9lNPz4IDpSkS9GrhNUx4PBn_mOcDHsDrBg@z> On Tue, Apr 9, 2019 at 11:29 AM Bruce Richardson wrote: > Made some small changes to meson to shorten the code and increase > readability. While testing, found a number of issues on FreeBSD builds, > which are fixed in this set too. > > Bruce Richardson (5): > build: simplify subdirectory detection for EAL > build: increase readability via shortcut variables > distributor: skip building if power library not found > examples/l2fwd-cat: fix build on FreeBSD > devtools/test-meson-builds: fix support for FreeBSD > I have some small comments in patch 4 and patch 5 (sent separately), but the rest looks good to me. Reviewed-by: David Marchand -- David Marchand