From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 735F8A0543; Mon, 13 Jun 2022 16:15:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1057440222; Mon, 13 Jun 2022 16:15:33 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C476E40150 for ; Mon, 13 Jun 2022 16:15:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655129731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vx8y7OIsQgKaeB9QvAW3z3+bzrP3uQ/jG72eZgPV2T4=; b=FPF1UIPxsZ3aEUk6UYBU8p38trZDndigzayFW79JE40PwznzRFzmmGoxrnBnYWsB8nx3l7 npGhfcuZUn7+9+vo/A3xtn4eL1Fntv8lNqMtqWJrudcH++88z90Oim+t1YArvHPGaQEikn 6KXJ07ZHBsnnU4jAbQwU/siu2w6ua3w= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-497-XYCNfYXNOr-MF4zitfOC4g-1; Mon, 13 Jun 2022 10:15:29 -0400 X-MC-Unique: XYCNfYXNOr-MF4zitfOC4g-1 Received: by mail-lj1-f198.google.com with SMTP id t23-20020a2e7817000000b002555d1188bdso706875ljc.4 for ; Mon, 13 Jun 2022 07:15:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vx8y7OIsQgKaeB9QvAW3z3+bzrP3uQ/jG72eZgPV2T4=; b=VVm01U8xrIDoxPdk723eQD+xu6C6PxP8L1XYLom13Wo7GG4jF0v3hMVdD8RocYfknW 6MqPslDFNtY0yWuLQVX4t2bLXy/wWddq69/5SoBGHd+0olBQblUFqKJJ98sgV+m1ohuJ zsuCBstkpHsr9dhgBHmmOPHe+V0OC6ypVgRio21hA6+DM0/CpQBBCxUBW0uSF8p/IwNe rxYKfDCfze+C+KqRzk8v5FHOcYJe5d3IEHw2Rah4CYtx4xuiRn5o6xJabLyQcEHpfp78 eORfeynQ6+v+HWaDFZwNxGh9jwBWCt102G5oA8Zaz8fSzrPfydEMvm7RMWKrNOakLaUK Z4hw== X-Gm-Message-State: AOAM5302mvPdSwhAeCjYgk1FEJwq3CUB5gqloKrAxDwAUUd3008Ffovg CzD7U8pvSui63g8pXkzNuJp4X9xJ9EtMzLMPJ35Ltq3BHY2pLivyDR89cXuR1pkleLNhgIB0wSd yA1t3xCwgr5Zjc/8tJ+U= X-Received: by 2002:a2e:ba06:0:b0:255:b837:a36c with SMTP id p6-20020a2eba06000000b00255b837a36cmr15769327lja.81.1655129728434; Mon, 13 Jun 2022 07:15:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySndYSj8wyeQm+cvvmKuQXnTs7MeaGToI4cuhzTZhE549NPoi3+DEG/TH4fTG1FZBLx+csZb984mHeLgq4VVk= X-Received: by 2002:a2e:ba06:0:b0:255:b837:a36c with SMTP id p6-20020a2eba06000000b00255b837a36cmr15769317lja.81.1655129728217; Mon, 13 Jun 2022 07:15:28 -0700 (PDT) MIME-Version: 1.0 References: <20220607120014.49823-1-fengchengwen@huawei.com> <0b9f04f5-6944-85e6-4c91-566476601368@huawei.com> In-Reply-To: <0b9f04f5-6944-85e6-4c91-566476601368@huawei.com> From: David Marchand Date: Mon, 13 Jun 2022 16:15:17 +0200 Message-ID: Subject: Re: [PATCH] eal: fix segment fault when exit trace To: fengchengwen , "Richardson, Bruce" Cc: Thomas Monjalon , dev , "Burakov, Anatoly" , Jerin Jacob Kollanukkaran Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jun 7, 2022 at 2:26 PM fengchengwen wrote: > Hi Bruce, > > Could you please test freebsd platform? I think it also have > the same problem, but I hasn't freebsd enviorment. I can reproduce a crash with FreeBSD 13. Moving rte_trace_save() and co earlier (as is done for Linux in this proposed patch) avoids the crash, so I can't tell the traces file is valid. dpdk@freebsd:~/dpdk $ git diff diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index a6b20960f2..26fbc91b26 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -893,11 +893,11 @@ rte_eal_cleanup(void) eal_get_internal_configuration(); rte_service_finalize(); rte_mp_channel_cleanup(); + rte_trace_save(); + eal_trace_fini(); /* after this point, any DPDK pointers will become dangling */ rte_eal_memory_detach(); rte_eal_alarm_cleanup(); - rte_trace_save(); - eal_trace_fini(); eal_cleanup_config(internal_conf); return 0; } -- David Marchand