From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 538C8A04DB; Thu, 15 Oct 2020 13:59:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 32C211DE80; Thu, 15 Oct 2020 13:59:12 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 5E1BC1DDE5 for ; Thu, 15 Oct 2020 13:59:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602763147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g4FjTu3vxDV0XuGWy6GGYAWikwdPB8B2oFwociSIF2w=; b=FiELwhsdQmoe9yzfXpfe9tc0IgS9DqRSAxCpjUV1ixGzJyGLe6chcaZOWZRgoVXg5v9k+q SjXNTz4ezbx0CO608WuJpRx7/iHDJGU4kRcxevHlXOLbt1/us5zZqubEcHnBS1/rdGLMrB d8VGlRqezpR/WNzU8Dm9AkCIBv+k8kU= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-5-mIxJWTRdO5-DQG3DzQEv2g-1; Thu, 15 Oct 2020 07:59:06 -0400 X-MC-Unique: mIxJWTRdO5-DQG3DzQEv2g-1 Received: by mail-vs1-f71.google.com with SMTP id k18so860742vsm.4 for ; Thu, 15 Oct 2020 04:59:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g4FjTu3vxDV0XuGWy6GGYAWikwdPB8B2oFwociSIF2w=; b=DawbTqT/Xl56Esq6cVWnC7/F58vW17z/CYqDLq4cZ4Pz0b1E/as2vZCaegwhDii5TV XTrkgg9Ud4zMsdQVomKtszf/PqO9wiKVwazafHI3ny8AGxeRY8R1pTPYYh44axlXAYkE K/3TYF6doNm5g6ZLldQ6ssEHkfHMnmXEJxZGN+NfpNNE8ZMGsN+x8dIsb69pdHbqcvzU HtfQS/PknZI7tiv0i/2HwYMkI3m3RUvfhKKW9KaSRSxv8RJ8BuBU0JlPFm7MPEfNA4v/ 2/0ATPdjLnm+ymlcSiriOI3u1AaOn2PvPDoZSzIo/dCEvA9U6Q+QOpgM4dmYg5Izp2NT 4Qvg== X-Gm-Message-State: AOAM53062Ar8ArmmuuP3bC9AV7lUYmRuIRp6uLAXXzLqwfEU9eLx0QY4 SzL6aCfvXRXGeaqyBtVQNrIhydIIL0nqZJNWqzsjJk9WNYY4Lx45IGbICRGquOvB5/5aqSjfCAv jTLtHRTDRT2/bBT1H1AA= X-Received: by 2002:a1f:6014:: with SMTP id u20mr2268618vkb.9.1602763145816; Thu, 15 Oct 2020 04:59:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwKFl37Z2jN/iSbmRTepVzG5Rn2sTdSsFrw0IDFyNaevZYkrlTQfkERCa6IkxiOsZMIhxEkLgch1zdBiRb9ASk= X-Received: by 2002:a1f:6014:: with SMTP id u20mr2268606vkb.9.1602763145540; Thu, 15 Oct 2020 04:59:05 -0700 (PDT) MIME-Version: 1.0 References: <20200915170456.7204-1-konstantin.ananyev@intel.com> <20201006171618.19374-1-konstantin.ananyev@intel.com> <20201006171618.19374-2-konstantin.ananyev@intel.com> In-Reply-To: <20201006171618.19374-2-konstantin.ananyev@intel.com> From: David Marchand Date: Thu, 15 Oct 2020 13:58:53 +0200 Message-ID: To: Konstantin Ananyev Cc: dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 1/3] examples/l3fwd-acl: add source and destination MAC update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 6, 2020 at 7:17 PM Konstantin Ananyev wrote: > > Introduces two changes into l3fwd-acl behaviour to make > it behave in the same way as l3fwd: > - Add a command-line parameter to allow the user to specify the > destination mac address for each ethernet port used. > - While forwarding the packet update source and destination mac > addresses. This new parameter is optional, but I see no default for l2 destination in the patch. How does it work when you won't set this option? Bonus question, what keeps us from merging this example with l3fwd? -- David Marchand