Re: [PATCH v2] net/iavf: preserve MAC address with i40e PF Linux driver

[David Marchand <david.marchand@redhat.com>]

On Tue, Oct 1, 2024 at 12:09 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> > @@ -1113,16 +1111,6 @@ iavf_dev_stop(struct rte_eth_dev *dev)
> >       /* Rx interrupt vector mapping free */
> >       rte_intr_vec_list_free(intr_handle);
> >
> > -     /* adminq will be disabled when vf is resetting. */
> > -     if (!vf->in_reset_recovery) {
> > -             /* remove all mac addrs */
> > -             iavf_add_del_all_mac_addr(adapter, false);
> > -
> > -             /* remove all multicast addresses */
> > -             iavf_add_del_mc_addr_list(adapter, vf->mc_addrs, vf->mc_addrs_num,
> > -                               false);
> > -     }
> > -
>
> Question on this: while I understand we don't want to remove the default
> mac address, should all other non-default macs not still be removed?

I would say that we don't care.
Right after this, the VF driver sends a VF reset (following your
recent change), and the PF flushes any mac associated to the VF from
hw filters.

The kernel VF driver does nothing about mac addresses when uninitialising.


-- 
David Marchand