From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C55DC45A7A; Tue, 1 Oct 2024 15:08:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83BB640611; Tue, 1 Oct 2024 15:08:01 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 46DF74027C for ; Tue, 1 Oct 2024 15:08:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727788079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f8tqEI0fWFLOz6n+XA5IrKkOm1zTzfII/zbiF9LpVl4=; b=clP78PcIn/JXQ3bCU4mXka1vGSCHf+u7IaisY5oq1jKDkBbtt6DMk735oyfQjL7zlYOu6a 5XZ72iQTt+kGLFrwQoTaojVwSRdc5sdgLjr4eDdJimBWt+Y+GMB6gvDJa4N1q0KATonWgb LH2QMGtID6RM3E8ZX8a31+b5pXX0gIA= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-508-jTlucHJ1OmS_t9zQ5WSbjQ-1; Tue, 01 Oct 2024 09:07:56 -0400 X-MC-Unique: jTlucHJ1OmS_t9zQ5WSbjQ-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2fad2ac8dfcso15704511fa.1 for ; Tue, 01 Oct 2024 06:07:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727788075; x=1728392875; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f8tqEI0fWFLOz6n+XA5IrKkOm1zTzfII/zbiF9LpVl4=; b=lc8K5Ei5xZGcHDWrsNouEYBOeIn6vTq1vMtFW5qSdNUSKnarxn6/OcE8cHavRkGj2u 0mreP0FOoPGiQsY4JWLgC2eGzMg7uNN7HLAiQLyZkBAlOGsPN8w46jNwc1LaR87IOjXF pwNCbqFsbCxM1PH722x9Ldh0OCp0Csi4wDGzMk1T/TOqtdkgn9I/nzXlsl6QBEA1eQUC ht4KT4biWTS69kMs8FRzz/ZMpaQmB+/E2W+/5BVJkUr/o/n7ZP73lvr1+gPSwCztc27d WEMGKw24Ab4Y87XJhBy/U8y1lStdy6c7innCRtnYJsTzK7j8vtcvkKo5OXR/hdGvRSOK BdzA== X-Gm-Message-State: AOJu0YyMQfo6imZENXrCUUSqjuSo5P8QIY1OkCslbwuk7xuemQNfsKUU S9phtdteZjzPBAkZxHG52wkFP1bWOr82G/erIr7vT2hD6f79eY6F4GUjoixcMGfQ3jjJGFl4/Ob 580uBkT9oLIsdJo1Y9m71dCLmlScZwbyh+EuOvvwuWs7kgOAmlKua/L6VuJWabKQ3nVg8Ddmz48 2VDsqIc4u0/JJY8EY= X-Received: by 2002:a05:651c:198b:b0:2fa:cc63:d9dd with SMTP id 38308e7fff4ca-2facc63dda4mr39117121fa.5.1727788075044; Tue, 01 Oct 2024 06:07:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4rEuNAwbO/hHu6fK3N/kzF5trn0pGWMd8lJF3dsukzpjstvwcHOWyeTdM+BXc2q8UoTvJzccvk52FgcQUrDo= X-Received: by 2002:a05:651c:198b:b0:2fa:cc63:d9dd with SMTP id 38308e7fff4ca-2facc63dda4mr39116981fa.5.1727788074554; Tue, 01 Oct 2024 06:07:54 -0700 (PDT) MIME-Version: 1.0 References: <20240919120039.4097053-1-david.marchand@redhat.com> <20241001091254.98540-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Tue, 1 Oct 2024 15:07:41 +0200 Message-ID: Subject: Re: [PATCH v2] net/iavf: preserve MAC address with i40e PF Linux driver To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org, Jingjing Wu X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 1, 2024 at 12:09=E2=80=AFPM Bruce Richardson wrote: > > @@ -1113,16 +1111,6 @@ iavf_dev_stop(struct rte_eth_dev *dev) > > /* Rx interrupt vector mapping free */ > > rte_intr_vec_list_free(intr_handle); > > > > - /* adminq will be disabled when vf is resetting. */ > > - if (!vf->in_reset_recovery) { > > - /* remove all mac addrs */ > > - iavf_add_del_all_mac_addr(adapter, false); > > - > > - /* remove all multicast addresses */ > > - iavf_add_del_mc_addr_list(adapter, vf->mc_addrs, vf->mc_a= ddrs_num, > > - false); > > - } > > - > > Question on this: while I understand we don't want to remove the default > mac address, should all other non-default macs not still be removed? I would say that we don't care. Right after this, the VF driver sends a VF reset (following your recent change), and the PF flushes any mac associated to the VF from hw filters. The kernel VF driver does nothing about mac addresses when uninitialising. --=20 David Marchand