From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2096A04B5; Wed, 30 Sep 2020 21:13:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9205C1D57D; Wed, 30 Sep 2020 21:13:04 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 440701D57C for ; Wed, 30 Sep 2020 21:13:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601493180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ld/kyOeZ8GoD2HG5moyJE/yd5Z0P9Zc48zaqW8ILboo=; b=cRxG18RgTriEHpd64i6uk7eT35Rn0ZLlLMYa6EwaOXPiDKPPi+J+IV/JcP+Asc5PuLAhN7 9vCIM9UkJhYtyUArg+KXv5IaJZKT6ffu+p5HCY1WeTtitg3PaFq3ztnJf+Cl5pbnHoCyT5 TrBBjwkWSSFmnnLwB3tNKOa8nL1zo6Y= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-116-TQ-V9N4LP9imErl-iNfpMA-1; Wed, 30 Sep 2020 15:12:59 -0400 X-MC-Unique: TQ-V9N4LP9imErl-iNfpMA-1 Received: by mail-ua1-f69.google.com with SMTP id w17so1046699uaj.0 for ; Wed, 30 Sep 2020 12:12:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ld/kyOeZ8GoD2HG5moyJE/yd5Z0P9Zc48zaqW8ILboo=; b=THNEeT6cpRWv3P6fla4tLT+UZn7yTe45Bdqup/m+iViCq/itKX2pKDiecq8q3X146r 5H1VKeD9B1VadKiaFsxqnEUy4kwIZWrVkCtoCdoy0QRea8/tEE2go6QIa+FEE5EaslHK gZCcgK4fwoB9nBWKH2Dksd3T0tIXPwa7i/uoffiHhjfm0JWACWCDhcdTA0nqP7dHLmz3 hs/jf9mOPZ4JeviSk35CGeahjwai2m6fUXeLEUu6F+IAy59soe5OH0oXtEY9JdZ4DFoZ fwItbC66107Bgsz7lsRzck1rL/QFwpyg0dNaaBypKheT0R/VDSXg2e11Rvq6FleVp4re UoUg== X-Gm-Message-State: AOAM533Fd4fz5fGYRZHpurKGyGXk1PWV7gvJ5URlk1bpCH6v4sWZjQ/p 2MFENx/XiI1WGZgIbgTT6ackCNUfCSlLTTFguLX1D4lw4IDg6N+u6eqUElLyCmTqiMvB7qSIzut ZMVOQsWGEcHa1L44px3k= X-Received: by 2002:a67:fd7a:: with SMTP id h26mr104097vsa.27.1601493178544; Wed, 30 Sep 2020 12:12:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzE8qzpDP9VhzZK4ykKwfxQbSS2jKoG7LcaPyer0w9gTIWaw5tVPmqdg6IjTtksy5cxlr8ONXqFj0DZ9mGTvRw= X-Received: by 2002:a67:fd7a:: with SMTP id h26mr104080vsa.27.1601493178295; Wed, 30 Sep 2020 12:12:58 -0700 (PDT) MIME-Version: 1.0 References: <20200805155721.19808-1-steven.lariau@arm.com> <20200812191847.16529-1-steven.lariau@arm.com> In-Reply-To: <20200812191847.16529-1-steven.lariau@arm.com> From: David Marchand Date: Wed, 30 Sep 2020 21:12:47 +0200 Message-ID: To: Steven Lariau Cc: dev , nd , Gage Eads , Dharmik Thakkar , "Ruifeng Wang (Arm Technology China)" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 0/4] test/stack: improve multithreaded test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Aug 12, 2020 at 9:20 PM Steven Lariau wrote: > > The current multithread DPDK stack test is using atomics operations to > share information between threads. > The lockfree stack implementation also uses atomic operations. > This is an issue for testing. The atomics operations for the test may > add some extra synchronization to the stack implementation, > that doesn't exist. > It makes it harder to find bugs related to memory orderings and data > races. The main goal of the patch is to remove all atomics operations > and any other form of data sharing in this test, to make sure that > most of the execution time is spent on the stack library. > > Furthermore, this patch uses more appropriate functions to start / > wait cores in order to simplify the code. > The patch also adds code to propagate errors on any slave core to the > master. > > v2: replace stack variable for arguments with a global variable. > > Steven Lariau (4): > test/stack: avoid trivial memory allocations > test/stack: launch tests with mp remote launch API > test/stack: propagate errors to main core > test/stack: remove atomics operations > > app/test/test_stack.c | 80 +++++++++---------------------------------- > 1 file changed, 17 insertions(+), 63 deletions(-) > Series applied, thanks Steven. -- David Marchand