From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7408A0524; Mon, 24 Feb 2020 11:32:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F9AF1BFA8; Mon, 24 Feb 2020 11:32:30 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 5BB3F1BE85 for ; Mon, 24 Feb 2020 11:32:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582540348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A5tQbwJq0Pikl15hfR5+ShZYlldAEUbqTl1yAeU0kAE=; b=aycsF9cN+MvGk9EvM/qwOAqADp0xAFnTsLYMxaFfI9AXct/8RDKW8fIg1JyO28e+siiCvH TWNhwXW623EVyOb1D4uxB8ecB0lU81ly254J/L4tj6zVy9vLM5V9cGaXIjOi6N39rccn5o lnINVSv8jlEsHZLnyC9EqDqthf65MZE= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-126-va22W9LuMy2fzu58iWTLfA-1; Mon, 24 Feb 2020 05:32:24 -0500 X-MC-Unique: va22W9LuMy2fzu58iWTLfA-1 Received: by mail-vk1-f200.google.com with SMTP id c127so4225062vkh.18 for ; Mon, 24 Feb 2020 02:32:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dnxkoUKfpEepUIUnCnBLETxMnO7cgGW8XKFYTGQGXao=; b=IYeO63WeW2MHkkNOnp0LvOJXSnOxWosiUHzMhV1FSG5B2d67UwkJa6tSH8x7866wCm Eir2i4mfOiu2zh5qYpOtr6+3Ci4jyQ4rqGb9Nqgtja5MG8+LnRB0Is4S37qxw+O8rYf0 p5TIfyxrL+wY60MIEA+h6WiyRd3mgN3oZvg0FYGxJxm+8ECEPI5TysCY3gezgsCjmlTf V84WhZMAXCK5UMjyhSJFce9ojAF3ZFnZIdMqm2H6vBf2qqbrhgVA/OndWzt8zeH1nSfW zKhi/X61QXiw/0EoZPLjQvce4oGbBiaE16mYTBiOSg4F36g8XaydGlIGiN4rgig4drSg HRbQ== X-Gm-Message-State: APjAAAVi37S/TWSuItXdftaPljnZILFs7JpdtjZHK6vVMMFiljFNqL0Z XnBd6T4dHr6AgnpOLi6oWoiYijKMpCJ2cShRcGF4MZFuyhABb0kQmZd+HeKQQuSQhLQCQyvBu98 VFOZGx5mL105K0AOC2Nc= X-Received: by 2002:a1f:4104:: with SMTP id o4mr23073942vka.80.1582540344234; Mon, 24 Feb 2020 02:32:24 -0800 (PST) X-Google-Smtp-Source: APXvYqzuslmm/Kfcj/RfNrwP/9H+qDXq7SSvyBtQILSRZqrFc0nxoKwblOMAuFva6wAW9UZw26uOzyQhEfmCwF73Xyc= X-Received: by 2002:a1f:4104:: with SMTP id o4mr23073924vka.80.1582540343924; Mon, 24 Feb 2020 02:32:23 -0800 (PST) MIME-Version: 1.0 References: <20200224145025.84899-1-yong.liu@intel.com> <20200224151419.85565-1-yong.liu@intel.com> In-Reply-To: From: David Marchand Date: Mon, 24 Feb 2020 11:32:12 +0100 Message-ID: To: Maxime Coquelin Cc: Marvin Liu , Tiwei Bie , Zhihong Wang , Thomas Monjalon , dev , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] vhost: fix packed ring zero-copy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Feb 24, 2020 at 9:28 AM Maxime Coquelin wrote: > > Hi David & Thomas, > > On 2/24/20 4:14 PM, Marvin Liu wrote: > > Available buffer ID should be stored in the zmbuf in the packed-ring > > dequeue path. There's no guarantee that local queue avail index is > > equal to buffer ID. > > > > Fixes: d1eafb532268 ("vhost: add packed ring zcopy batch and single deq= ueue") > > Cc: stable@dpdk.org > > > > Signed-off-by: Marvin Liu > > Reported-by: Yinan Wang > > Reviewed-by: Maxime Coquelin > > > > If it is not too late, I think we should pick this patch for > v20.02. It is fixing a regression introduced in DPDK v19.11. I might have cold feet, but taking this fix right now feels risky. If the problem has been there since 19.11, it can wait 20.05 and it will go to 19.11 after proper validation. --=20 David Marchand