From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36206A09E0; Fri, 13 Nov 2020 15:14:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 856ABC872; Fri, 13 Nov 2020 15:14:30 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 76320C868 for ; Fri, 13 Nov 2020 15:14:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605276868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FVhSahA4wXai39q2wad+x7/HQbSkJlX6I751N7FBt4s=; b=ZjNE7v445ezTQ/tQp0Tt8CM6KguChKQL6hvJNRVeghzcoaV1skYcp5PxsFAwCwCjwm+L8g IohvJb3s6t8aqVg7yyIZ/Y4qO6A6Oq+n6Nu4TZeFSfaeekHRX0RTCoe84xXpDzId2+8KUl 1RL3u4JmQbbRoI5AyiZT0NKvM/+gGwM= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-16-895ryfc8NAS-19ZckSe8jQ-1; Fri, 13 Nov 2020 09:14:26 -0500 X-MC-Unique: 895ryfc8NAS-19ZckSe8jQ-1 Received: by mail-vs1-f70.google.com with SMTP id e7so2804581vsc.15 for ; Fri, 13 Nov 2020 06:14:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FVhSahA4wXai39q2wad+x7/HQbSkJlX6I751N7FBt4s=; b=kqwpil/p0qWtvU6U8+oIk7vITcSG08V1gJBHJlVLYwhDXQ3P3fkvwmSqcSV9p5GDMV c+K8A4D3V2h76Ps51DC/fQ/HSZGVY98fLMGP22/5EGbWxjpPAw/v7t43wLxIIIk4JM7m 3Fh0UnO7idNSPy/4E9lnNKrV6P5ccJNoaFa36Rrmvbb0pdqK81lSnN//FsUG4fAS9J0A b9gvP72JSGtJeBIeCDH/UF3UGMaVDB3qxSAfzpBOLHcRBKf3ojLFFiaIUcgxuUoNG3Fb JwwZlXymuebGLJUbq7fhScR3yz/Akumf9JJJjMFznXQfRADrYxo0KWNEXw5hzCtZbU6o p6qg== X-Gm-Message-State: AOAM531n+CaiUJ9+Ya6yPDUHhnjV6UdkkoFwKp+8eLM723TDQuFrVigK VPyhhVW6R5w+S0yJ+pqKpGLVsPlk5zr1BptrA+j2CBIYNq5GPzyo0pnfgiZ6AXyAy/Xt9MsZ5Tm nFMXVrNybitneV3d5OtM= X-Received: by 2002:a67:f8c5:: with SMTP id c5mr1258833vsp.18.1605276865548; Fri, 13 Nov 2020 06:14:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJzdfjx8ibGkgPa5RcPNN3bd9UErAHqvtCVtckAhdFnjJwClBw49PSTKwbl0Siv2A2ncr+LGZYrcV2/lSR+jqso= X-Received: by 2002:a67:f8c5:: with SMTP id c5mr1258805vsp.18.1605276865345; Fri, 13 Nov 2020 06:14:25 -0800 (PST) MIME-Version: 1.0 References: <20201110151219.4893-1-david.marchand@redhat.com> <20201113122430.25354-1-david.marchand@redhat.com> <20201113122430.25354-12-david.marchand@redhat.com> <20201113140620.GC53@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201113140620.GC53@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Fri, 13 Nov 2020 15:14:14 +0100 Message-ID: To: Bruce Richardson Cc: dev , Thomas Monjalon , Luca Boccassi Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 11/11] devtools: compile all buildable examples with pkg-config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Nov 13, 2020 at 3:06 PM Bruce Richardson wrote: > > On Fri, Nov 13, 2020 at 01:24:30PM +0100, David Marchand wrote: > > Rather than just installing all examples, we can use the build checks to > > filter out any examples that are missing dependencies or are otherwise > > unbuildable on the current system. > > Introduce a new "buildable" special value for the -Dexamples= meson > > option, this way existing behavior on installing all examples is > > preserved. > > > > Select only buildable examples and test their compilation for the > > x86-default target. > > > > Note for maintainers/users of the script: for existing environments, > > the x86-default target might get broken by this patch since the script > > now tries to build all "installed" examples and dependencies for some > > might be unfulfilled. > > To fix this temporary situation, you can either delete the whole > > directory or reconfigure it: > > $ meson configure $DPDK_BUILD_TEST_DIR/build-x86-default \ > > -Dexamples=buildable > > > > Suggested-by: Bruce Richardson > > Signed-off-by: David Marchand > > --- > > Changelog since v1: > > - rebased on main, > > - introduced a new "buildable" special value for the -Dexamples option, > > - installation of the "multi-level" examples has been fixed, so > > corresponding exceptions have been removed, > > - a fix for the vhost is waiting in next-virtio, I assume it will get > > pulled before this series, > > - the only remaining exception is for vm_power_manager which is broken, > > > > --- > I'm not sure my "suggested-by" should be on this, since the idea of adding I was not sure how to credit my copying of the meson bits :-). > an extra buildable option is not mine here. I actually think I prefer the > previous approach based on your original suggestion of always skipping > unbuildable examples. Two reasons for that: > * I'm not fully sure of the value of installing examples that can't be > built, which was the original issue you raised. Thomas objected that all examples have always been provided regardless of the configuration. The examples serve as documentation and the API/guides documentations are all compiled anyway. > * I don't like mixing together two separate things - examples to build, and > examples to install in a single option. Yes, I am not entirely happy either. Time is ticking, I'll just drop this patch for 20.11. -- David Marchand