From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, Aaron Conole <aconole@redhat.com>,
Michael Santana <maicolgabriel@hotmail.com>
Subject: Re: [PATCH] ci: check C++ headers with clang
Date: Tue, 1 Jul 2025 13:37:30 +0200 [thread overview]
Message-ID: <CAJFAV8yEDadxrpNjnjOkqna8vDdf8gEgdSLB-250-o9x+ZccoQ@mail.gmail.com> (raw)
In-Reply-To: <20250701113146.1268492-1-david.marchand@redhat.com>
On Tue, Jul 1, 2025 at 1:33 PM David Marchand <david.marchand@redhat.com> wrote:
>
> If not passing an explicit compiler for C++, meson uses c++ which
> defaults to /usr/bin/g++ on a Ubuntu system.
> Explicitly choose which compiler to use for C++.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Depends-on: series-35592 ("node: fix C++ compatibility errors (option 2)")
>
> ---
> .ci/linux-build.sh | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
> index e9272d3931..6156fc0e80 100755
> --- a/.ci/linux-build.sh
> +++ b/.ci/linux-build.sh
> @@ -54,6 +54,12 @@ check_traces() {
>
> cross_file=
>
> +if [ "${CC%%clang}" != "$CC" ]; then
> + export CXX=clang++
> +else
> + export CXX=g++
> +fi
> +
Looking again, it may be safer to move this block in the
check_includes branch (wrt cross compilation targets, though I would
expect the cross config file to override any CC or CXX variables
content).
But let's see what the CI has to tell with this first revision.
> if [ "$AARCH64" = "true" ]; then
> if [ "${CC%%clang}" != "$CC" ]; then
> cross_file=config/arm/arm64_armv8_linux_clang_ubuntu
--
David Marchand
next prev parent reply other threads:[~2025-07-01 11:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 11:31 David Marchand
2025-07-01 11:37 ` David Marchand [this message]
2025-07-03 8:20 ` [PATCH v2] " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yEDadxrpNjnjOkqna8vDdf8gEgdSLB-250-o9x+ZccoQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=maicolgabriel@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).