From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4A95A055F; Thu, 20 Oct 2022 13:48:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6E1A42D70; Thu, 20 Oct 2022 13:48:42 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 187BA42D6F for ; Thu, 20 Oct 2022 13:48:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666266520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DjW8QekwTCT+vIzP1Sl4drYCZern21xAu1iVTTx+1TE=; b=CpC8PI0jqGy/3XcyqG3uo7GYgw+sPGASdenJ0p6b0FgJlhbQyORQffm3AQIJKOJ3UqXXHw yeuMzCYj/WrI1mZH9lFaAWi7vav9rNO4AXCrogELEEJvIGSiLv2MpRRf1jBCsF6iIbz1QM ac0JPYM+MMki2R1hbf0ctN1u461c8+k= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-45-6lVGVMoSMXq8Z6IenMHt0g-1; Thu, 20 Oct 2022 07:48:39 -0400 X-MC-Unique: 6lVGVMoSMXq8Z6IenMHt0g-1 Received: by mail-pl1-f199.google.com with SMTP id q3-20020a17090311c300b0017898180dddso13756717plh.0 for ; Thu, 20 Oct 2022 04:48:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DjW8QekwTCT+vIzP1Sl4drYCZern21xAu1iVTTx+1TE=; b=W0f+TKBlTYVvpbo5rR0W+APtKWbPyGBhRKMvJQDaf0QWU9yBGFyCisOcwrfE2UqJkJ 7fS3JOeR94I5jFolu3txBPhbbAC8+SPJTRjFy38n0PECZ4xXOIxQ292tvJpm4XR0FLX7 w2GeSQw3Fx25LZPGTFtwvbacmZDc/zmslc6qzTFFVw6+eIEBwbUtZSBvrQqKmu0fhVCr fqlXmcBOI+oro7c5hfhl6SrgbdUQeCs/0lspWS1kzJFNxwa38yNZb/xeYF5s+ZbMlePj NKnefNPKwIlkYEnG0lJyGzlrulIB+J4gf0rxkyJofGCURNrQ/73o+LLRmsgbmDhnb0P4 tgpg== X-Gm-Message-State: ACrzQf2/rnIO8VTgyv3ijGdMuzxwJ26Rm5p4v3/O9i/LWi3L9U4DfHZA 3torEkhCeXeofMDITNMTRoIfpHsSaq4Rz6SU2bnrMvmvjxwGEL7/wwTaUNT431xURm2dyYQtMYF SAunIc6y4kF0ndMebTks= X-Received: by 2002:a17:90a:428e:b0:205:d5fe:e0b3 with SMTP id p14-20020a17090a428e00b00205d5fee0b3mr15492970pjg.33.1666266518412; Thu, 20 Oct 2022 04:48:38 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4iB1BK2nxbXvFVgORuqT6Ma5ERPP1ZZ2ICLYgWecCd8WyDkCCR97W9p6/m9fOVTq5kwrjVJ/b6T0PJtIZ6WLM= X-Received: by 2002:a17:90a:428e:b0:205:d5fe:e0b3 with SMTP id p14-20020a17090a428e00b00205d5fee0b3mr15492953pjg.33.1666266518181; Thu, 20 Oct 2022 04:48:38 -0700 (PDT) MIME-Version: 1.0 References: <20221019073702.3948624-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Thu, 20 Oct 2022 13:48:26 +0200 Message-ID: Subject: Re: [PATCH] telemetry: support boolean type To: "Power, Ciara" Cc: "dev@dpdk.org" , "Richardson, Bruce" , "mb@smartsharesystems.com" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Ciara, On Thu, Oct 20, 2022 at 11:54 AM Power, Ciara wrote: > This is a nice addition to the library. > > > -----Original Message----- > > From: David Marchand > > Sent: Wednesday 19 October 2022 08:37 > > To: dev@dpdk.org > > Cc: Richardson, Bruce ; > > mb@smartsharesystems.com; Power, Ciara > > Subject: [PATCH] telemetry: support boolean type > > > > Add the boolean type RTE_TEL_BOOL_VAL for values in arrays and dicts. > > > > Signed-off-by: David Marchand > > --- > > app/test/test_telemetry_data.c | 88 +++++++++++++++++++++++++++++++++- > > lib/telemetry/rte_telemetry.h | 36 ++++++++++++++ > > lib/telemetry/telemetry.c | 24 +++++++++- > > lib/telemetry/telemetry_data.c | 44 +++++++++++++++-- > > lib/telemetry/telemetry_data.h | 5 ++ lib/telemetry/telemetry_json.h | 34 > > > Acked-by: Ciara Power Thank you. Fyi, I'll respin this patch to fix Bruce comments. I will send it as preparation for the trace telemetry additions. -- David Marchand