From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07A6B423C3; Fri, 13 Jan 2023 14:53:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EFFDA42E0F; Fri, 13 Jan 2023 14:53:36 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B5EDC42D53 for ; Fri, 13 Jan 2023 14:53:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673618015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cpdnxoRgnh3681Y6Qc4NavnxV5N1H3lroy5+m4sByiw=; b=dY8VrJomLvV35nrExm6GPAQD7Yxt33omQsylsFvPTR073alVtrj5WdYJmEprhpMyJQB2Gy FR47WCawvmYE3oC0Yo6D0ZhL92DcZ+5a8Eqy8HrfzmJ0AJwihlobUzDNGI7SKEHKlQuwrU /SUG0lw6ieqVSwZpS6Dimu/jfIbTwIc= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-290-MIzCuPsPNwGQe-minHx7eA-1; Fri, 13 Jan 2023 08:53:34 -0500 X-MC-Unique: MIzCuPsPNwGQe-minHx7eA-1 Received: by mail-pl1-f198.google.com with SMTP id p14-20020a170902e74e00b00192f6d0600eso14831709plf.3 for ; Fri, 13 Jan 2023 05:53:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cpdnxoRgnh3681Y6Qc4NavnxV5N1H3lroy5+m4sByiw=; b=fqEpX7DWvbk3pc2+zx++0PRWQBEhRPl/j0MacshM2VB/wEAey476JHDvf20WyrM24x /FoZRFSRRmPXA55tO+Mj+zgYL19jtdN61AWFPjBwRb67vUDD42bkHFoKENdRxEzlcZGE k2OHiq7a9zK3ILFX5f4DdSU9Pd0RoRp5FQawehMrlFEvrokFikvcxaHixYfg31MdH6ZS nsIpPyDRK6+tD6Yrvbas5z0Ki0m6XII8y4Es9qFu+qjIptxI+yuWWnDayys9Ycp+iGPa TJOKhTxzAfz9ugSFIvfNpqfuDrCc2CKk2R7p+FbrmM3vZlKXunQooVI4YF3pOTXJCgbP NHvA== X-Gm-Message-State: AFqh2krQHRV61pKMWS4uVmtfhoFxnovtgy8I0OjMFNk2XFJJAxMvey5K sanTvYG7jwHmXOmJKiCMjzxYUKcIZmEI/RywKsyLM/YBDM+6EeXoJt4OpjJfWmKOy/n1TROl+sh ni1GXrPd4AinZlAqV8o0= X-Received: by 2002:a65:58c1:0:b0:4c2:215f:a397 with SMTP id e1-20020a6558c1000000b004c2215fa397mr277112pgu.426.1673618013031; Fri, 13 Jan 2023 05:53:33 -0800 (PST) X-Google-Smtp-Source: AMrXdXuRy2hmUQy+d+amhg086GCuMcSkhSYhy8YYpmoCru3266DEhkqTYasVWcEGQYZZ5Jc+5z2I/g6sFL4RCUvjO9s= X-Received: by 2002:a65:58c1:0:b0:4c2:215f:a397 with SMTP id e1-20020a6558c1000000b004c2215fa397mr277101pgu.426.1673618012761; Fri, 13 Jan 2023 05:53:32 -0800 (PST) MIME-Version: 1.0 References: <20221212143715.29649-1-david.marchand@redhat.com> <20221213091837.87953-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Fri, 13 Jan 2023 14:53:21 +0100 Message-ID: Subject: Re: [PATCH v2] net/i40e: don't check link status on device start To: "Zhang, Helin" Cc: "Zhang, Yuying" , "Xing, Beilei" , "Mcnamara, John" , "dev@dpdk.org" , "stable@dpdk.org" , "Zhang, Qi Z" , Dapeng Yu , Wenxuan Wu X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jan 13, 2023 at 2:51 PM Zhang, Helin wrote: > > > > > -----Original Message----- > > From: David Marchand > > Sent: Friday, January 13, 2023 9:47 PM > > To: Zhang, Helin > > Cc: Zhang, Yuying ; Xing, Beilei > > ; Mcnamara, John ; > > dev@dpdk.org; stable@dpdk.org; Zhang, Qi Z ; > > Dapeng Yu ; Wenxuan Wu > > > > Subject: Re: [PATCH v2] net/i40e: don't check link status on device start > > > > On Fri, Jan 13, 2023 at 2:39 PM Zhang, Helin wrote: > > > > > > > > > > > > > -----Original Message----- > > > > From: David Marchand > > > > Sent: Friday, January 13, 2023 9:33 PM > > > > To: Zhang, Yuying ; Xing, Beilei > > > > ; Mcnamara, John > > > > Cc: dev@dpdk.org; stable@dpdk.org; Zhang, Qi Z > > > > ; Dapeng Yu ; Wenxuan > > Wu > > > > > > > > Subject: Re: [PATCH v2] net/i40e: don't check link status on device > > > > start > > > > > > > > Hello i40e maintainers, John, > > > > > > > > On Mon, Jan 9, 2023 at 10:21 AM David Marchand > > > > wrote: > > > > > On Tue, Jan 3, 2023 at 3:02 PM David Marchand > > > > wrote: > > > > > > Hi i40e maintainers, > > > > > > > > > > > > On Tue, Dec 13, 2022 at 10:19 AM David Marchand > > > > > > wrote: > > > > > > > > > > > > > > The mentioned changes broke existing applications when the > > > > > > > link status of i40e ports is down at the time the port is started. > > > > > > > Revert those changes, the original issue will need a different fix. > > > Hi David > > > > > > Does it break all the application or just a specific application? > > > > I don't see how it would not affect all applications seeing how the original > > patch is dumb. > > > > > We may need to understand the issue you met, and try to fix it later. > > > > Just unplug the cable or fake a link down on your i40e port, start your > > application or port, then plug the cable back. > > The max frame size will never get applied to hw. > Got it, I will forward to a right expert to check. Thank you very much for reaching out to us! I hope I get a reply _soon_. Or I will just apply those reverts. Thanks. -- David Marchand