From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41F41A04C9; Mon, 14 Sep 2020 11:21:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 01E602BAB; Mon, 14 Sep 2020 11:21:03 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id ACB72160 for ; Mon, 14 Sep 2020 11:21:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600075260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oJrGf3/q1uH8kdOhlA0adfMsjqos09BfpIHgLDHt8oU=; b=OVl3W2+Egb9sru2t0p7kETGLQ3gsMhJ/kAbBii9w8d2P6wZibLLJH6FEqIv+8IQu60dnUM 8qAxsnRj9jXou9bqyncq6K7JVe/po6zP0wU4V+JrxfPAoe43Wc59Y96tgjir1NvPhGOqYd oZtWP0UVbzRbVVs7XnkJuLl5Hnppw8U= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-159-lXz9jddCOn2nh4h-z-TGVw-1; Mon, 14 Sep 2020 05:20:58 -0400 X-MC-Unique: lXz9jddCOn2nh4h-z-TGVw-1 Received: by mail-vk1-f199.google.com with SMTP id e2so1642048vkn.11 for ; Mon, 14 Sep 2020 02:20:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oJrGf3/q1uH8kdOhlA0adfMsjqos09BfpIHgLDHt8oU=; b=UYPb7rJbYRsxcj2eATFZFYRrWQJSq6i+5Kv3vd+0gguUhiRp2upzKF0hk2VUO1c1Pp k1ojee4FKApVHUKSAqOBB7rYqi6G3OuElSNoMOyz7zVeWdWtRoa9tF8/ZbHLuc8mVwNO eWLrqBa9CotrcF+ipHMM685Xu/qPm7Sx2i2pUdbefHbPKxzJiVfASQoSNTs3Kd3DU8Xz NHDb/+2Ty1YogNY6V+IQ8OIwoj/g3VEOw/vuaaUniwv7E8WneFhgt7sJidysdGPlgYoI 1oQ1u0BqeCId741xsjGlUdiTG3TvayfuyNm8LnYCIRj1TZn7QkG+qlPaP+yaG0Pzrrmu jw0Q== X-Gm-Message-State: AOAM5316a+t94D8kYKvquM6UC7Qv+UYjH2AYrmkzxOSbQ7+w3D22xeC9 tutlQwCv+UJM1oWnTarK6b89J25kOq7qEz4FTwKlyX0ft/W8lge0I0E1gYrz468n7MZ8sWKcchJ dhfKBn6rE5gRVL9qq8Rc= X-Received: by 2002:a67:ee02:: with SMTP id f2mr7029555vsp.11.1600075256685; Mon, 14 Sep 2020 02:20:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrrk/DrS99AMNmsztQ74M0GVQszcBQp1loxJt8rTMWH1+WkXsmjNIN7Nj6c5iiSKELe7LmPoWOffGqhapCF+I= X-Received: by 2002:a67:ee02:: with SMTP id f2mr7029548vsp.11.1600075256456; Mon, 14 Sep 2020 02:20:56 -0700 (PDT) MIME-Version: 1.0 References: <20200729063105.11299-1-feifei.wang2@arm.com> <20200911161002.19816-1-feifei.wang2@arm.com> <20200911161002.19816-6-feifei.wang2@arm.com> In-Reply-To: From: David Marchand Date: Mon, 14 Sep 2020 11:20:45 +0200 Message-ID: To: Honnappa Nagarahalli , Feifei Wang Cc: Konstantin Ananyev , Olivier Matz , "dev@dpdk.org" , nd , "stable@dpdk.org" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 5/6] test/ring: fix wrong size used in memcmp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 14, 2020 at 6:38 AM Honnappa Nagarahalli wrote: > > > > > > > When using memcmp function to check data, the third param should be the > > size of all elements, rather than the number of the elements. > > > > Furthermore, do code clean up by moving repeated code inside > > 'test_ring_mem_cmp' function to validate data and print information of > > enqueue/dequeue elements if validation fails. > This patch is fixing 2 things. But only the memcmp issue need to be backported to stable. I would prefer to split this into 2 and mark only the memcmp commit to be backported. +1 -- David Marchand