From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0993743D78; Fri, 29 Mar 2024 09:16:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E7C814014F; Fri, 29 Mar 2024 09:16:26 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C519440042 for ; Fri, 29 Mar 2024 09:16:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711700185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zCzTn60a+hACm0eYDwaUqfzxI5i/Oullx2EhW1iEuR4=; b=Gj+Vb4GK26lMHVhgPCF3lUxUKLB1YnOw8RWBUOffptzOj9Q7cYxMGIYzBEIRZaF5u0MxZF r/4V6rNB6PnIjoJwlnqPRgyH27tyCzNN+QNdoq2KaphxTSetqItPC2cZtq87iASDRyh14c LUl5KIF4FPltRJu0rYA0rED6J6tEj8I= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-puHEkVJIN_2FUeesylNuLA-1; Fri, 29 Mar 2024 04:16:21 -0400 X-MC-Unique: puHEkVJIN_2FUeesylNuLA-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-513e0186809so1343135e87.2 for ; Fri, 29 Mar 2024 01:16:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711700180; x=1712304980; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zCzTn60a+hACm0eYDwaUqfzxI5i/Oullx2EhW1iEuR4=; b=SqkGkfzfkqdMvjcspVcKRh4Eyek1UKnU6wK+xjn8dnbri8xtru2X5iQfaM3RZr1xSx Fh+yZcg86mPUw5qHWC/n9iyWF4TR70GzESN0ZRf59vydvVmgvN/zj5u7McMuwprbBLKD +6VzgXK3s5OCR1YOuswJWe5+0kqHoG8omjtRbDpHo8W5V/QwGJSqrV0lfnBRGm/cRJDs UyPYUYE6aavmAD7jQpkiiXYpLJbP7uz6twiTHA3966VlJRNLqOS05E0quXn1RPhvMhy9 MkiGFTv0aoebrIksoutNbAVbI4kpQwP4oNvAFJ/QIgpA5TPxUadh1kGDA4825/2Ee9s6 MApg== X-Gm-Message-State: AOJu0YzpCTjHwqIHVac/yEQFIDL4g+5OCTVzAbLELtIyoUua1A2GLhzl eMye2xFyTR738zpApb2wPxRlEA0hCzyuRZ+dSfv3dOINpoqHAhUJTA+/0OX8fSSJU1+0+kKvhV0 We3mPqG5CnHsCi9cfvdS8+fW1e8YggaPFciHn4YmiuehGva8sV7ifm3HgMJle3TTPzslasFOp2W j8iod/Eg+3pCgGsCk= X-Received: by 2002:a05:6512:3d26:b0:515:bec6:a0bb with SMTP id d38-20020a0565123d2600b00515bec6a0bbmr1490022lfv.20.1711700179924; Fri, 29 Mar 2024 01:16:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFXeI+hbK/uDOUmcnd5IY7rjeYPx6+uBBYxoFXPZJFLSrtAwfgv7ayQRWTPbmF0gG4/pdMv852vxGvzJ1OJU4c= X-Received: by 2002:a05:6512:3d26:b0:515:bec6:a0bb with SMTP id d38-20020a0565123d2600b00515bec6a0bbmr1490009lfv.20.1711700179593; Fri, 29 Mar 2024 01:16:19 -0700 (PDT) MIME-Version: 1.0 References: <20211102070827.141162-1-jie1x.wang@intel.com> <20211105033705.285200-1-jie1x.wang@intel.com> In-Reply-To: <20211105033705.285200-1-jie1x.wang@intel.com> From: David Marchand Date: Fri, 29 Mar 2024 09:16:07 +0100 Message-ID: Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix forward outer IPv6 VXLAN packets To: Bruce Richardson , "Mcnamara, John" Cc: dev@dpdk.org, yuying.zhang@intel.com, xiaoyun.li@intel.com, stevex.yang@intel.com, beilei.xing@intel.com, qi.z.zhang@intel.com, Jie Wang , stable@dpdk.org, Kevin Traynor , Vladimir Medvedkin X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Bruce, John, On Fri, Nov 5, 2021 at 4:39=E2=80=AFAM Jie Wang wrot= e: > > Testpmd forwards packets in checksum mode that it need to calculate > the checksum of each layer's protocol. Then it will fill flags and > header length into mbuf. > > In process_outer_cksums, HW calculates the outer checksum if > tx_offloads contains outer UDP checksum otherwise SW calculates > the outer checksum. > > When tx_offloads contains outer UDP checksum or outer IPv4 checksum, > mbuf will be filled with correct header length. > > This patch added outer UDP checksum in tx_offload_capa and > I40E_TX_OFFLOAD_MASK, when we set csum hw outer-udp on that the > engine can forward outer IPv6 VXLAN packets. > > Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API") > Cc: stable@dpdk.org > > Signed-off-by: Jie Wang - There is a bz opened by a OVS user trying to offload geneve checksum. https://bugs.dpdk.org/show_bug.cgi?id=3D1406 Reading the X7xx datasheet, parsing i40e_parse_tunneling_params() and looking at the packets reported by the user, I understand that outer udp checksum is actually *not* supported by net/i40e. And so the change from this mail thread should be reverted as the driver falsely claims support for this feature. - I found some bits about X722 (5535087e6c56 ("i40e/base: add outer UDP checksum for X722")) supporting this feature, but I did not find a definition in the datasheet. Besides, this I40E_TXD_CTX_QW0_L4T_CS_MASK is not used in the net/i40e tx p= ath. We need Intel to clear state what is supported or not, and send fixes accordingly. Thanks. --=20 David Marchand