From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1A2C455D9; Tue, 9 Jul 2024 09:53:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4BE4642FFD; Tue, 9 Jul 2024 09:53:15 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DC1F140DD6 for ; Tue, 9 Jul 2024 09:53:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720511593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rwRg9E2hbc6eAv4s5aizJq+9GxTHTcBaUMdEcCH4a1w=; b=Bu45/eQGKzehwcymP9McaudS6eR3FcbSq4cHdpiH9LzITzcdsal7XW+vbQgKSJkGvMQdsf 3mPeq7L50m6vqqLwGag0BlaNYxB5jholkS6m3AXjf1UMZTKyAh3T3hiMypoke428FBcNtT H7ZHz7VI33xSLH2vkN9NTvs/TebmB2o= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-292-M4QhvzQIOHGIMkyxLFV4Sw-1; Tue, 09 Jul 2024 03:53:11 -0400 X-MC-Unique: M4QhvzQIOHGIMkyxLFV4Sw-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2ee91034250so48809901fa.0 for ; Tue, 09 Jul 2024 00:53:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720511590; x=1721116390; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rwRg9E2hbc6eAv4s5aizJq+9GxTHTcBaUMdEcCH4a1w=; b=U4CKi6JYJHRhTO2eis+z03e/b694OrMuGTwyQ3peZ6Sbr6h7WW3i3TY4QIrmTffiBV krtviZhEqvf2MBkKfAnFhGwdw2Z3NEQShovytxEPUF8IHjWa2ejgb4jyL2glAQ8jJWkq 7eizsHaZ7wq4ff4M3iIAzsWWrUF6DqThUUd93GtUAE3o/W4pxq2xYc4Np3moEAxNXYbj 0sjiYBbMI2d3znNuPl+JyjybMLqpbp++XDK5Em+ykoioBKNb3fGs8h9ho0wR1XQWTfP2 Y5orv2vArQSQJq+VVPqRz6OeMAx9UsOlMaVJ6pkiWOjEIHHDd6GrPocldYxCdx6cNyTe 3Nrg== X-Gm-Message-State: AOJu0YwQxCiFqEonUniNvrKpYvTV1d2EqEgWnjNUHYcPukifam9iWOGf jpUaueuMPSeSP64B9wF7Tcpa7FsPfm8bOlSuFg4MYhhAV+I/IvfESz3z+RyYlI86Tvoi9WMHxJ7 G6/rhpW+MkGBIef+1M4ToF1SoWm/5h5L+fB4P51aTQnmwVCZvzOMMcMwcsokWwlxlJScrOOtmYE x0r7EqYiTjqyFldxi7yMs+9RM= X-Received: by 2002:a05:651c:1026:b0:2ee:64cf:f8f3 with SMTP id 38308e7fff4ca-2eeb3181c6fmr14434681fa.33.1720511589818; Tue, 09 Jul 2024 00:53:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGThHF4ti1rgvJ1sprHsUKGnMvg3reXiHzXrzqcSCOwYakoWK0zQZVjwsCzxlgtmdD5W53U3f2jVessCCbMsC4= X-Received: by 2002:a05:651c:1026:b0:2ee:64cf:f8f3 with SMTP id 38308e7fff4ca-2eeb3181c6fmr14434541fa.33.1720511589420; Tue, 09 Jul 2024 00:53:09 -0700 (PDT) MIME-Version: 1.0 References: <202407091430583513KWtIU86wZpFC0Fh-sDB4@zte.com.cn> In-Reply-To: <202407091430583513KWtIU86wZpFC0Fh-sDB4@zte.com.cn> From: David Marchand Date: Tue, 9 Jul 2024 09:52:57 +0200 Message-ID: Subject: Re: raw/zxdh: introduce zxdh raw device driver To: zhang.yong25@zte.com.cn Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, On Tue, Jul 9, 2024 at 8:31=E2=80=AFAM wrote: > > I have made some changes as suggested. Is there anything else that needs = to be changed? This new patch can't be tested by the CI, because it does not make sense individually and there is no reference to the patch introducing the new driver. It does not make sense to apply a first patch with a vdev driver to change it after as a pci driver. Please rework this driver as a pci driver from the start. Besides, this new driver code is a bit large, please split it into parts that can be more easily reviewed, adding documentation in each patch (when relevant) and update the release notes. As to how to split, I suggest you look at the git history for existing raw/cnxk* drivers. To be franck, seeing how this driver comes so late in the release and because we don't have reviews, this driver will certainly be deferred to the next release. Thanks. --=20 David Marchand