From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DE00A09D3; Thu, 12 Nov 2020 10:39:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 30E1E592B; Thu, 12 Nov 2020 10:39:51 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id E7CF51E2B for ; Thu, 12 Nov 2020 10:39:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605173987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EVt4nkB2DWlqjKtZXgIONQKLsQFtVSau7qoBtF4hrmc=; b=Ue2cyviMVnDfTkCTAvlR1hlALaLOum/vhPmfCU1k7KsOXwNlt85xQtUkfABLTNnkpz/rp/ NYPsCkwx6XW1dzd0dNcGLeKuHQP08QnLchbiSFzittgqmSqpMw4xDV/IRiOeu1deZqxQSr 5ErTEok7ntFLQ5vr6Vvugh4L0HYi43k= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-5-ReTK25-VOP2pcYjGdlsftw-1; Thu, 12 Nov 2020 04:39:45 -0500 X-MC-Unique: ReTK25-VOP2pcYjGdlsftw-1 Received: by mail-vs1-f69.google.com with SMTP id h5so1542221vsq.16 for ; Thu, 12 Nov 2020 01:39:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EVt4nkB2DWlqjKtZXgIONQKLsQFtVSau7qoBtF4hrmc=; b=GCY9rP0uLrSddqTHut/qY+eHoG1YEZxv5bqB+8I034BWNdcehz8NnKZASpKuPp9siO 89x2JrpINsiniUzkAyUztRVT1hyrUBF/PkxiIXRTinM2Z09f+QtM3CtOsaIYt+WzDp+y tXaQE6VpuMyDiHLJaC3f5l9v5Axax7AIp+PSE28aU4i6YHZVzRnIg0A/kAQb67H8vA4f moVvok17wujWrPjaS/iQdoxNSnUNg7A3aRB5reZyi1NuCaP5vN+UD27xK04cBDam4rO8 /+CsmbhlmDihw1qk7CYKcxsB6Er9CEkZEPu19f7y/FsJfoA9y56N9BvfiVdF3XampJ2I zNqw== X-Gm-Message-State: AOAM531FBtaLMHvN22HJYZqZm9DDQiNLMfrSRDPqfbs/62ZrIEtfuJp4 KLIaXQwanmltLtNkpQj+ZJJaetHR6ECM2wmoKEkixJsPJmqF9TeW6yAHJ7PMX8j+70K+SoUDDwP PPphME2WlNSZ2HnKDDB0= X-Received: by 2002:a67:fd46:: with SMTP id g6mr18531320vsr.27.1605173985143; Thu, 12 Nov 2020 01:39:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJy/DufwoB6fWf2R9EV6/TanCioKxFu3wp4g5wlRs14X1hoUgqdQzVBLs9sNPxWMKUc+f+cZ0HzzDGKwk1fNj7A= X-Received: by 2002:a67:fd46:: with SMTP id g6mr18531316vsr.27.1605173984993; Thu, 12 Nov 2020 01:39:44 -0800 (PST) MIME-Version: 1.0 References: <20201111111957.46090-1-Cheng1.jiang@intel.com> <20201112093113.GB1309@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201112093113.GB1309@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Thu, 12 Nov 2020 10:39:33 +0100 Message-ID: To: Bruce Richardson Cc: "Jiang, Cheng1" , Maxime Coquelin , "Xia, Chenbo" , dev , "Fu, Patrick" , "Yang, YvonneX" , "Hu, Jiayu" , Thomas Monjalon , "Yigit, Ferruh" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1] examples/vhost: fix ioat dependency issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 12, 2020 at 10:31 AM Bruce Richardson wrote: > > > main.c should check for RTE_RAW_IOAT before including ioat.h. > > > And then in this header, you can remove this stub too. > > > > > > > As for this one, ioat.h don't have dependency on IOAT driver, it is needed by the example regardless of whether the raw/ioat driver exists. And I added more RTE_RAW_IOAT check in ioat.h. Now it can be compiled. > > > > The trouble is that the ioat header file won't be installed if the driver > is not built. They will be available for building inside the source tree, > but not on a system with dpdk installed using "ninja install" I tested disabling the driver, and I can see: installdir/usr/local/share/dpdk/examples/vhost/ioat.h -- David Marchand