From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BF52A056C; Wed, 4 Mar 2020 10:37:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 585A51BFAE; Wed, 4 Mar 2020 10:37:41 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 9902C1BE7D for ; Wed, 4 Mar 2020 10:37:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583314658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SvFLDypuF8DmILxlBFRFN+v0rP/UM2scB6FMXyOsiW8=; b=LbCwp67Uid5Qw7lmp6oIjARY7M5dMZT5yRbGgAyJMfB25ZN7M0NrOb7wT9KwdIFELGB5dN qmnbukWjKeW7RVfPlNSmmCu/3I/0vtGEuct6VNya4Sq/WlEVoIT+9yJ5SZloP06M5F/YxO lFUF46C/UjSMeHag3h9n7EgDkJebYKY= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-383-b_EM_ATHNKCfCwm4LogpRQ-1; Wed, 04 Mar 2020 04:37:35 -0500 X-MC-Unique: b_EM_ATHNKCfCwm4LogpRQ-1 Received: by mail-ua1-f71.google.com with SMTP id o13so172096uad.7 for ; Wed, 04 Mar 2020 01:37:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RAT30+oh/+/5GfM1Vcv5MyeFAT49EGIETLJCsuDDecA=; b=Jserd50d+FCVl7n4RF2GCrbGQxznbLgGum9CPNtXPFXSRyHy2p/JVovnk0TBlaHGxR FMTjEZZ6Jf2xk5o8sOdYWEf4f3PFAlTLOf9g39PenuHv1evlOOS0aFN3Ccu61V28QkDC Sytwmm03WaYq6eikJy3ogOSnkraabxG/HIxcePsh7KPlRbB+V5OI/5/NonCgRh1QCto5 rSvE/tOG2JDWMHG/wS4cVPKSn3atAH5ZGWv+SW+B6qAdtNxt9OgslMEyuoKMuBuJn3h0 m/lfEUMn4EebPmaVX8vjeaXL7xL24B799Rw7cI2bvi+K3lbthSl86+u9C/YQkwh8Teie rqRA== X-Gm-Message-State: ANhLgQ0Mz1QwQG37fMXd0UmYSGeSQfAqnBuZwt0NSdb62Zbb7V7GI7DJ 0atjuF2S42Wljl3bzUs8Von9UwKgajVNxn/BUKL+VUno5r/O1rcy8N0bcPUCOjyPdFaDGRHgQb7 JkO/QPTVIEACbUy7KdeU= X-Received: by 2002:ab0:2801:: with SMTP id w1mr907591uap.87.1583314655198; Wed, 04 Mar 2020 01:37:35 -0800 (PST) X-Google-Smtp-Source: ADFU+vv5mT12aKme9KlDbBLvM0WQ2gO+ifHR26JpE9iX4SUSDIsNv4wppdN2/iCZtJAmKsjvZ7G5St3t++qtI9J/LmY= X-Received: by 2002:ab0:2801:: with SMTP id w1mr907581uap.87.1583314654883; Wed, 04 Mar 2020 01:37:34 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Wed, 4 Mar 2020 10:37:23 +0100 Message-ID: To: Timothy Redaelli Cc: dev , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 0/3] examples: fix building with GCC 10 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Feb 5, 2020 at 2:47 PM Timothy Redaelli wrot= e: > > GCC 10 defaults to -fno-common, this means a linker error will now be > reported if the same global variable is defined in more than one > compilation unit. > > See https://gcc.gnu.org/gcc-10/porting_to.html for more informations. > > I didn't put -fcommon to CFLAGS since: > Compiling with -fno-common is useful on targets for which it provides > better performance, or if you wish to verify that the program will work > on other systems that always treat uninitialized variable definitions > this way. > from gcc man page For the series, Acked-by: David Marchand --=20 David Marchand