From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D18542FB2; Tue, 1 Aug 2023 15:34:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37DEE40F16; Tue, 1 Aug 2023 15:34:21 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E8FFA40A89 for <dev@dpdk.org>; Tue, 1 Aug 2023 15:34:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690896859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0fT//AvPoj2ZUMb21jCKoHH1Z7R/X+vnfZ+Og4fc4ew=; b=WJoLPILmTnXR1Qqg9Ko4rmLeK1tAWymwHqF8BeojIeTDufFjsOVddn8ZqrgX1Ux0Rv3TV2 dpcNhIeAWLPDqQhIpNBVzcnoVkZw+Ki6B9jO5osrNgz7ydPJgjxytidF2nDoh1B+BthLrl zMyLchsPjdGVQJu1kR5Zv63ftL+C08w= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-26-8-yTtov9MN-YQ1-Hp6SuTg-1; Tue, 01 Aug 2023 09:34:17 -0400 X-MC-Unique: 8-yTtov9MN-YQ1-Hp6SuTg-1 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-267f00f6876so3620586a91.3 for <dev@dpdk.org>; Tue, 01 Aug 2023 06:34:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690896856; x=1691501656; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0fT//AvPoj2ZUMb21jCKoHH1Z7R/X+vnfZ+Og4fc4ew=; b=IZ2kREGBNvnNAc77comgx2FtCdAsyyTip8WTqLZ4ebLBuCos6NYKA2u8maI66crco1 adfVaZYavWRye/8Fc1cwTq31OvsDNGTu9fj9hgaPLdCnq9JmglGbtl0pp20L7eNyWVj5 56QL6x0ijB0yBa7R+sb8gKTT3RYiGi/hkDqUK+s7UoZ4i6SKTPHRSk82Ac8HhMvSNK02 tokkAfV/mvqvzkkqTAZgjyGQk742FKnAkVQ4/tFZLOLQa+Kqb2ZLlbRY6T2Jp17oMOds qgVwgafr4afyx8KTmkZJ4OVy5c6OOwP4Yd+jyXiUBudLABE8ffkKJYqYx9Wkp1+/jHaO gmOQ== X-Gm-Message-State: ABy/qLbzOufQXFCPMPiyHreWBTkvOzoEwPwZTHUbgT/HCB6vCJsz08j4 gn18DUyyWe5/fAHqJsmloQRcf/83bFNAU8Uxd9bjorcr4KdDkDDDFs2cWprMgHNGvDypUYS5aTK ZWYXNQN/MHUPh+Hq4aoM= X-Received: by 2002:a17:90b:4a91:b0:263:f4cc:a988 with SMTP id lp17-20020a17090b4a9100b00263f4cca988mr11299355pjb.5.1690896856666; Tue, 01 Aug 2023 06:34:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlHWBGWzR6GlEsXz3T+Ctl6wkTQbFTz/fQaB1d8v7ABwegKFZ/IV+9wbc7yqoPX3qJ1UoEecq8V9nAswdKY8Nwk= X-Received: by 2002:a17:90b:4a91:b0:263:f4cc:a988 with SMTP id lp17-20020a17090b4a9100b00263f4cca988mr11299330pjb.5.1690896856361; Tue, 01 Aug 2023 06:34:16 -0700 (PDT) MIME-Version: 1.0 References: <20230731103858.1491751-1-bruce.richardson@intel.com> <20230801131549.323733-1-bruce.richardson@intel.com> <CAJFAV8yzAG1yhpnKzTFUciitcOd0q3TGPJrqBqh7bP3H_FCO5Q@mail.gmail.com> <ZMkIsU3w5+04ooYy@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <ZMkIsU3w5+04ooYy@bricha3-MOBL.ger.corp.intel.com> From: David Marchand <david.marchand@redhat.com> Date: Tue, 1 Aug 2023 15:34:03 +0200 Message-ID: <CAJFAV8yHXUjAvUzuXvr4KP949cPrXpFHAdBWU=Axhm8Qtmh5tg@mail.gmail.com> Subject: Re: [PATCH v4] build: update DPDK to use C11 standard To: Bruce Richardson <bruce.richardson@intel.com> Cc: dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>, Tyler Retzlaff <roretzla@linux.microsoft.com>, Thomas Monjalon <thomas@monjalon.net>, Ali Alnubani <alialnu@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, Aug 1, 2023 at 3:29=E2=80=AFPM Bruce Richardson <bruce.richardson@intel.com> wrote: > > On Tue, Aug 01, 2023 at 03:24:19PM +0200, David Marchand wrote: > > On Tue, Aug 1, 2023 at 3:16=E2=80=AFPM Bruce Richardson > > <bruce.richardson@intel.com> wrote: > > > > > > As previously announced, DPDK 23.11 will require a C11 supporting > > > compiler and will use the C11 standard in all builds. > > > > > > Forcing use of the C standard, rather than the standard with > > > GNU extensions, means that some posix definitions which are not in > > > the C standard are unavailable by default. We fix this by ensuring > > > the correct defines or cflags are passed to the components that > > > need them. > > > > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > > > Acked-by: Morten Br=C3=B8rup <mb@smartsharesystems.com> > > > Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com> > > > --- > > > V4: > > > * pass cflags to the structure and definition checks in mlx* drivers > > > to ensure posix definitions - as well as C-standard ones - are > > > available. > > > > With this v4, mlx4 builds fine in my Ubuntu 20.04.6 container. > > However, I think the mlx4dv.h includes are probably faulty: as this > > header is using off_t, it should include sys/types.h in the first > > place. > > https://github.com/linux-rdma/rdma-core/blob/master/providers/mlx4/mlx4= dv.h#L36 > > > > This had been fixed in the mlx5 header in some rdma-core change in the > > past: https://github.com/linux-rdma/rdma-core/commit/d2389b34ccc5 > > > Even if that were fixed, I still think the correct behaviour in our build > here is to test the structures using the same flags as will be used to > build the final lib. Yes, compiling for testing and using the structures must be aligned. --=20 David Marchand