From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6680D41C61; Fri, 10 Feb 2023 15:19:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 10054410D3; Fri, 10 Feb 2023 15:19:57 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C47D5410D0 for ; Fri, 10 Feb 2023 15:19:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676038794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1JPQeJLcIdueiQ2kJypFAYI3ufzeDvd5V/BOlgLPBVU=; b=LL9YDE/IcZIXAHH2+jcA3TFWCxdgpNsRBakG8sQ6llbma+ABczMG1XfuPGMrdv6b1sfaVd gNkPzn7Bj8Q3tKaZnPsJ5a/+VkQv8ASbfzL1Ksah/Ii2MJmoRCxVgIjohjD21ZR3KQQ8+N hKgaYznbKV57HeRT0drGke/0wNIOAnc= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-55-x1vxV1L5PZG5WMDB4WA2nA-1; Fri, 10 Feb 2023 09:19:53 -0500 X-MC-Unique: x1vxV1L5PZG5WMDB4WA2nA-1 Received: by mail-pl1-f199.google.com with SMTP id y8-20020a170902b48800b00192a600df83so3091091plr.15 for ; Fri, 10 Feb 2023 06:19:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1JPQeJLcIdueiQ2kJypFAYI3ufzeDvd5V/BOlgLPBVU=; b=5w3RKArl7NRrgK+DUbDCGwYZOOx+0yWFsAjVhUl1KaICsXvN7IzhT5xc5PC5JeH2Xh 9rmT5Sgrk7I+Gam//mwXHUCnFvwP4k2wg+RCY5xkScav5hfWc/vjYo+/XT8BiznWrl3A Uxjs3p+rnZqfJeKJFIgMj0Rz5zKsBDjH3h0gJgySrwpcYJGpiep5TYcDYkRqak5MI4dE 7lRmjVRdXUqticEpDsZ5ZS7a3TyaHW2BV0Eclqgosda/djOPxYnoJ4IC06L0CMeUngAX CUxcBGB/FqMBagXLYvRstJLdi99cSklpFCtuN7sw00d8YQsV2DKWnnS2ZKfusIstwVDL LG4w== X-Gm-Message-State: AO0yUKXQjauUGx3UodL3bWHXWUEVYKilTUikh8BEszhtc/FX4dMA1W/y PHubn6V2g9KSe3yVYCIdaF2l4LUN5wd5jvPQDdc5Rrkzk5SX1IhVn6r03ZBSPVFNxRD9IivKzRo 5mdzyRgkLV75MxK/Dshc= X-Received: by 2002:a63:954c:0:b0:4f2:8007:5e1f with SMTP id t12-20020a63954c000000b004f280075e1fmr2903019pgn.58.1676038792152; Fri, 10 Feb 2023 06:19:52 -0800 (PST) X-Google-Smtp-Source: AK7set9UM+d3XWELBu9yDrb7JLtVBcjQ/y7MHAum7acLmihfOggahsO92ycddFuOAaD120QaenJjWs5oXdnxwEKNeu4= X-Received: by 2002:a63:954c:0:b0:4f2:8007:5e1f with SMTP id t12-20020a63954c000000b004f280075e1fmr2903009pgn.58.1676038791893; Fri, 10 Feb 2023 06:19:51 -0800 (PST) MIME-Version: 1.0 References: <20230209133019.933380-1-adwivedi@marvell.com> <20230210103446.1126999-1-adwivedi@marvell.com> <20230210103446.1126999-5-adwivedi@marvell.com> In-Reply-To: <20230210103446.1126999-5-adwivedi@marvell.com> From: David Marchand Date: Fri, 10 Feb 2023 15:19:40 +0100 Message-ID: Subject: Re: [PATCH v2 4/5] ethdev: remove internal tracepoints from version map To: Ankur Dwivedi Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, jerinj@marvell.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 10, 2023 at 11:35 AM Ankur Dwivedi wrote: > > The internal tracepoints are removed from the version.map file. > > Signed-off-by: Ankur Dwivedi > Acked-by: Ferruh Yigit rte_ethdev_trace.h does not need to be exported. I suggest the following addition: diff --git a/lib/ethdev/rte_ethdev_trace.h b/lib/ethdev/ethdev_trace.h similarity index 96% rename from lib/ethdev/rte_ethdev_trace.h rename to lib/ethdev/ethdev_trace.h index 1491c815c3..3f419fbfa0 100644 --- a/lib/ethdev/rte_ethdev_trace.h +++ b/lib/ethdev/ethdev_trace.h @@ -2,8 +2,8 @@ * Copyright(C) 2020 Marvell International Ltd. */ -#ifndef _RTE_ETHDEV_TRACE_H_ -#define _RTE_ETHDEV_TRACE_H_ +#ifndef _ETHDEV_TRACE_H_ +#define _ETHDEV_TRACE_H_ /** * @file @@ -92,4 +92,4 @@ RTE_TRACE_POINT( } #endif -#endif /* _RTE_ETHDEV_TRACE_H_ */ +#endif /* _ETHDEV_TRACE_H_ */ diff --git a/lib/ethdev/ethdev_trace_points.c b/lib/ethdev/ethdev_trace_points.c index 2919409a15..5f08d2dfb6 100644 --- a/lib/ethdev/ethdev_trace_points.c +++ b/lib/ethdev/ethdev_trace_points.c @@ -4,7 +4,7 @@ #include -#include +#include RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_configure, lib.ethdev.configure) diff --git a/lib/ethdev/meson.build b/lib/ethdev/meson.build index 39250b5da1..9e97f05983 100644 --- a/lib/ethdev/meson.build +++ b/lib/ethdev/meson.build @@ -22,7 +22,6 @@ sources = files( headers = files( 'rte_cman.h', 'rte_ethdev.h', - 'rte_ethdev_trace.h', 'rte_ethdev_trace_fp.h', 'rte_dev_info.h', 'rte_flow.h', diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index d25db35f7f..a2d289b7a4 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -27,7 +27,7 @@ #include #include -#include "rte_ethdev_trace.h" +#include "ethdev_trace.h" #include "rte_ethdev.h" #include "ethdev_driver.h" #include "ethdev_profile.h" -- David Marchand