From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1988745482; Mon, 17 Jun 2024 16:25:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E1C014028B; Mon, 17 Jun 2024 16:25:18 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3DA3C4028A for ; Mon, 17 Jun 2024 16:25:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718634316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6lD5mwaiSoTYXMEcLR0x0yFnRtREKB5DxDaensg8zc0=; b=HrFKt5Y/carBzurx4OnF2acdOSP1dtiz4dVNVv75DUhKe7asTqsCJYjeaNAdruqnV3a2EL 0clKDWkZc7qZ5ZosYoJursOv89z7FUgddW/SYr1W0qlE8Z47Ki2fz+CoADAKsvIrpxjkk2 OCO5fc91bzk8Z0G4OvyXhccNqK35jGY= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-445-Ek_Zrc0tM_2kmve1vJEuJQ-1; Mon, 17 Jun 2024 10:25:15 -0400 X-MC-Unique: Ek_Zrc0tM_2kmve1vJEuJQ-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2ebeddcba43so32589031fa.2 for ; Mon, 17 Jun 2024 07:25:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718634314; x=1719239114; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6lD5mwaiSoTYXMEcLR0x0yFnRtREKB5DxDaensg8zc0=; b=BeDGQEXs2nAb+OkWsN9gCVA+kgPcm8/7to56CSg3KaqMXA/WXZYyOzFHWlfGs3gCpC ov0GsCYj/VlsWq3gxaj/ozXyJd1wvRBtWDzJqUqNM4s2/ydNl3U4Iz3BMcuA9Pi8quWR EiibaO9fin2NiBx6magVRyegRBb9JABd4PlBOMUqwwdA4WcTaS+qNa9A4nYLnl5S9gBk /U1cX2nJZQjVpGKkGFyRQ6n2NSCh2nKdG2CspIyicaXJtNvkH6O4FJrLlRClIBNao5tn rOHuT5imkB+UMR49mr0KweuO+1XJJDIo4x2BFIJbDToTURNG/UjxFbmPIqtAY3GvAh85 aJvQ== X-Gm-Message-State: AOJu0YwJM0xTW76N3Jk2nkg9hIvffhK0B1QqB5EPw7o7tAS6nj4MIlfS b8OHplPPFmuPYzjUCyWIW9H6YVPnOMqsab/OXz+vphOzSeCph8RE8OxQSY0i1JfPT8b+UA2LoNx F7cVShDxMIV2MCBhZc2crQdIAv90TyaJ7PtAaO2yQ8Yx/oNg1IxsFTtXB2tAZpn0Th/CGwr2w03 Qv71HRFkYbdJk6Xew= X-Received: by 2002:a2e:8751:0:b0:2ec:174b:75bb with SMTP id 38308e7fff4ca-2ec174b77d9mr56963291fa.28.1718634313911; Mon, 17 Jun 2024 07:25:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG8omcNyo1ynltbJ/UJlHMLSnwOtXxqZD4u5fYm5116dczsR/hEKxvglAp4TJ+es9kNIboE7UvBjDV/Zuh7Q8Y= X-Received: by 2002:a2e:8751:0:b0:2ec:174b:75bb with SMTP id 38308e7fff4ca-2ec174b77d9mr56963211fa.28.1718634313604; Mon, 17 Jun 2024 07:25:13 -0700 (PDT) MIME-Version: 1.0 References: <20240617101334.211756-1-maxime.coquelin@redhat.com> In-Reply-To: <20240617101334.211756-1-maxime.coquelin@redhat.com> From: David Marchand Date: Mon, 17 Jun 2024 16:25:02 +0200 Message-ID: Subject: Re: [PATCH] vhost: fix FD registration to the fdset To: Maxime Coquelin Cc: dev@dpdk.org, yux.jiang@intel.com, chenbox@nvidia.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 17, 2024 at 12:13=E2=80=AFPM Maxime Coquelin wrote: > > A missing return statement in fdset_add() was making > the error path to be systematically executed, this patch > adds it back. > > Bugzilla ID: 1462 > Fixes: 0e38b42bf61c ("vhost: manage FD with epoll") It looks like the initial code was better ;-). > > Reported-by: Jiang Yu > Signed-off-by: Maxime Coquelin Reviewed-by: David Marchand Applied directly in main for rc1, thanks. --=20 David Marchand