From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CDD4A2EEB for ; Mon, 7 Oct 2019 16:52:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1E58E1C1E9; Mon, 7 Oct 2019 16:52:59 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id F06A01C1CB for ; Mon, 7 Oct 2019 16:52:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1570459977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CDY0/wj+ymg8Q7/PjgoC4YjHfn09GBq4y33U7VaiieM=; b=PHevlHTLRiu6PcGKXa7sB5TnmrzITv4t7syytG5Cv1+51ALwOdI72/cNhFQll32lzVqk/T NdP3hnMz0Nxtx+f/eaKLT/nvCrZ4ZSPDbDWLSzhQSfQ+7oun73KKLs9ONp0Yi9/SB1HfYC MZcSYJqW/IMsrxQ4mB6AvDg499TRu9Y= Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-248-dXvO1f_0OFW2g4tNcxXpHQ-1; Mon, 07 Oct 2019 10:52:55 -0400 Received: by mail-io1-f71.google.com with SMTP id k14so27099738iot.14 for ; Mon, 07 Oct 2019 07:52:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w8FDTaLmqKN+NXNE0OZTRtzLePXRhvmEXxSG6Ucyl8s=; b=Q5zT00FGBiT+BMpIx225iUwRlUrKCKcH3LQWGeKXZIBMc3QPtMKkOPpNsGkKZ86Yu4 aSlIJz/Cym2eSnh8x/BIb3BHIglXCNIVPce98Rkse1PCIfhy/O8bx2+6s0eT+xkmQ5rH wTURsEJZjw9Yin/unsMk/OrtNknYU1ii69DcbIae0MBxrdmf/jlnKFEkTjrTYY3v3TCz EYPv52m0hUFHjf8IKwaTaatG4HOsOznwFDOF+5d35yVeadYGCekzylCAYPdxm9Im6fEn HXtUzZUGTo8nqVBIRdxEKdilpbgyMyGHH7U6rfVDYqf++q8+ZDeNHkvw/RIyqp+yrVao I3Fg== X-Gm-Message-State: APjAAAUyRYt1tUjCJgWH9Gl/gyCu+CCC1Ld/E5ko7Jgub4wVmja916Sf Mn3XACU9DngEIDoVWUB6Hya5hICTr8gA3DTQfXfHf6mNgVOrLROx4htLgIhHKTlxVGxmTJrOZht 3TQzvvR3ZKRnm9jXG5X8= X-Received: by 2002:a5d:9918:: with SMTP id x24mr9509269iol.30.1570459975263; Mon, 07 Oct 2019 07:52:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqy+eQeopm5x1YI/sdD3whxeaClJe5M2egGTwT4fHr4B3xwwoR1a7JiHkq0Qnxv3wepymvTiR91/qVrhhETiCXE= X-Received: by 2002:a5d:9918:: with SMTP id x24mr9509213iol.30.1570459974555; Mon, 07 Oct 2019 07:52:54 -0700 (PDT) MIME-Version: 1.0 References: <1568628062-31332-1-git-send-email-nikhil.rao@intel.com> In-Reply-To: <1568628062-31332-1-git-send-email-nikhil.rao@intel.com> From: David Marchand Date: Mon, 7 Oct 2019 16:52:43 +0200 Message-ID: To: Van Haaren Harry Cc: dev , Nikhil Rao X-MC-Unique: dXvO1f_0OFW2g4tNcxXpHQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] service: improve service run performance X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 16, 2019 at 12:01 PM Nikhil Rao wrote: > > For a valid service, the core mask of the service > is checked against the current core and the corresponding > entry in the active_on_lcore array is set or reset. > > Upto 8 cores share the same cache line for their > service active_on_lcore array entries since each entry is a uint8_t. > Some number of these entries also share the cache line with > the internal_flags member of struct rte_service_spec_impl, > hence this false sharing also makes the service_valid() check > expensive. > > Eliminate false sharing by moving the active_on_lcore array to > a per-core data structure. The array is now indexed by service id. Harry, any comments on this patch? Thanks. --=20 David Marchand