[dpdk-dev] [PATCH] checkpatch: suppress fallthrough warning

[dpdk-dev] [PATCH] checkpatch: suppress fallthrough warning

[Stephen Hemminger]

The DPDK does not have (or want to use) the same fallthrough
wrapper as the Linux kernel.  Therefore silence the warning.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 devtools/checkpatches.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 78a408ef9823..923ff6f7d9ee 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
 PREFER_KERNEL_TYPES,PREFER_FALLTHROUGH,BIT_MACRO,CONST_STRUCT,\
 SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\
 LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
-NEW_TYPEDEFS,COMPARISON_TO_NULL"
+NEW_TYPEDEFS,COMPARISON_TO_NULL,PREFER_FALLTHROUGH"
 options="$options $DPDK_CHECKPATCH_OPTIONS"
 
 print_usage () {
-- 
2.27.0

Re: [dpdk-dev] [PATCH] checkpatch: suppress fallthrough warning

[David Marchand]

On Fri, Sep 25, 2020 at 6:14 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The DPDK does not have (or want to use) the same fallthrough
> wrapper as the Linux kernel.  Therefore silence the warning.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  devtools/checkpatches.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index 78a408ef9823..923ff6f7d9ee 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
>  PREFER_KERNEL_TYPES,PREFER_FALLTHROUGH,BIT_MACRO,CONST_STRUCT,\
                       ^^
This token is already set here.
Is there an issue with this?


>  SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\
>  LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
> -NEW_TYPEDEFS,COMPARISON_TO_NULL"
> +NEW_TYPEDEFS,COMPARISON_TO_NULL,PREFER_FALLTHROUGH"
>  options="$options $DPDK_CHECKPATCH_OPTIONS"
>
>  print_usage () {
> --
> 2.27.0
>


-- 
David Marchand

Re: [dpdk-dev] [PATCH] checkpatch: suppress fallthrough warning

[Stephen Hemminger]

On Fri, 25 Sep 2020 18:41:40 +0200
David Marchand <david.marchand@redhat.com> wrote:

> On Fri, Sep 25, 2020 at 6:14 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > The DPDK does not have (or want to use) the same fallthrough
> > wrapper as the Linux kernel.  Therefore silence the warning.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Never mind; note to self look first...

Didn't see that it was already set. Maybe the issue is that the
scans from patchwork are still using older version of the DPDK script?

Did a dummy patch just now with main branch and dpdk-checkpatch is
correctly suppressing the warning. But recent patches submitted
to mailing list are getting checkpatch warnings.

Re: [dpdk-dev] [PATCH] checkpatch: suppress fallthrough warning

[David Marchand]

On Fri, Sep 25, 2020 at 7:13 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Fri, 25 Sep 2020 18:41:40 +0200
> David Marchand <david.marchand@redhat.com> wrote:
>
> > On Fri, Sep 25, 2020 at 6:14 PM Stephen Hemminger
> > <stephen@networkplumber.org> wrote:
> > >
> > > The DPDK does not have (or want to use) the same fallthrough
> > > wrapper as the Linux kernel.  Therefore silence the warning.
> > >
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Never mind; note to self look first...
>
> Didn't see that it was already set. Maybe the issue is that the
> scans from patchwork are still using older version of the DPDK script?

Ah yes.
I updated it on the server.


-- 
David Marchand