From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FB3BA0544; Mon, 10 Oct 2022 17:09:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D26D0427F6; Mon, 10 Oct 2022 17:09:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D8C894021E for ; Mon, 10 Oct 2022 17:09:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665414579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BrxVEY9N2rfUTb5A3bZobF8pEEJAmlTJpY1BU54rIi4=; b=CUUQIxk9Zvk3lxbQKChFQKkoxuLpyhNQdIBqr4dQe0rwtC1YbMKrMhd1I9SA+9cuIzFdL1 Pdt11Q3yXRpVfOJhB2Dh6E75k2laHMSxI+pZyXmH4jowY1WHyoU004SdZ4u/+7R7WWA9P3 sJZpogFYZlYXJ7LU9sd6Gft8v0a7SwM= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-208-VuW6c8kcPgKIaqyC7VDYtw-1; Mon, 10 Oct 2022 11:09:38 -0400 X-MC-Unique: VuW6c8kcPgKIaqyC7VDYtw-1 Received: by mail-pf1-f197.google.com with SMTP id 24-20020aa79118000000b00561ed88c3b9so5849928pfh.7 for ; Mon, 10 Oct 2022 08:09:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BrxVEY9N2rfUTb5A3bZobF8pEEJAmlTJpY1BU54rIi4=; b=G84OtQj2MKIlUxDDbrlEUUi6Af0iqKkCVwrRJECxakyE86J9mKwRVPAw0ABZy+2dwz XXODSAMUEB1E8/srGDI9H3jV2ZhvkPuuUaDZsrcJq88Jo5XLpGVwkJteZyAWuXK8mKdr ANTzW+TCWjn3/q37DGlYI9LbZMx8zK1mzXE5h7B0vI1muRm3XhGbCDMKQkim7f2wlPdD WkWUyaYdE6JmDunmH5FRQ7XnnV9WQZrTzR0/+RPq8W2CSt0LX7CzefbNuyNsE7yBQT1d HK0/KOxZPq+mO6NhGk5nT6+SPvAdhgeQaASSmNdKwXY42mb3vVsteNWY7xPHR9XQresR 3YOA== X-Gm-Message-State: ACrzQf2nuiVfiM38S36pDqlnagQpZ11iPlAPoIXoExrHAjUySYe94RPd BTFbCbzKJ20Ws1g0Bj1JzqNh/sRn/qkwCpM+iXpGFsEqhk488CjbgehP6iaq0/4fCCNE6emLvTR 9ZbZgfpV2GS8Tuo0R72w= X-Received: by 2002:a63:2307:0:b0:458:4d0b:a21f with SMTP id j7-20020a632307000000b004584d0ba21fmr16978751pgj.120.1665414577105; Mon, 10 Oct 2022 08:09:37 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5vm8OKsmEM//gsR6SkDxjt3X+8d8l2vgkHo7kZuPYkvoM6X5JfZKw8PNFrrPC5BiNqKVA+Kit2CXBPGV7x09c= X-Received: by 2002:a63:2307:0:b0:458:4d0b:a21f with SMTP id j7-20020a632307000000b004584d0ba21fmr16978728pgj.120.1665414576806; Mon, 10 Oct 2022 08:09:36 -0700 (PDT) MIME-Version: 1.0 References: <20221005143451.157613-1-bruce.richardson@intel.com> <20221010104448.350578-1-bruce.richardson@intel.com> In-Reply-To: <20221010104448.350578-1-bruce.richardson@intel.com> From: David Marchand Date: Mon, 10 Oct 2022 17:09:25 +0200 Message-ID: Subject: Re: [PATCH v3 1/3] kni: flag deprecated status at build time To: Bruce Richardson Cc: dev@dpdk.org, Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Oct 10, 2022 at 12:45 PM Bruce Richardson wrote: > > To ensure all users are aware of KNI's deprecated status at build time > we can take the following actions: > > 1. disable the library by default. It can be re-enabled by setting > disabled_libs to the empty string (or other string not including > 'kni') > > 2. add support for a list of deprecated libs to the lib/meson.build file > so the error message for KNI being disabled includes the fact that it > is a deprecated library. > > 3. for the dependent NIC driver, drivers/net/kni, modify the driver > build code to similarly flag the deprecation in the reason why > the driver is not being built.. > > NOTE: This is part of the deprecation process for KNI agreed by the DPDK > technical board.[1] > > [1] http://mails.dpdk.org/archives/dev/2022-June/243596.html > > Signed-off-by: Bruce Richardson > Signed-off-by: David Marchand > > --- > V3: Incorporate code from David M. to generalise the driver dependency > handling of deprecated libs. > V2: correct dpdk_conf lookup key to RTE_LIB_KNI Thomas had some last minute offlist comments that I handled (he was asking for introducing the deprecated library handling first, then marking kni as deprecated). I handled it and reworked the patches, the end-result is the same. Series applied, thanks Bruce! -- David Marchand