From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B20F41B8D; Tue, 31 Jan 2023 10:54:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 48BD640DFB; Tue, 31 Jan 2023 10:54:25 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6F37C4067B for ; Tue, 31 Jan 2023 10:54:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675158863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xbA0v6xKptMIdP+SHiI2Q8vSQ1eo17CXQ6BTO8C/DEk=; b=BuqSyYCUwS8D0ONPMR1wDJ62NAwUfjhdGXvDTD4LUbxL4lOL0fR965tJveHdvTxTF3yn9W Qh/LKDO2PNtnyn5PZ/4RTvhoFv+awJpFh6OI4dU2tCH/paEE6KG6J7mGYaxXlYLc9ZiBnS 2DObtY8oj9hRCfAJAMcLwcItBfOOG08= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-70-OH44RVPdPratFy3ND__moQ-1; Tue, 31 Jan 2023 04:54:21 -0500 X-MC-Unique: OH44RVPdPratFy3ND__moQ-1 Received: by mail-pj1-f70.google.com with SMTP id y11-20020a17090a86cb00b0022bec81bf5eso5979926pjv.4 for ; Tue, 31 Jan 2023 01:54:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xbA0v6xKptMIdP+SHiI2Q8vSQ1eo17CXQ6BTO8C/DEk=; b=m6RNVP9rD0vjGRmDYy71oBqMdkwqidUk0xzEV89zdqxujPQBRVybZ74CCKwgp/Y/fj D4Y9/2grdb3kb9mUL0nnp/YNsMmqAWHh/bnU3xQyHsN/2XSayG0zBQvRGzXZ/t6rOqCi /YLR1iY6C5UBXVult4nxF2ZnhW4JUnxf48ZQ0KGKxlfrKWJ4eTAT353bj5W6MUaCDpuA uWE8YF+IYI0pdcpDnh1qFn7T92upeaY1v2gnH+bAFIOc9jAeYlheJk6ct/ip9UvV0Du9 UA/KYgvMdbJNI/knTYASoTH95yaG81YDL9L5aUemxQboV4gknvH3v27nepGn4qhXUVIP UJMg== X-Gm-Message-State: AO0yUKU0vZvV1u3evOKSN4ZoXkWFGlAM+8+qdSz6xP0qejm+axy+K3lZ dJZmETNHZjoMYCwzDPpGWw0lnQ/RkPALMGAr21Z3HHPgKaHIRQvzoKmjCp2ouj5rRGJFqS9BU19 ua6R0Nl+15wfvgGXDLuc= X-Received: by 2002:a05:6a00:4297:b0:593:d21d:2ed5 with SMTP id bx23-20020a056a00429700b00593d21d2ed5mr957030pfb.2.1675158860807; Tue, 31 Jan 2023 01:54:20 -0800 (PST) X-Google-Smtp-Source: AK7set8IFTqI7s5vp52iCNSI1VVjWucXygYhKoMBtHoS2T5Z0VWKZ+To1tOexgkvbUkY3thlQMQIc+/hob/9KvDDaPw= X-Received: by 2002:a05:6a00:4297:b0:593:d21d:2ed5 with SMTP id bx23-20020a056a00429700b00593d21d2ed5mr957028pfb.2.1675158860518; Tue, 31 Jan 2023 01:54:20 -0800 (PST) MIME-Version: 1.0 References: <1670439617-9054-1-git-send-email-roretzla@linux.microsoft.com> <1674583941-16964-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1674583941-16964-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Tue, 31 Jan 2023 10:54:09 +0100 Message-ID: Subject: Re: [PATCH v10 0/4] add rte_thread_set_name API for rte_thread_t To: Tyler Retzlaff Cc: dev@dpdk.org, thomas@monjalon.net, jerinjacobk@gmail.com, mb@smartsharesystems.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 24, 2023 at 7:12 PM Tyler Retzlaff wrote: > > v10: > * change intended deprecation of rte_thread_setname > from 23.03 to 23.07 > > v9: > * fix typo in v8 deprecation notice picked up by ci > > v8: > * document that no implementation or internal implementation > failure is a noop for rte_thread_set_name > * update commit message to indicate windows now provides an > implementation for rte_thread_set_name > * remove '_' from thread_name in comment > * squish drivers/mlx5 patch into patch 1 as requested > * clarify rte_thread_setname anticipated deprecation and removal > releases in deprecation notice > * group deprecation notice with other eal deprecation notices > > v7: > * don't dereference thread_name after successful completion > of mbsrtowcs. (fixes NULL dereference on Windows). > > v6: > * clean up commit descriptions > * add patch to set worker thread name on windows > * remove __rte_deprecated from rte_thread_setname > > v5: > * rename rte_thread_getname -> thread_get_name > > v4: > * retain and move rte_thread_getname function to the > single site of use > > v3: > * fix coding style error > * move remove of rte_thread_getname to patch #2 > > v2: > * initial series provided get/set for lcore thread id, those > additions have been removed as per discussion. including > unit test > * add a single api rte_thread_set_name does not fail but emits > debug logging if the internal implementation is aware of > in-exact use of the name or failure to set the name > * adapt mlx5 driver to avoid use of deprecated API Series applied, thanks Tyler. -- David Marchand