From: David Marchand <david.marchand@redhat.com>
To: Stanislaw Kardach <kda@semihalf.com>
Cc: dev <dev@dpdk.org>, upstream@semihalf.com
Subject: Re: [PATCH 0/2] fix C++ include checks in cross-compilation
Date: Thu, 23 Jun 2022 10:04:46 +0200 [thread overview]
Message-ID: <CAJFAV8yKZTmjzuN6CASCqfFsV97MKO2hAZhrP0yBhjo_+9F7xA@mail.gmail.com> (raw)
In-Reply-To: <20220621122824.187905-1-kda@semihalf.com>
On Tue, Jun 21, 2022 at 2:28 PM Stanislaw Kardach <kda@semihalf.com> wrote:
>
> Meson detects the C++ cross-compiler during configuration and based on
> that reports whether C++ language is available or not.
> The C++ include check target (buildtools/chkincs/chkincs-cpp) is only
> built when C++ language is available.
>
> There are 2 issues that currently prevent those checks to be run in
> cross-compiled environments:
>
> * PowerPC and ARM cross-files define cpp instead of g++ as C++ compiler.
> That's wrong because cpp is a C Preprocessor binary.
> * The CI workflow file does not install a g++ cross-compiler.
>
> This patchset fixes both issues.
>
> Stanislaw Kardach (2):
> config: Use G++ as C++ compiler
> ci: use crossbuild-essential packages
Series applied, thanks Stanislaw.
--
David Marchand
prev parent reply other threads:[~2022-06-23 8:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 12:28 Stanislaw Kardach
2022-06-21 12:28 ` [PATCH 1/2] config: Use G++ as C++ compiler Stanislaw Kardach
2022-06-21 14:25 ` Bruce Richardson
2022-06-21 19:53 ` Tyler Retzlaff
2022-06-22 5:07 ` Stanisław Kardach
2022-06-22 16:05 ` Tyler Retzlaff
2022-06-22 16:24 ` Morten Brørup
2022-06-21 12:28 ` [PATCH 2/2] ci: use crossbuild-essential packages Stanislaw Kardach
2022-06-23 8:04 ` David Marchand
2022-06-23 8:04 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yKZTmjzuN6CASCqfFsV97MKO2hAZhrP0yBhjo_+9F7xA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=kda@semihalf.com \
--cc=upstream@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).