From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86192A058A; Fri, 17 Apr 2020 15:26:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2F7FE1DC85; Fri, 17 Apr 2020 15:26:11 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 082581D9B4 for <dev@dpdk.org>; Fri, 17 Apr 2020 15:26:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587129968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iot2imq8YUk/cSGItpyknMunJ4Ug/f8OHhfIkIt66U0=; b=CxJyD8IHODnTdTuBJybRHApGmLBsf64SePEvs3bi8O1RAkb+jmDmRwHfQTfqvYfAJBp3jx t2uPUMkXE+twBN38X7Og0BL6+OfgzjnJgfxvvYLHNka6JiM8MNZQ4BmrO7DXXQBjLjO2F3 f+9cs6WWKMKmPR7c21ohcBPPyX6/3Ls= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-412-odmkHqReMCywlfpTNPAH4A-1; Fri, 17 Apr 2020 09:26:05 -0400 X-MC-Unique: odmkHqReMCywlfpTNPAH4A-1 Received: by mail-vk1-f199.google.com with SMTP id c139so911207vke.5 for <dev@dpdk.org>; Fri, 17 Apr 2020 06:26:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=iot2imq8YUk/cSGItpyknMunJ4Ug/f8OHhfIkIt66U0=; b=VvGvmUNF0/ObriFqvs0UhSIQndeCjXP18wa/vZ90az+/Xz7HiurJbPb6bClTZuIGh8 bH2CoYkX4ip4PPm9i7M5fYVyKkjYUVHoLQTaf4G8ZeY7SNrV7UBd0Q0W16RQAa04i+vj RWzp5k2UwjqLKo9JG7T/13eJGbHevrRyUa34UYAnDIttQh1gdyIdDp8w/m8FpVrNJs9h 3ewXM63ICRQNzLGKE3ytVQqtGDQGPCgZmVgRn/Edy+G64youmkCs1cqPgyAEgD6qZYyw didtnyaVxsa1RF+x7SSRt00kLFerRVBjMXzAJwytPc124AZpycTiKfOHE+cfyV4iWWFB YLqA== X-Gm-Message-State: AGi0PuZ6q63Dk1uTE3zzJucQYuct7Xk3eqT/hjyuHf0cxovY3Vjr6++s yrb1NnztALd2krucPfcJ2cOPQbB2/btcCawjAK8SMiJ9XwjSXZhYHqgG6mXaYEKIN3aFabCiV88 2vsC30F2y2u9XxZNL/Gs= X-Received: by 2002:a1f:3649:: with SMTP id d70mr2327764vka.12.1587129964663; Fri, 17 Apr 2020 06:26:04 -0700 (PDT) X-Google-Smtp-Source: APiQypIVsb4NA0p3CEKWmcJu52QOgNGKMaQhgIUcJsFpyBrlFUHFQHijsnkv6sxsS2TY8ErXDgHoJh52IIM28Dpn0wA= X-Received: by 2002:a1f:3649:: with SMTP id d70mr2327745vka.12.1587129964441; Fri, 17 Apr 2020 06:26:04 -0700 (PDT) MIME-Version: 1.0 References: <20191216075501.15669-1-skori@marvell.com> <20200407092856.554-1-skori@marvell.com> <CAJFAV8wLnUAeaied=X2qjHwQR6BN5dnwL5ifj1momGSLXpf2sA@mail.gmail.com> <BY5PR18MB310517F3C49473962D6067C3B4D90@BY5PR18MB3105.namprd18.prod.outlook.com> In-Reply-To: <BY5PR18MB310517F3C49473962D6067C3B4D90@BY5PR18MB3105.namprd18.prod.outlook.com> From: David Marchand <david.marchand@redhat.com> Date: Fri, 17 Apr 2020 15:25:52 +0200 Message-ID: <CAJFAV8yKiOsvV2xQnhuUuXGGpiEsW0xtOB=7v-ehGEG5y1Mi5w@mail.gmail.com> To: Sunil Kumar Kori <skori@marvell.com> Cc: Stephen Hemminger <stephen@networkplumber.org>, Jerin Jacob Kollanukkaran <jerinj@marvell.com>, dev <dev@dpdk.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/1] bus/pci: optimise scanning with whitelist/blacklist X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Fri, Apr 17, 2020 at 1:16 PM Sunil Kumar Kori <skori@marvell.com> wrote: > >Now, it seems you ignored what I replied without any explanation. > >So tell me, what was wrong with > >https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__github.com_david- > >2Dmarchand_dpdk_commit_e7860231ecdce91f9f70027d4090a7057b8fd5f7& > >d=3DDwIFaQ&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DdXeXaAMkP5COgn1zxHMyaF1_d > >9IIuq6vHQO6NrIPjaE&m=3D3nE0hIIwz2cXBpYrewLujeRWz5WPE7LB9j_HvOtBd68 > >&s=3DOjPCDnof_PNgATyzPIbjG8EtSYa5fE4EwbLD0oaIw5w&e=3D > No, Neither I have ignored your code changes nor denied. Both submitted p= atches uses similar approaches having one difference only that is you modif= ied existing functions and I have written the new without touching the exis= ting one. I have already explained in v1 that why I have not taken that pa= th what you have implemented. > Also I thought, its not good to change pci_ignore_device and pci_devargs_= lookup because in future if more parameters (part of rte_pci_device structu= re) are considered to ignore a device then again we have to change this fun= ction to support it. > It may be a rare case but it was one thought process. Your current patch is a no go anyway. The __rte_experimental tagging makes no sense. --=20 David Marchand