From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C801A0C41; Wed, 17 Nov 2021 10:20:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21D094068C; Wed, 17 Nov 2021 10:20:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 92E2C40040 for ; Wed, 17 Nov 2021 10:20:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637140832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DE10liJYzpo2k268lmeLpitB9jY95KS3hIy8gOz8dqE=; b=cDkL+DvUNSKksmRTorw77bRHU1DZfducU9Cm+f1aE1fekVpeWt6cgq3EORbBJEBYwe3WBR HWPdnoKMOh7Ya3Fi4TjfHkpDDeFBuKWJwGxMlrLlDVp8esp4TKhnEgNuurHxj+YdMkS7gv m/bG28myMRo60C2MzdXiCM3IkWHcGrI= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-388-cax31Z5_OvqL5QDCPOHx8w-1; Wed, 17 Nov 2021 04:20:31 -0500 X-MC-Unique: cax31Z5_OvqL5QDCPOHx8w-1 Received: by mail-lj1-f199.google.com with SMTP id p1-20020a2e7401000000b00218d0d11e91so393585ljc.15 for ; Wed, 17 Nov 2021 01:20:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DE10liJYzpo2k268lmeLpitB9jY95KS3hIy8gOz8dqE=; b=YG76xmSjHSFDxbbrgDDNeum9/3EDK+Ykfq6QXusR17SFPvDhU5CCdbZOD6x3CCaPll KVbWbYtUWLWEZ3jyVRpsovqdg/qiqokuRsmzMR0/3OBY4diVKX7CuP4pqxOC8e03UtCC 7uZU3ZPsj+mJ0n7QyG9kl5KEhZF0DgOZMbIOv3QEqK6ikfQe5JchM+Fmmon51MRdAZR6 FaTIC47giDJ6sV2PUWcBzisyiyddyOU+nrbF6ImiJ6rZi6Ownn7uph1QUIfFhlz50YwJ 6edEZviNoxnigW3cP3xt3soViBHH2QRHkQyj3jCCAaKVggzSNLlzSzYOfEdq4cMAWn0L N8kA== X-Gm-Message-State: AOAM530fpDofMmyyO2n1gj8aEwsutu/1QmTVs34olsFTbo3jDRp+EXC3 UndjXe8aC3HEeBQRVOhME2MqA/H5uq5nZBBgMgoI7VKD6qC2r4OAbjEKsjSikxHnbRsah25A5E2 ahrA/kzgT0A795DEdy+k= X-Received: by 2002:a2e:83c6:: with SMTP id s6mr6409579ljh.477.1637140830237; Wed, 17 Nov 2021 01:20:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJxudDbOzHFACpnfZF4wDyUtIw0JGUEWtSfHe18JI7wc4z+ouw6epTVzWOB9ZusNMLJwoKmMXPzzIniRm9/6VHs= X-Received: by 2002:a2e:83c6:: with SMTP id s6mr6409552ljh.477.1637140830052; Wed, 17 Nov 2021 01:20:30 -0800 (PST) MIME-Version: 1.0 References: <20211109172456.147140-1-vladimir.medvedkin@intel.com> <20211116143330.305220-1-vladimir.medvedkin@intel.com> In-Reply-To: <20211116143330.305220-1-vladimir.medvedkin@intel.com> From: David Marchand Date: Wed, 17 Nov 2021 10:20:18 +0100 Message-ID: Subject: Re: [PATCH v3] hash: fix thash gfni implementation To: Vladimir Medvedkin Cc: dev , Thomas Monjalon , "Ananyev, Konstantin" , Lance Richardson , Yipeng Wang , Sameh Gobriel , Bruce Richardson , "Ji, Kai" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 16, 2021 at 3:33 PM Vladimir Medvedkin wrote: > > 1. This patch replaces _mm512_set_epi8 with _mm512_set_epi32 > due to the lack of support by some compilers. > 2. This patch checks if AVX512F is supported along with GFNI. > This is done if the code is built on a platform that supports GFNI, > but does not support AVX512. > 3. Also this patch fixes compilation problems on 32bit arch due to > lack of support for _mm_extract_epi64() by implementing XOR folding > with _mm_extract_epi32() on 32-bit arch. > > Fixes: 4fd8c4cb0de1 ("hash: add new Toeplitz hash implementation") > > Signed-off-by: Vladimir Medvedkin > Acked-by: Lance Richardson > Acked-by: Ji Kai Afaics in git history, that's "Kai Ji". I updated indentation and applied, thanks. -- David Marchand