From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7581CA04DB; Fri, 16 Oct 2020 14:19:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E72CF1ED98; Fri, 16 Oct 2020 14:19:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id ECB2F1ED80 for ; Fri, 16 Oct 2020 14:19:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602850757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=78JU09VqBxvut2rhdRspsvXYi/9LPrTr1EHKIfHWZSI=; b=gC7WbA2JmD46nXxc+cx2Dev5BFqVAp4rPXsItrUdjl98Ns954WETjEJeqiMJ0nOTUseRJg ig//GmuxtyPzv+JDZWMMy/sfwi5I2wPS6HG62fZOI3NnXfZanO6GfRxeo6F0Sj1E4cxrdJ 9sD4IjPAVs596JisEMC08MGqmiSnDFk= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-62-XE9lanOoPWG-o6xd-HNX9g-1; Fri, 16 Oct 2020 08:19:15 -0400 X-MC-Unique: XE9lanOoPWG-o6xd-HNX9g-1 Received: by mail-vk1-f198.google.com with SMTP id j134so869777vke.1 for ; Fri, 16 Oct 2020 05:19:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=78JU09VqBxvut2rhdRspsvXYi/9LPrTr1EHKIfHWZSI=; b=oR0SBAfvU1X/7Z8Cv70B1Uv434cVfdS3ovdQOMSweFzyJZ4DSQlbQQtUYO8hrVrA8g vFW3L8m2vTP7Jg14mPC7K2EOYDzq9SRLnAbuqEl0JM/iXivkIAcMOPzEjqg2o2HmzV8g 0wvjxnbIg3NmgKcT5m10BZIuN+pP5Jhu3YE+ezKyFV3Kw0U8xxEO88z3zC6Jw/l9dJE/ ovYXYNPD+LS83OVKEYeyLGxQsITF59OOM00VGPpx9EVXNvJPiO3HfRulvhKfxgzzMe11 YKLl5+A//LlKP2fDvm8tZOeDXcZiOwTtl4rwjd45o9iFKtdwprGF+JE2r0HFgsu0EgyC lsKA== X-Gm-Message-State: AOAM532Ha++MHXeskxSMylxCTSzlmnspBkPMVNPzeAl0DlrPiTXX+XYq BAf2NrT37gbto1yK3mcul+UiQ5RKHFaDTOM/lGR3vmyIxD22gCXgEplXhjgbqaW2n3LIeI37tld RTNjW34u8GdqjSG5YTEI= X-Received: by 2002:a05:6102:3121:: with SMTP id f1mr1585834vsh.10.1602850755343; Fri, 16 Oct 2020 05:19:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvyf38UMT2iKKt2ZHv+RxWHnJcVJNlGSbSqs4NxSMKGycqL/D+oh5PuWel8ThUZu1ntF1bmqldIbqq/bRc/bg= X-Received: by 2002:a05:6102:3121:: with SMTP id f1mr1585827vsh.10.1602850755165; Fri, 16 Oct 2020 05:19:15 -0700 (PDT) MIME-Version: 1.0 References: <20200915170456.7204-1-konstantin.ananyev@intel.com> <20201006171618.19374-1-konstantin.ananyev@intel.com> <20201006171618.19374-2-konstantin.ananyev@intel.com> In-Reply-To: From: David Marchand Date: Fri, 16 Oct 2020 14:19:03 +0200 Message-ID: To: "Ananyev, Konstantin" Cc: dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 1/3] examples/l3fwd-acl: add source and destination MAC update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 15, 2020 at 3:06 PM Ananyev, Konstantin wrote: > > On Tue, Oct 6, 2020 at 7:17 PM Konstantin Ananyev > > wrote: > > > > > > Introduces two changes into l3fwd-acl behaviour to make > > > it behave in the same way as l3fwd: > > > - Add a command-line parameter to allow the user to specify the > > > destination mac address for each ethernet port used. > > > - While forwarding the packet update source and destination mac > > > addresses. > > > > This new parameter is optional, but I see no default for l2 > > destination in the patch. > > How does it work when you won't set this option? > > Ah yes, forgot to init l2 dst array with some default values. > Will fix and re-spin then. Ok, waiting for it, and squash patch 3 as suggested. Thanks. -- David Marchand