From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B8DFA04B5; Mon, 26 Oct 2020 09:09:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6431529C6; Mon, 26 Oct 2020 09:09:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 799951D9E for ; Mon, 26 Oct 2020 09:09:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603699784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XCbVjgLamcRemIApQDuD7kwrc7DISOh9kzQaB7fs1hQ=; b=USqT9DMkMv0ZrlKBTfURkoaTLJauZcFP3nTHsUYMPd2iBHNIUTfcaC3enGLWOhcGm7eDR7 FEht7eKv9Ytmv/Erm+gTrJYE9k3ZmmFYUVn61q62PGhmS5Q0G6E2k6Obd1y01J2LeaJ6eS /c0oIsmqjCOHF7Yb//RE8Hr/Hs9eNLE= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-238-A2PdHw3WPE-a52oKgUdKpA-1; Mon, 26 Oct 2020 04:09:42 -0400 X-MC-Unique: A2PdHw3WPE-a52oKgUdKpA-1 Received: by mail-vs1-f72.google.com with SMTP id u197so1367078vsc.8 for ; Mon, 26 Oct 2020 01:09:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XCbVjgLamcRemIApQDuD7kwrc7DISOh9kzQaB7fs1hQ=; b=buCIqKapLUUVkdPrzaeu3+Mi/pZcQXVdwNtOuc8pjZ0VYHomuBtV3mYvUGEmo+FVSj KByUaPrFEYb+9Foy1BnMqKT/D9/u7bVUJozlGbC2bsxSkz4+6mRpqBjQ9CtGLeOIAMcz wJQWwfiaIydmbt8TyWe9Sm4knHNlI8s9tA6hqharPTJxRynlhnSzNVmjpQX8GgU+hvOd nrrMtQTScOzLmz3yJ3hmA5++JuaNjBpDYN54pm5HqdjlYxDBoAEsBY1M1h+wC2McwsO6 W8NkCx/NgdTbxbEue8dnu64GNqAxzZwbzWUs62NesKY4JOkBWUtZ2wDEZkB2W0HKiIy5 2aqw== X-Gm-Message-State: AOAM532dMTrMXIg4sPcFH5icx+JyeqR1wUbU75dmg0CPzpa0Oez2geM3 gj1mFtBPxMiOC1ePHw9+VT9g69jfiH7ExwVp48mp17VS9nEAVjUDFmyyFLmnHOStXZ1LARK0U2F mjMmP9JlMaYjvTGvR/ZY= X-Received: by 2002:a67:f954:: with SMTP id u20mr19205845vsq.5.1603699782343; Mon, 26 Oct 2020 01:09:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywybmtKI1HQltq9qoX3PNvTm7Sk37UfNm4/mPEG10hTyNC3tjTGolT2bG4NjyHxGDI9/OLnaOEGif64kHnVAA= X-Received: by 2002:a67:f954:: with SMTP id u20mr19205824vsq.5.1603699782160; Mon, 26 Oct 2020 01:09:42 -0700 (PDT) MIME-Version: 1.0 References: <20200910065504.104217-1-leyi.rong@intel.com> <20201023041407.20442-1-leyi.rong@intel.com> <20201023041407.20442-2-leyi.rong@intel.com> In-Reply-To: From: David Marchand Date: Mon, 26 Oct 2020 09:09:31 +0100 Message-ID: To: "Rong, Leyi" , "Richardson, Bruce" Cc: "Zhang, Qi Z" , "Yigit, Ferruh" , "Lu, Wenzhuo" , dev , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 1/3] net/ice: add AVX512 vector path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 26, 2020 at 8:13 AM Rong, Leyi wrote: > Would prefer using __AVX512F__ instead of RTE_MACHINE_CPUFLAG_AVX512F here rather than remove the RTE_MACHINE_CPUFLAG_ macro directly to check the CPU capability. > So the judgment statement will be > if cc.get_define('__AVX512F__', args: machine_args) != '' or (not machine_args.contains('-mno-avx512f') and cc.has_argument('-mavx512f')) > > what do you think? No opinion as I have yet to understand the subtleties to control enablement of avx stuff. Bruce? -- David Marchand