From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Srikanth Yalavarthi <syalavarthi@marvell.com>
Subject: Re: [PATCH] mldev: disable build on Windows
Date: Fri, 10 Mar 2023 10:19:51 +0100 [thread overview]
Message-ID: <CAJFAV8yMEWCZZJtd1ONpMOgAO-FxvZK3kRxLUWBwi3c9HmCxjw@mail.gmail.com> (raw)
In-Reply-To: <3186427.AJdgDx1Vlc@thomas>
On Fri, Mar 10, 2023 at 10:18 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The build breaks because of the weak symbols, so we can define this cause:
>
> Fixes: 9637de38a2e3 ("mldev: add scalar type conversion")
I was not 100% sure but it seems the best one yes.
>
> 10/03/2023 10:07, David Marchand:
> > --- a/lib/mldev/meson.build
> > +++ b/lib/mldev/meson.build
> > +if is_windows
> > + subdir_done()
> > +endif
>
> More complete handling:
>
> if is_windows
> build = false
> reason = 'not supported on Windows'
> subdir_done()
> endif
Indeed... v2 in progress.
--
David Marchand
next prev parent reply other threads:[~2023-03-10 9:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 9:07 David Marchand
2023-03-10 9:18 ` Thomas Monjalon
2023-03-10 9:19 ` David Marchand [this message]
2023-03-10 9:23 ` [PATCH v2] " David Marchand
2023-03-10 9:32 ` Thomas Monjalon
2023-03-10 20:06 ` [PATCH] " Tyler Retzlaff
2023-03-10 22:54 ` Stephen Hemminger
2023-03-11 8:11 ` Thomas Monjalon
2023-03-11 14:53 ` [EXT] " Srikanth Yalavarthi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yMEWCZZJtd1ONpMOgAO-FxvZK3kRxLUWBwi3c9HmCxjw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=syalavarthi@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).