From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AA5841E3A; Fri, 10 Mar 2023 10:20:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2BA6D40ED9; Fri, 10 Mar 2023 10:20:07 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 598B440685 for ; Fri, 10 Mar 2023 10:20:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678440004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zgI1eLIPEmRNUfadRjJ1f0oyXTk4o13F83tKDzsss4U=; b=AVkJovJdQ3O1C48Cien8vwtHTo/vWM0EfROTRr3khwNdW9L/AJkj4uzQs7MVTubyc3/eHA E2apfJYMtvgJ2SmQHOm3jG8MEJ/hx229jToY8Vdy8L2QZSG7AjCyM3XNjus5GwM0R2ZiWW I7V3q1wsksmGMe6wzzxUwvjIsykmgoY= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-173-IgVTzVfdM6OCisSdgea62g-1; Fri, 10 Mar 2023 04:20:03 -0500 X-MC-Unique: IgVTzVfdM6OCisSdgea62g-1 Received: by mail-pl1-f200.google.com with SMTP id bh9-20020a170902a98900b0019e506b80d0so2553853plb.13 for ; Fri, 10 Mar 2023 01:20:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678440002; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zgI1eLIPEmRNUfadRjJ1f0oyXTk4o13F83tKDzsss4U=; b=IUIJovPwhiXcQ+4P2l57sKMwY8CpjTp9kzV0g5fQsSeil5JXlFG2et5mh2STHqFKPl /RLc+tM/NoxGgoP13n7b+Q7KOBiI1ixSCEQo6rdi0s3hOECkDZlxaSpWhOqQHfaHei12 FzqHmkNXbsunmXowrqqh30Ldlc3liqcq4WMHiWlApgotAOzXzV0/rsylyzxT1Yr5FqbM LD19gzIA5dwcKtQSyLv+X/DzPBc83gxGFUlkUmdsY4JuJy45UTvGbQM1kKuwHC91FJ0X bh+XDM6EwSsza1afVMXsMDHYpitNn+0PzK0vZPq5tieHLGm5SJkn94fq8MiB8hG/vZsr YSGQ== X-Gm-Message-State: AO0yUKXtD7jscy/7M5MMOyb5qfTpPXm4u3ztzoCGhoerDXtZ1ej2j27r gIVvO1hR0QnYv2LJQbX3ygwHD3Fg4dXsOrCrB3iuLqhS4bTWg1xF16d+a2fMMJloTX0hHDr95n9 TQQWHMzehnL4w7pRpFPY= X-Received: by 2002:a17:903:428b:b0:198:dd3d:59 with SMTP id ju11-20020a170903428b00b00198dd3d0059mr9510393plb.13.1678440002556; Fri, 10 Mar 2023 01:20:02 -0800 (PST) X-Google-Smtp-Source: AK7set/lLP7qj7R81Kpl9SmBB0TN7OCDCoZYhguIHmq+7vqzBsm9t/mTxEOdWhy1k79EB/x8mR+/N3zo4fTUDkXk0i4= X-Received: by 2002:a17:903:428b:b0:198:dd3d:59 with SMTP id ju11-20020a170903428b00b00198dd3d0059mr9510385plb.13.1678440002274; Fri, 10 Mar 2023 01:20:02 -0800 (PST) MIME-Version: 1.0 References: <20230310090717.1470032-1-david.marchand@redhat.com> <3186427.AJdgDx1Vlc@thomas> In-Reply-To: <3186427.AJdgDx1Vlc@thomas> From: David Marchand Date: Fri, 10 Mar 2023 10:19:51 +0100 Message-ID: Subject: Re: [PATCH] mldev: disable build on Windows To: Thomas Monjalon Cc: dev@dpdk.org, Srikanth Yalavarthi X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Mar 10, 2023 at 10:18=E2=80=AFAM Thomas Monjalon wrote: > > The build breaks because of the weak symbols, so we can define this cause= : > > Fixes: 9637de38a2e3 ("mldev: add scalar type conversion") I was not 100% sure but it seems the best one yes. > > 10/03/2023 10:07, David Marchand: > > --- a/lib/mldev/meson.build > > +++ b/lib/mldev/meson.build > > +if is_windows > > + subdir_done() > > +endif > > More complete handling: > > if is_windows > build =3D false > reason =3D 'not supported on Windows' > subdir_done() > endif Indeed... v2 in progress. --=20 David Marchand