From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BED4A04AF; Mon, 28 Sep 2020 10:59:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E82031D687; Mon, 28 Sep 2020 10:59:28 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id C890D1B671 for ; Mon, 28 Sep 2020 10:59:22 +0200 (CEST) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601283561; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AIjWvMVslW53umF8b6UY5DZg74KJMy7XukmDb+xNO6w=; b=QXedl9ibjIg26TFQCGkDrxj3Umdz/MLp2qbgq7S4jmZJjSM+s5ZrUKFj1jU+CFlT85vVye 12dLxwQIHgKIHUemnFdxy4x913ZRen5FtXAKhBIAkKa/xTPrpn9mQkhullkHWu4lxjyFO2 ARQ/dW/TCXm7d9/vvTq5rtB4pVpO/bA= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-43-u4UN8W-ePv2dnyyxE4xZmg-1; Mon, 28 Sep 2020 04:59:19 -0400 X-MC-Unique: u4UN8W-ePv2dnyyxE4xZmg-1 Received: by mail-vs1-f70.google.com with SMTP id 125so79224vst.23 for ; Mon, 28 Sep 2020 01:59:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AIjWvMVslW53umF8b6UY5DZg74KJMy7XukmDb+xNO6w=; b=DpiPcyTH36X9PBypTrva9MOyCbjiKIeCh9HHgNB4tUg/zlRP8bOX0gVivjkEToyKar yNdRCj84NJtUJd4PH4yoNYi3S4dgl7Q5l2aCSbqY1+g7MhyB6HrPYJ6w9lY9bvcFQuAP Dt2aQ11BIi0qXMEVDE6JalIa+igNGy4uHzYSVqfP2bmlNFEhCcDTBfH5EgXFzXeTC7B5 hgrieRORfCQeaCHj6DgGZtZbG0g07MuRLm0grqiXjcyVZGyVo0EAgSCb/D00CCRsMWMh L0qq5DZJ5XtifSxWH9hYwp2DvM/+og0ARdHVS5Ly28TdvonWIMk+s8a4EwB6kzLI46WB XzEg== X-Gm-Message-State: AOAM530twK4V+nrMlrXxFLuVt3bubaAhh+mYCJWSqiahI/hjBnE6XkWK Dg0K2KRE8gOLwjGrY+E/7Cp/WQO4rnZ9OPd2FZLe/rcBT3NRVq3XUMbdTyCXPgc8PM+yweXtIaY kFLvhjR/JwK/MuEglo6Q= X-Received: by 2002:ab0:7313:: with SMTP id v19mr67661uao.87.1601283558852; Mon, 28 Sep 2020 01:59:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvZUOjILUBMHDrfDUESnaffwbEYeUyvNN2KMSAxNskdYwsFBexedEmAZqG9tAjNBQOJZ7YFYw3ihLGCaoLrrw= X-Received: by 2002:ab0:7313:: with SMTP id v19mr67648uao.87.1601283558545; Mon, 28 Sep 2020 01:59:18 -0700 (PDT) MIME-Version: 1.0 References: <20200925115508.4179-1-manishc@marvell.com> <20200925115508.4179-2-manishc@marvell.com> In-Reply-To: From: David Marchand Date: Mon, 28 Sep 2020 10:59:07 +0200 Message-ID: To: Jerin Jacob , Ferruh Yigit Cc: Manish Chopra , Gaetan Rivet , dpdk-dev , Igor Russkikh , Rasesh Mody , GR-Everest-DPDK-Dev , Rosen Xu , Tianfei zhang , Heinrich Kuhn , Qiming Yang , Qi Zhang , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v6 1/6] drivers: add generic API to find PCI extended cap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Sep 27, 2020 at 2:21 PM Jerin Jacob wrote: > > On Fri, Sep 25, 2020 at 5:26 PM Manish Chopra wrote= : > > > > By adding generic API, this patch removes individual > > functions/defines implemented by drivers to find extended > > PCI capabilities. > > > > Signed-off-by: Manish Chopra > > Signed-off-by: Igor Russkikh > > Reviewed-by: Gaetan Rivet > > Reviewed-by: Jerin Jacob > > @Thomas Monjalon @David Marchand @Ferruh Yigit > > Othe patches in the qede series is depending on this patch, Let me > know, how we are planning to pull this patch? Is through main or > dpdk-next-net or dpdk-next-net-mrvl? Just two small comments, that can be fixed by whoever applies it. - The title does not reflect that we are adding an API to the pci bus. My suggestion is: "bus/pci: query PCI extended capabilities" - There is an unneeded empty line added to lib/librte_pci/rte_pci.h: diff --git a/lib/librte_pci/rte_pci.h b/lib/librte_pci/rte_pci.h index 1d89651ec8..f89c7dbbea 100644 --- a/lib/librte_pci/rte_pci.h +++ b/lib/librte_pci/rte_pci.h @@ -22,7 +22,6 @@ extern "C" { #include #include - /* * Conventional PCI and PCI-X Mode 1 devices have 256 bytes of * configuration space. PCI-X Mode 2 and PCIe devices have 4096 bytes of The patch is reviewed by Ga=C3=ABtan. Either through next-net or next-net-mrvl is fine to me. I'll leave the decision to Ferruh. --=20 David Marchand