From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2445AA04FF; Fri, 29 Apr 2022 15:29:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B8AB6415D7; Fri, 29 Apr 2022 15:29:44 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 81EB3410E3 for ; Fri, 29 Apr 2022 15:29:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651238982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G7Qh946068VNf8E9wQsR8yAD/SO8N5zee0xzck4HEtQ=; b=gA2oIeQZ5jMtXN5cj1Yl/IIEROsNgh0q9ST1hAqrmm1/FdccmIAI5h2kQCub8ST+YRd2FP 5AMfDkg2rwyb5Nh/W+yOZUqvXuRHN8n9AUI63kRS7qFjhWpN04ofTN8Ug02cBe0FFMt89N XvTlqmo0ZQqZCa/koAVZaU6uTMfw/9I= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-611-deldWrKNO--qid7EPV7xEg-1; Fri, 29 Apr 2022 09:29:41 -0400 X-MC-Unique: deldWrKNO--qid7EPV7xEg-1 Received: by mail-lj1-f200.google.com with SMTP id l16-20020a2e5710000000b0024f0c34eff1so2647265ljb.10 for ; Fri, 29 Apr 2022 06:29:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G7Qh946068VNf8E9wQsR8yAD/SO8N5zee0xzck4HEtQ=; b=sha7/40xyPmi0OcQx5mA1fxTuHdAW7Hu4e8V9Ke9JotNHtwxXszwHFmTP3HyemUC7s 65BCAixgV9x5xvm6OMCMiSPDlC2db48vYZk+b64akTdVLPndU/L9x8iATrapwi9E0SB4 L6qgqhX31qjfaCzVSbZ0Yj/5Sh2AFP4yPL9rrYhS0JMPsb5EnL5NRjuYoNBZQqyq8AVG UE2VM6xUmrNra9fNHFuBwByEUdYH8QLHu63tsLWT7WDQjYJrmE8O7C1CzF0m9EYzTxmS CJOznzVSML73QQGvfVYcncwyzWhAMLKh6fjJTYZ2ybgC2BulMQa9QPD+ItVYkjshOGso pFrg== X-Gm-Message-State: AOAM531ONItGgdWZb8Dgfhl6mOQANMo2RFxZZjx568uu0OMNRCBL5lPK 37pN1sIzzt8qUN15xkAWzQve0cn10UJz5jlOEsoZ15LvEEklXp/OGboOkuEvf9sjU54W1bXt1Pm UwSZKUsaYOQLWModJB1c= X-Received: by 2002:a05:651c:1781:b0:247:daa7:4358 with SMTP id bn1-20020a05651c178100b00247daa74358mr24453260ljb.477.1651238979832; Fri, 29 Apr 2022 06:29:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz0L5vfa/raPmk2RDrb9oTRV/4FzA9wQo6rO6BUl1LXouzNJaqqLj3B9XqcyJ74YC31j+ZNvJNt71RaLgY9b/E= X-Received: by 2002:a05:651c:1781:b0:247:daa7:4358 with SMTP id bn1-20020a05651c178100b00247daa74358mr24453243ljb.477.1651238979634; Fri, 29 Apr 2022 06:29:39 -0700 (PDT) MIME-Version: 1.0 References: <20220427133519.17837-1-pbhagavatula@marvell.com> <20220427152232.19223-1-pbhagavatula@marvell.com> In-Reply-To: <20220427152232.19223-1-pbhagavatula@marvell.com> From: David Marchand Date: Fri, 29 Apr 2022 15:29:28 +0200 Message-ID: Subject: Re: [PATCH v7 1/2] hash: split x86 and SW hash CRC intrinsics To: Pavan Nikhilesh Cc: "Ruifeng Wang (Arm Technology China)" , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , Jerin Jacob Kollanukkaran , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Apr 27, 2022 at 5:22 PM Pavan Nikhilesh wrote: > > Split x86 and SW hash crc intrinsics into a separate files. > > Signed-off-by: Pavan Nikhilesh You still need to keep those headers public. Otherwise, this breaks compilation for external applications relying on rte_hash_crc.h. Example: $ ./devtools/test-meson-builds.sh [snip] ## Building l3fwd In file included from l3fwd_em.c:37: /home/dmarchan/builds/main/build-x86-generic/install/usr/local/include/rte_hash_crc.h:24:10: fatal error: hash_crc_sw.h: No such file or directory 24 | #include | ^~~~~~~~~~~~~~~ compilation terminated. gmake: *** [Makefile:41: build/l3fwd-shared] Error 1 -- David Marchand