From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0A83A0543; Tue, 21 Jun 2022 11:08:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A582840A87; Tue, 21 Jun 2022 11:08:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E8BF140A87 for ; Tue, 21 Jun 2022 11:08:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655802492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RkH/f/AtK3XJLbZapTZvOZQdD3nbse4a/iN9coCgzmw=; b=I13kfCy47pCs+TtO/7dMc0s9DVpiqDF6f1Pr8bFfQcJBUdEg/HNDv69e/ihjR+WJnAPFlu oxsklINDSTGIiaoFfeD3OgK+NGyO2gEPEUWphaE/E68hqr5PwcYbULF/hiUC5sCVGnSnL3 XvXmFnrBFh5Y01U8f1skN2+JJM5sSNs= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-362-d4Nsq_bQOtCJP9TlErIg0w-1; Tue, 21 Jun 2022 05:08:10 -0400 X-MC-Unique: d4Nsq_bQOtCJP9TlErIg0w-1 Received: by mail-lj1-f197.google.com with SMTP id k12-20020a05651c10ac00b0025a73553415so606104ljn.5 for ; Tue, 21 Jun 2022 02:08:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RkH/f/AtK3XJLbZapTZvOZQdD3nbse4a/iN9coCgzmw=; b=fSTIKSshYbkU2qSwdwfUxENoPfSdE1GkzwSQrjGNXZyd23m5aSzTvnpPrKjNB25L3V rEBk/vnczjvkW5Q83daba/N2HI7Fu4lfkI60lN/t/sIGPYzbaKy02Yioyq5Fr0vfno/1 XqVvJcU/V7sCT5MCr/fhSEYCJ6O/wm4D3JXy3f+vAI9FoGvarQW2GC3yC1ZtB9Nk9TRR ZpljeTzMP1eY55fEfL+8N8sb90HXG5O3Gldrk00rnFdrBXT9IYvzXEeVNtx6mvRkUhLj hoJyRorsnXOgm0AqEShyrOFx//FV9t7WTHzgLZXl49vIekoV9bKpHyNYJzXD8fk4AkKM 88TA== X-Gm-Message-State: AJIora9f8kaNCxZSlazNIjZyd0VvLd36u36hRGtLO7T6FLyDYxp4xXS1 jn+rzNnSTUeN0DbcmXLEYtub7fYh370ukw+6K/piYOG7wrdBXSEINSmjskdaO4BC8OejgWj3d/K mZluuHS61JM2kIF3I/ls= X-Received: by 2002:a05:6512:4010:b0:47f:6fe6:119c with SMTP id br16-20020a056512401000b0047f6fe6119cmr5351167lfb.499.1655802489442; Tue, 21 Jun 2022 02:08:09 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vj48gYnk2DwbOKmBOZWLJQyDCnsIioED7p1GZIzwSOrqZBkNv2bkGAmsZG9OEjt9dNp/kHnw3EW9inNylMWp8= X-Received: by 2002:a05:6512:4010:b0:47f:6fe6:119c with SMTP id br16-20020a056512401000b0047f6fe6119cmr5351159lfb.499.1655802489242; Tue, 21 Jun 2022 02:08:09 -0700 (PDT) MIME-Version: 1.0 References: <20220607120014.49823-1-fengchengwen@huawei.com> <20220617022913.47564-1-fengchengwen@huawei.com> In-Reply-To: <20220617022913.47564-1-fengchengwen@huawei.com> From: David Marchand Date: Tue, 21 Jun 2022 11:07:58 +0200 Message-ID: Subject: Re: [PATCH v3 0/4] bugfix for trace To: Chengwen Feng Cc: Thomas Monjalon , dev , "Burakov, Anatoly" , Jerin Jacob Kollanukkaran , Bruce Richardson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jun 17, 2022 at 4:35 AM Chengwen Feng wrote: > > This patch contains three bugfix for trace and one test patch. > > --- > v3: > * address David Marchand's comments. > * add xxx-by from David Marchand and Jerin Jacob. > v2: > * add test-by from Jerin Jacob for the 1/3 patch. > * add freebsd change file because David Marchand verify it. > * add more bugfix patch when try to enhance testcase. > > Chengwen Feng (4): > eal: fix segment fault when exit trace > eal: fix errno not set if strftime return zero > eal: fix trace init fail with long file-prefix > test: introduce trace-autotest with traces enabled > > app/test/meson.build | 10 ++++++++++ > lib/eal/common/eal_common_trace_utils.c | 6 ++++-- > lib/eal/freebsd/eal.c | 4 ++-- > lib/eal/linux/eal.c | 4 ++-- > 4 files changed, 18 insertions(+), 6 deletions(-) Series applied, thanks. -- David Marchand