From: David Marchand <david.marchand@redhat.com>
To: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Cc: dev@dpdk.org, rjarry@redhat.com, mb@smartsharesystems.com,
stephen@networkplumber.org
Subject: Re: [PATCH v3] fib: network byte order IPv4 lookup
Date: Fri, 11 Oct 2024 16:33:47 +0200 [thread overview]
Message-ID: <CAJFAV8yNnteUzXa5-7oXzPcVUVmhLYpas8cFMoGTx6tReKdJBw@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8x9vAY=Vmc40oa0iKTAMfaobZPa6a1L+4NoYrCQjx3Wjg@mail.gmail.com>
On Fri, Oct 11, 2024 at 1:29 PM David Marchand
<david.marchand@redhat.com> wrote:
> > @@ -214,6 +215,7 @@ rte_fib_create(const char *name, int socket_id, struct rte_fib_conf *conf)
> > rte_strlcpy(fib->name, name, sizeof(fib->name));
> > fib->rib = rib;
> > fib->type = conf->type;
> > + fib->flags = conf->flags;
>
> In addition to Robin comments, I also have a concern on the
> extensibility aspect.
>
> conf->flags must be validated against known flags.
> Otherwise existing applications may pass wrong stuff and "work fine",
> until the day we had one more flag.
>
And about this flag field, please update release notes and remove the
associated deprecation notice.
Thank you.
--
David Marchand
next prev parent reply other threads:[~2024-10-11 14:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 17:06 [PATCH] " Vladimir Medvedkin
2024-09-27 23:51 ` David Marchand
2024-09-30 15:07 ` David Marchand
2024-10-04 12:01 ` Vladimir Medvedkin
2024-10-08 17:33 ` [PATCH v2] " Vladimir Medvedkin
2024-10-10 11:26 ` [PATCH v3] " Vladimir Medvedkin
2024-10-11 10:32 ` Robin Jarry
2024-10-11 11:29 ` David Marchand
2024-10-11 14:33 ` David Marchand [this message]
2024-10-11 17:57 ` [PATCH v4] " Vladimir Medvedkin
2024-10-14 13:37 ` [PATCH v5] " Vladimir Medvedkin
2024-10-14 15:22 ` Stephen Hemminger
2024-10-14 16:59 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yNnteUzXa5-7oXzPcVUVmhLYpas8cFMoGTx6tReKdJBw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=rjarry@redhat.com \
--cc=stephen@networkplumber.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).