From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Ian Stokes <ian.stokes@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Praveen Shetty <praveen.shetty@intel.com>
Subject: Re: [PATCH 04/10] net/intel: use common base code build handling
Date: Wed, 2 Apr 2025 15:05:07 +0200 [thread overview]
Message-ID: <CAJFAV8yOLW2SiTDg6QdyDmZJN29aV=Mtu0OBWP=0mRwOuerZiA@mail.gmail.com> (raw)
In-Reply-To: <20250331161000.9886-6-bruce.richardson@intel.com>
On Mon, Mar 31, 2025 at 6:10 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> diff --git a/drivers/net/intel/ice/base/meson.build b/drivers/net/intel/ice/base/meson.build
> index e7ba9c34bc..f453005a1d 100644
> --- a/drivers/net/intel/ice/base/meson.build
> +++ b/drivers/net/intel/ice/base/meson.build
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2018-2021 Intel Corporation
>
> -sources = [
> +base_sources = files(
> 'ice_controlq.c',
> 'ice_common.c',
> 'ice_sched.c',
> @@ -29,7 +29,7 @@ sources = [
> 'ice_ddp.c',
> 'ice_fwlog.c',
> 'ice_vf_mbx.c',
> -]
> +)
>
> if is_ms_compiler
> error_cflags = [
> @@ -41,22 +41,14 @@ else
> '-Wno-unused-but-set-variable',
> '-Wno-unused-parameter',
> ]
> + # Bugzilla ID: 678
> + #if (toolchain == 'gcc' and cc.version().version_compare('>=11.0.0'))
> + # error_cflags += ['-Wno-array-bounds']
> + #endif
Why keep it commented?
> endif
>
> -# Bugzilla ID: 678
> -if (toolchain == 'gcc' and cc.version().version_compare('>=11.0.0'))
> - error_cflags += ['-Wno-array-bounds']
> -endif
> -
> -c_args = cflags
> -
--
David Marchand
next prev parent reply other threads:[~2025-04-02 13:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 16:09 [PATCH 00/10] centralise base code handling for drivers Bruce Richardson
2025-03-31 16:09 ` [PATCH 01/10] build: add generic support for base code in drivers Bruce Richardson
2025-03-31 16:09 ` [PATCH 02/10] common/sfc_efx: use common base code build handling Bruce Richardson
2025-04-01 7:10 ` Andrew Rybchenko
2025-03-31 16:09 ` [PATCH 03/10] net/hinic: " Bruce Richardson
2025-03-31 16:09 ` [PATCH 04/10] net/intel: " Bruce Richardson
2025-04-02 13:05 ` David Marchand [this message]
2025-04-02 13:42 ` Bruce Richardson
2025-03-31 16:09 ` [PATCH 05/10] net/ngbe: " Bruce Richardson
2025-03-31 16:09 ` [PATCH 06/10] net/octeontx: " Bruce Richardson
2025-03-31 16:09 ` [PATCH 07/10] net/qede: " Bruce Richardson
2025-03-31 16:09 ` [PATCH 08/10] net/thunderx: " Bruce Richardson
2025-03-31 16:09 ` [PATCH 09/10] net/txgbe: " Bruce Richardson
2025-03-31 16:10 ` [PATCH 10/10] raw/ifpga: " Bruce Richardson
2025-04-01 0:27 ` Xu, Rosen
2025-04-02 13:08 ` [PATCH 00/10] centralise base code handling for drivers David Marchand
2025-04-02 13:44 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yOLW2SiTDg6QdyDmZJN29aV=Mtu0OBWP=0mRwOuerZiA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ian.stokes@intel.com \
--cc=jingjing.wu@intel.com \
--cc=praveen.shetty@intel.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).