From: David Marchand <david.marchand@redhat.com>
To: Kevin Traynor <ktraynor@redhat.com>
Cc: dev@dpdk.org, Tyler Retzlaff <roretzla@linux.microsoft.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Subject: Re: [PATCH] eal: fix logs for '--lcores'
Date: Mon, 17 Jun 2024 16:37:48 +0200 [thread overview]
Message-ID: <CAJFAV8yOxFJeHM1ysdf934y=UgCknYLTEitUcnYDyBG1UvQcpg@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8zp2z7DTziioOx5d6HL5r3GUTktaEMaq-ibN0mVKPNL9Q@mail.gmail.com>
On Thu, Jun 13, 2024 at 6:20 PM David Marchand
<david.marchand@redhat.com> wrote:
> On Thu, Jun 13, 2024 at 6:14 PM Kevin Traynor <ktraynor@redhat.com> wrote:
> >
> > The argument is '--lcores' but it is being logged as '--lcore'
> > in several places.
> >
> > e.g.
> > $ dpdk-testpmd -l 8,10,12 --lcores 8,10,12
> > EAL: Option --lcore is ignored, because (-l) is set!
> >
> > Fix the spelling in logs and tests.
> >
> > Fixes: 117eaa70584b ("eal: add error check for core options")
> Fixes: 128ee4c26d87 ("app/test: add unit tests for --lcores option")
>
> > Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2024-06-17 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 16:14 Kevin Traynor
2024-06-13 16:20 ` David Marchand
2024-06-17 14:37 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yOxFJeHM1ysdf934y=UgCknYLTEitUcnYDyBG1UvQcpg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=marko.kovacevic@intel.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).