From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5AC7042672; Fri, 29 Sep 2023 17:37:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4839B402AD; Fri, 29 Sep 2023 17:37:03 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C71FE4026E for ; Fri, 29 Sep 2023 17:37:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696001821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4jrDjUzIoFwMTcftmTFCfc2ESXYvOI2ZKawc/34sSiI=; b=P96Ud8ebqp90tLVcXdJWLUfp4kbJCHq9oo3CW1ZYwdB7O3bNqh5l4yIWh+WCsbOZnGCXqk 2/mBWHtgaVc+QtvL5f8R8kmSJqzUmcwdLqxN2Sw2oXJl+WdGqEF2eBjhGf9eFWYx2x+k65 yLGhobEIeWWWZiWWYTv2LinsYj9i/Hs= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-578-DyuDFaDcNfKBGoxJBNHsqg-1; Fri, 29 Sep 2023 11:36:59 -0400 X-MC-Unique: DyuDFaDcNfKBGoxJBNHsqg-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2c038a1e2f6so214379131fa.3 for ; Fri, 29 Sep 2023 08:36:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696001818; x=1696606618; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4jrDjUzIoFwMTcftmTFCfc2ESXYvOI2ZKawc/34sSiI=; b=cpQEbENGQyii7PZ7u2OynponezBzF82+ihR8AE8MjlhtRFXjo9Fl4up4SsnWdLXHix mjljfAdg/mYcHxqDuUv6m5qMk3K7lkR4obxtQmnM0KXt3WCHuAtqppnLGa9HuYfk3Oke /ZtEK43VYh2Pv2faIb9I/TmqMQLweiKDj1yD+F/xhNASuwtPiaMgMDEuB41SeQO1yTIV M8cqxfF14WrZqwtdhE3LjY/Jt9CWfiSBBHgOAHrSh70vGFrkw0ClZxWBTvb3Y+wlC7fG pQgTiVvf6Af0ieq9yWOXR0KFCewOJBqdUzmqbJdBUfyFNxSFu0HIrYDXDAndUUBC6X0i rh8g== X-Gm-Message-State: AOJu0Yz2DsKGSogr/jf8ykDw/fNNtgzQuYBdZPRxYyceiGJBEh553tsp 5a7yq+VjxGhq+8AP5bRNuqBddPMYBTJtiz8UXtSAz7nnqWihChqcMGKy56sGWKaNVltp/Pr5+rt 6GQLnVlViRMZ7aJImj7k= X-Received: by 2002:a2e:a1c6:0:b0:2bc:dab2:c7dc with SMTP id c6-20020a2ea1c6000000b002bcdab2c7dcmr3815132ljm.47.1696001818337; Fri, 29 Sep 2023 08:36:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEPt+Re+nKMwzH70sONonm+xEfTAz14qkhG/2Rtoq7yTsq/039bmzgRLWlqpQ1Z/bqvAhSBDgYnKtCYJlAlHSI= X-Received: by 2002:a2e:a1c6:0:b0:2bc:dab2:c7dc with SMTP id c6-20020a2ea1c6000000b002bcdab2c7dcmr3815118ljm.47.1696001818038; Fri, 29 Sep 2023 08:36:58 -0700 (PDT) MIME-Version: 1.0 References: <20230817212417.3637080-1-Harjot.Singh@arm.com> <20230817212417.3637080-2-Harjot.Singh@arm.com> In-Reply-To: <20230817212417.3637080-2-Harjot.Singh@arm.com> From: David Marchand Date: Fri, 29 Sep 2023 17:36:46 +0200 Message-ID: Subject: Re: [PATCH 1/1] hash: add SVE support for bulk key lookup To: Harjot Singh Cc: Thomas Monjalon , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , dev@dpdk.org, nd@arm.com, Nathan Brown , Feifei Wang , Jieqiang Wang , Honnappa Nagarahalli X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 17, 2023 at 11:24=E2=80=AFPM Harjot Singh wrote: > > From: Harjot Singh > > - Implemented Vector Length Agnostic SVE code for comparing signatures > in bulk lookup. > - Added Defines in code for SVE code support. > - New Optimised SVE code is 1-2 CPU cycle slower than NEON for N2 > processor. > > Performance Numbers from hash_perf_autotest : > > Elements in Primary or Secondary Location > > Results (in CPU cycles/operation) > ----------------------------------- > Operations without data > > Without pre-computed hash values > > Keysize Add/Lookup/Lookup_bulk > Neon SVE > 4 93/71/26 93/71/27 > 8 93/70/26 93/70/27 > 9 94/74/27 94/74/28 > 13 100/80/31 100/79/32 > 16 100/78/30 100/78/31 > 32 109/110/38 108/110/39 > > With pre-computed hash values > > Keysize Add/Lookup/Lookup_bulk > Neon SVE > 4 83/58/27 83/58/29 > 8 83/57/27 83/57/28 > 9 83/60/28 83/60/29 > 13 84/60/28 83/60/29 > 16 83/58/27 83/58/29 > 32 84/68/31 84/68/32 > > Signed-off-by: Harjot Singh > Reviewed-by: Nathan Brown > Reviewed-by: Feifei Wang > Reviewed-by: Jieqiang Wang > Reviewed-by: Honnappa Nagarahalli Thanks for the patch, please update the release notes. --=20 David Marchand