From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Aaron Conole <aconole@redhat.com>,
Bruce Richardson <bruce.richardson@intel.com>, dev <dev@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux
Date: Mon, 12 Apr 2021 13:33:50 +0200 [thread overview]
Message-ID: <CAJFAV8yPB2LjnRdy+O7Zye1LWyCFB2aX8NzPgSMHNS72mM344g@mail.gmail.com> (raw)
In-Reply-To: <5237468.PbloVLfHjj@thomas>
On Fri, Apr 9, 2021 at 5:33 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > This seems to me like the test binary itself should be checking the
> > > presence of hugepages, and reporting skips if necessary. It's not just when
> > > run through ninja that this functionality would be useful.
> >
> > Either way, there needs to be a rework - if we do it in the test binary,
> > then the tests that require hugepages need to be worked so that they
> > correctly detect lack of hugepage support before starting. If we keep
> > that knowledge in the meson system, then we need to change the way we
> > call the test binary script to support a more robust detection.
> >
> > I guess, I don't care too much which one is the one we choose. My $.02
> > opinion is that we already have most of the logic and whatnot done in
> > the build system, so I'd prefer to do as small a change as possible
> > (leaving that logic in the meson system). Then again, maybe it makes
> > more sense to just rip the bandaid off and move it all into the test
> > framework.
> >
> > WDYT?
>
> I think the test application should adapt to its environment.
> If no hugepage, then mark the tests requiring hugepages as skipped.
> For the other tests, we could use --in-memory.
There are tests that rely/test mp.
They would have to be identified and skipped if we want to go with --in-memory.
--
David Marchand
next prev parent reply other threads:[~2021-04-12 11:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 14:44 Aaron Conole
2021-03-17 14:57 ` Thomas Monjalon
2021-04-06 12:33 ` Aaron Conole
2021-04-06 12:58 ` Bruce Richardson
2021-04-06 14:20 ` Aaron Conole
2021-04-06 14:50 ` Bruce Richardson
2021-04-09 15:06 ` Aaron Conole
2021-04-09 15:33 ` Thomas Monjalon
2021-04-12 11:33 ` David Marchand [this message]
2021-04-09 15:40 ` Bruce Richardson
2021-03-19 13:41 ` David Marchand
2021-03-19 14:34 ` Aaron Conole
2023-06-29 16:30 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yPB2LjnRdy+O7Zye1LWyCFB2aX8NzPgSMHNS72mM344g@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).