From: David Marchand <david.marchand@redhat.com>
To: David Christensen <drc@linux.vnet.ibm.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] config/ppc: ignore gcc 11 psabi warnings
Date: Mon, 13 Sep 2021 09:17:41 +0200 [thread overview]
Message-ID: <CAJFAV8yPyxd=CKRXAV4YAN=A3nyyUZumqE4Hv1v7EX_WgMzNDA@mail.gmail.com> (raw)
In-Reply-To: <20210902235326.3236718-1-drc@linux.vnet.ibm.com>
On Fri, Sep 3, 2021 at 1:53 AM David Christensen <drc@linux.vnet.ibm.com> wrote:
>
> Suppress the gcc warning "note: the layout of aggregates containing
> vectors with 4-byte alignment has changed in GCC 5" on POWER systems
> by setting "-Wno-psabi". Warning was originally added to gcc in
> commit https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=9832651 to warn
> of the vector alignment changes introduced in GCC 5. Older gcc
> versions forced vector alignment to 16 bytes due to requirements for
> POWER 6 and earlier CPUs, but these restrictions don't apply to CPUs
> supported by DPDK.
>
> Bugzilla ID: 739
I guess the intent was to have this backported.
So added explicit Cc: stable@dpdk.org
>
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
> ---
> v2:
> - update copyright year
> - rebase for 21.11-rc0
> ---
> config/ppc/meson.build | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/config/ppc/meson.build b/config/ppc/meson.build
> index adf49e1f42..5354db4e0a 100644
> --- a/config/ppc/meson.build
> +++ b/config/ppc/meson.build
> @@ -1,5 +1,6 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2018 Luca Boccassi <bluca@debian.org>
> +# Copyright(c) 2021 IBM Corporation
>
> if not dpdk_conf.get('RTE_ARCH_64')
> error('Only 64-bit compiles are supported for this platform type')
> @@ -17,6 +18,12 @@ if not power9_supported
> dpdk_conf.set('RTE_MACHINE','power8')
> endif
>
> +# Suppress the gcc warning "note: the layout of aggregates containing
> +# vectors with 4-byte alignment has changed in GCC 5".
> +if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi')
Wrapped this to next line.
> + add_project_arguments('-Wno-psabi', language: 'c')
> +endif
> +
> # Certain POWER9 systems can scale as high as 1536 LCORES, but setting such a
> # high value can waste memory, cause timeouts in time limited autotests, and is
> # unlikely to be used in many production situations. Similarly, keeping the
> --
> 2.27.0
>
Applied, thanks.
--
David Marchand
next prev parent reply other threads:[~2021-09-13 7:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 16:16 [dpdk-dev] [PATCH] " David Christensen
2021-09-02 23:53 ` [dpdk-dev] [PATCH v2] " David Christensen
2021-09-08 17:11 ` David Christensen
2021-09-13 7:17 ` David Marchand [this message]
2021-09-14 9:18 ` Ferruh Yigit
2021-09-14 10:16 ` David Marchand
2021-09-14 10:21 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yPyxd=CKRXAV4YAN=A3nyyUZumqE4Hv1v7EX_WgMzNDA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).