From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF8C0A0093; Tue, 19 May 2020 11:32:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C7F4A1C43A; Tue, 19 May 2020 11:32:09 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 4BD1D1C2A3 for ; Tue, 19 May 2020 11:32:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589880727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Cy/IxD0U0PuQCJcN2jCghQUzJzlHI94VWen3UHcif60=; b=eaQGpSWjaqwXqBBEEe/gL/ljZbc9oy/wbhOLdGiVZlH7Wbor0aST0aRkFdrQ7UfTmww1xw jbF11+XCOrehWItI9oJ0lWK3+gUpADzz0TfkfEdT9gX3G/s9zz6CL6/ptONXqYXXBvDwcr PltXj2Nr370hJFetc/cSCGjQUJRZzFk= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-78-S_kf5KLTOzu1zc_Fc3WUHQ-1; Tue, 19 May 2020 05:32:06 -0400 X-MC-Unique: S_kf5KLTOzu1zc_Fc3WUHQ-1 Received: by mail-ua1-f71.google.com with SMTP id z20so4718471uag.19 for ; Tue, 19 May 2020 02:32:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Cy/IxD0U0PuQCJcN2jCghQUzJzlHI94VWen3UHcif60=; b=WnLaLAVfX0ypVyz+9SWOkmyRRFvA9lzIpc37QOyh5maNaEXXdjcQRim/J+8sAAiu6h RgeaEjj3dF7YFJiB0fc6GbufGsE/74kHxQnLoG80LtabzaDWqTAB0Zcx6DIC76QOOl/m +ImWoSoVclGWfI02L2AVN0WbCQjhU9Mu9SeGtSZmhcvJ6nD/pjsEayGsWQioVzqEpa/C KnQeoZScjEu6rjj3iBxHqijDrM9C3ismkTi2FdgDm0XmsIgW8quYR1sSUKnQmu5LSFey 3KJytsgx6MSnUaPNlmVg7AXj95SJAI+9nI4Z9fRvpmd4S5RLBYdMbjU9eH/zDAZ6aktx FZhg== X-Gm-Message-State: AOAM531mjG+nj5RUdyED5Ysh9bK3AaA1IPxEeYqiResOCqqYW6bFndau PzdFLpn7T3NGwo5DvcdJuVlk0caBh+KNU9Ox0I7jvIGZQogmfGZA2ZTf6CBl3nWOaarDJ6Yz3HS iPjOXwaGs+fUrG1rIqXA= X-Received: by 2002:a1f:8cc3:: with SMTP id o186mr13557039vkd.18.1589880725475; Tue, 19 May 2020 02:32:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzya6sbT8YWXGdqDT6O7fl8KTADpJPC61X0pnKF2Qtc4TeCDKELtmwxjVu/GpAIPZ+P9CuoZ/CEkxLojhAf1bI= X-Received: by 2002:a1f:8cc3:: with SMTP id o186mr13557028vkd.18.1589880725255; Tue, 19 May 2020 02:32:05 -0700 (PDT) MIME-Version: 1.0 References: <20200513103629.8436-1-hemant.agrawal@nxp.com> In-Reply-To: <20200513103629.8436-1-hemant.agrawal@nxp.com> From: David Marchand Date: Tue, 19 May 2020 11:31:54 +0200 Message-ID: To: Hemant Agrawal , Bruce Richardson Cc: dev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/2] lib/metrics: fix to reset the init flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 13, 2020 at 12:39 PM Hemant Agrawal wrote: > > metrics_initialized shall be reset in deinit function > This is currently causing issue in running > metrics_autotest mulutiple times > > Fixes: 07c1b6925b65 ("telemetry: invert dependency on metrics library") > > Signed-off-by: Hemant Agrawal > --- > lib/librte_metrics/rte_metrics.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/librte_metrics/rte_metrics.c b/lib/librte_metrics/rte_metrics.c > index e07670219..f570cf226 100644 > --- a/lib/librte_metrics/rte_metrics.c > +++ b/lib/librte_metrics/rte_metrics.c > @@ -96,6 +96,8 @@ rte_metrics_deinit(void) > stats = memzone->addr; > memset(stats, 0, sizeof(struct rte_metrics_data_s)); > > + metrics_initialized = 0; > + > return rte_memzone_free(memzone); Should this flag be reset only if rte_memzone_free succeeds? -- David Marchand