From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62F9CA0C43; Wed, 20 Oct 2021 11:55:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C01B40687; Wed, 20 Oct 2021 11:55:20 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D1A2840142 for ; Wed, 20 Oct 2021 11:55:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634723718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cC0QevGSOKSgswksmvK9gj/mfcShiG6DSV/v6W1+w7k=; b=UM3JmpVXmY01EilcmDWmCArUomxGfMG5s/UeqnSmel35sKhap6SC8eEd8xkkC93Tu4KrHu PVft083Y937Cv1nXrCdTal96ZFuW5k5g413kYHwhvXsjPwsUM5ZHyHJ+N5i0CollPS1pAU +ujAZUiq1HVbX1fUQRO/UDzINio/UuU= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-418-EFyh-HfROyybg0o7Ty4YTA-1; Wed, 20 Oct 2021 05:55:17 -0400 X-MC-Unique: EFyh-HfROyybg0o7Ty4YTA-1 Received: by mail-lj1-f197.google.com with SMTP id t7-20020a2e7807000000b00210dad8b167so1588070ljc.22 for ; Wed, 20 Oct 2021 02:55:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cC0QevGSOKSgswksmvK9gj/mfcShiG6DSV/v6W1+w7k=; b=aIsM+0pPplMpoTyZ+HvcWys6OOf5tb8SyfsBxDTSKEIKewX9nnA5rM++MQ7shW+7hW NA/NSUBB99R0RibQtBcjrr112vZQNcUEHgWAmj6oS9dNkay7nLT8fZ4E9/1RCtY0Jvxd u8lP4oJuWxrQmqofGRFx6aWkV9ryHGK/IQPJCkFPsAk0FlM57IXPicHSyxkNpGL7ngc7 OetIkrbl4VbylzilQZeyTsyIb4m+rpypEAD2P09hBVOPfal39cXJcSHzHdJPb0vlNaKM SxSbQUP9H67ktIuVvM1bHTu8auZvDyc9JUcgNwPec+di/4ytqkP6o4Rr0KX7sfoH4qcM PEPQ== X-Gm-Message-State: AOAM531EoW3dQN4xzvVlf29H4l4JzQb1vnD32ZbGAm0+tzfyW+StzS1V e4v2VAMAyW7BQ/EM9dGK1o/BdXW9Poo6W9Bp/OHYMw/kBn2XZd1FsVY2RLHiPhS+VYw3SYo48Gs j28p1aYYkoXa0smizPwM= X-Received: by 2002:a2e:9018:: with SMTP id h24mr13117897ljg.477.1634723715554; Wed, 20 Oct 2021 02:55:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxo8ABdPGAEhim8j5PG7FJFBv2vs+EQ0GhPuzSJ7J7+9JMuleFWDQCgU8a+w9LQTjAUH/ep61ki4tLbhUFoHBs= X-Received: by 2002:a2e:9018:: with SMTP id h24mr13117884ljg.477.1634723715353; Wed, 20 Oct 2021 02:55:15 -0700 (PDT) MIME-Version: 1.0 References: <20211020065944.19617-1-david.marchand@redhat.com> <9510b844-5aec-43e6-b324-2358a4f52042@huawei.com> In-Reply-To: <9510b844-5aec-43e6-b324-2358a4f52042@huawei.com> From: David Marchand Date: Wed, 20 Oct 2021 11:55:04 +0200 Message-ID: To: fengchengwen Cc: dev , Ray Kinsella Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/2] dmadev: hide devices array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 20, 2021 at 11:47 AM fengchengwen wrote: > > On 2021/10/20 14:59, David Marchand wrote: > > No need to expose rte_dma_devices out of the dmadev library. > > Existing helpers should be enough, and inlines make use of > > rte_dma_fp_objs. > > > > Signed-off-by: David Marchand > > --- > > app/test/test_dmadev.c | 5 +++-- > > lib/dmadev/rte_dmadev.c | 2 +- > > lib/dmadev/rte_dmadev_pmd.h | 2 -- > > lib/dmadev/version.map | 1 - > > 4 files changed, 4 insertions(+), 6 deletions(-) > > > > diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c > > index 1e327bd45f..8b58256afc 100644 > > --- a/app/test/test_dmadev.c > > +++ b/app/test/test_dmadev.c > > @@ -747,10 +747,11 @@ test_dmadev_instance(int16_t dev_id) > > }; > > const int vchan = 0; > > > > + rte_dma_info_get(dev_id, &info); > > suggest declare info as: struct rte_dma_stats info = { 0 }; > so that the following %s will display NULL if rte_dma_info_get call fail. The problem is more generic. Other info fields are used by the test. If rte_dma_info_get can fail, its return code must be checked. Worth a followup patch, can you send it? Thanks. -- David Marchand