From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Andre Muezerie <andremue@linux.microsoft.com>,
Ian Stokes <ian.stokes@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
dev@dpdk.org
Subject: Re: [PATCH] drivers: remove invalid options for MSVC
Date: Wed, 12 Mar 2025 16:29:40 +0100 [thread overview]
Message-ID: <CAJFAV8yS=Lfcv=q0JwrU2+57z=jMz5K2grAsYTU2omOxR62Xww@mail.gmail.com> (raw)
In-Reply-To: <Z9Glyi4qOjAFBHTG@bricha3-mobl1.ger.corp.intel.com>
On Wed, Mar 12, 2025 at 4:19 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> > diff --git a/drivers/net/intel/ixgbe/meson.build b/drivers/net/intel/ixgbe/meson.build
> > index 0ae12dd5ff..3553b0ffe1 100644
> > --- a/drivers/net/intel/ixgbe/meson.build
> > +++ b/drivers/net/intel/ixgbe/meson.build
> > @@ -27,7 +27,7 @@ deps += ['hash', 'security']
> > if arch_subdir == 'x86'
> > sources += files('ixgbe_rxtx_vec_sse.c')
> > sources += files('ixgbe_recycle_mbufs_vec_common.c')
> > - if is_windows and cc.get_id() != 'clang'
> > + if is_windows and cc.get_id() == 'gcc'
> > cflags += ['-fno-asynchronous-unwind-tables']
> > endif
> > elif arch_subdir == 'arm'
>
> Out of interest I've just tried compiling up DPDK builds without these
> unwind-tables flag, and they all pass, including the mingw build. This is
> using:
>
> $ x86_64-w64-mingw32-gcc --version
> x86_64-w64-mingw32-gcc (GCC) 13-win32
> Copyright (C) 2023 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions. There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>
> Therefore, I wonder if we can just remove all these flags completely for
> mingw now? They may only be needed for historical versions.
Here is the original issue:
https://inbox.dpdk.org/dev/CAJFAV8z3qFhT9Vv5xOpLhi74BYAht2YCfL2ffLrmei4hfSG5jg@mail.gmail.com/
It happened with mingw 8.1.0 apparently.
--
David Marchand
next prev parent reply other threads:[~2025-03-12 15:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 2:13 Andre Muezerie
2025-03-12 7:51 ` David Marchand
2025-03-12 14:22 ` Andre Muezerie
2025-03-12 15:18 ` Bruce Richardson
2025-03-12 15:29 ` David Marchand [this message]
2025-03-12 15:49 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8yS=Lfcv=q0JwrU2+57z=jMz5K2grAsYTU2omOxR62Xww@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=andremue@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ian.stokes@intel.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).