From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7AABAA034C; Wed, 21 Sep 2022 10:15:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B75F40697; Wed, 21 Sep 2022 10:15:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0C0AF4014F for ; Wed, 21 Sep 2022 10:15:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663748150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=levLcAxKlFaReMBagGock38LcErpEYr++6UqQWrqeeU=; b=c6y2w4Ya9EUmqkA6mzylurI3ENr2N/M045+6XpG3zbc8msqq1/fSzwBW3hri89GtBZAn3s mWa3Zz3Bk+Wgt1ZYTOXFFceLK3egjMHnCWwZK1VFsWlMn6PqRi5sbqGBn/HvQnDUV7yUMC u2Kj114hTw1poroDmq3RGSMGKgIVoBQ= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-49-S1_wPbwUOYmlmTk_BcG14g-1; Wed, 21 Sep 2022 04:15:49 -0400 X-MC-Unique: S1_wPbwUOYmlmTk_BcG14g-1 Received: by mail-lj1-f199.google.com with SMTP id c9-20020a2e9d89000000b0026bde11179dso1746108ljj.22 for ; Wed, 21 Sep 2022 01:15:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=levLcAxKlFaReMBagGock38LcErpEYr++6UqQWrqeeU=; b=puWgt+LIbgRWBNA7DeED5IVgx4TK2FtdKz3NhbpE2FS5hF7Ckb1RfVkmbRAuemXzTo naXz7om+A4AX/luLLK1PwjlC3zq/X4+t8KW4A5hDT3zF53udzMIXnP98gSyqDSsKpHx8 YAwVlLMOnZ5wQMk42f3XBtce9Td6BTfM/svkaqe7nC/QQK9eyjrAA4YUknoMYxwXrTYv RjoJ2B4CEM4sexOgNGN6M9PAwgSoXUOYMhumpwle+9LiGSSdB3QA1gpTlIipyyanYyU5 HOw02v9MGaEO3ve4TzrVEJFZbskHZTS2gvjRVNCR9cI91g/xRhArvFUtSJcVWq6KNCpZ GKSg== X-Gm-Message-State: ACrzQf0VvdH1usb9L66oGnSzx80MBNbeCv+vHivpTYFb3/11D+ApuiPW /TGadaF8hAHWyR3Iy/+eCoWYxvglGc8XpaqyAzPfAeAhvzWaveVZNJfAxvGtcsQgpXiEz8i6MlN v0gSx5b+hQcaCuReHEYg= X-Received: by 2002:a05:6512:694:b0:498:ff40:24e with SMTP id t20-20020a056512069400b00498ff40024emr8887235lfe.265.1663748147840; Wed, 21 Sep 2022 01:15:47 -0700 (PDT) X-Google-Smtp-Source: AMsMyM63H7Gjyq8mne57K+GL2cYlqLwn5gELUWrdT7BC2olXf4NmG3HLNcKFXCyFA4KYXiBb3tpAO1NF/eAWjxXAPg4= X-Received: by 2002:a05:6512:694:b0:498:ff40:24e with SMTP id t20-20020a056512069400b00498ff40024emr8887224lfe.265.1663748147597; Wed, 21 Sep 2022 01:15:47 -0700 (PDT) MIME-Version: 1.0 References: <1654783134-13303-1-git-send-email-roretzla@linux.microsoft.com> <1656348966-10194-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1656348966-10194-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Wed, 21 Sep 2022 10:15:36 +0200 Message-ID: Subject: Re: [PATCH v4 0/6] add thread lifetime and attributes API To: Tyler Retzlaff Cc: dev@dpdk.org, thomas@monjalon.net, dmitry.kozliuk@gmail.com, anatoly.burakov@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 27, 2022 at 6:56 PM Tyler Retzlaff wrote: > > add rte thread lifetime and attributes api. with these api additions > there is now sufficient platform abstracted thread api to remove the > use of pthread in the unit tests. > > v4: > * update version.map to show api from series added in 22.11 instead > of 22.07. Patch 1 still adds symbols in 22.07 section of the experimental block. Compilation is broken when stopping at patch 4. Newly added code can go to eal_common_thread.c rather than introduce a new common/rte_thread.c file (or is there a rationale for this?). There are guards for the new structs against RTE_HAS_CPUSET being defined. Can you elaborate why those guards are needed? Commitlogs / comments sentences must start with a capital letter. Can you prepare a new revision for -rc1? Thanks. > * fix missing parameter name in rte_thread_func declaration causing > doxygen ci failure. -- David Marchand