From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 392DEA00C3; Tue, 1 Feb 2022 10:28:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2363740691; Tue, 1 Feb 2022 10:28:08 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EAA5B40691 for ; Tue, 1 Feb 2022 10:28:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643707686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r8/ZbSKxMwVb3obSs3ZqFyUezLeHOHXE9aTtb7+Fy6k=; b=ToYgpn18TBbNjodS2OjkcjOprSxaYytomdtHt48n4HUAX5hC3praRop7wcoLae5t1XBly1 DDzf77CjDAxWbyBiCw/f34dDPa6pT6tgkp0KHDClj11LVsYWPiqK2Yhs2qj4nGv9jJfTZZ K6cTLwulMjwFGYgqgg0Ji/OzaceZHjg= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-82-X8-RgSVHOBe7Mab6NF7Meg-1; Tue, 01 Feb 2022 04:28:00 -0500 X-MC-Unique: X8-RgSVHOBe7Mab6NF7Meg-1 Received: by mail-lf1-f72.google.com with SMTP id h11-20020ac250cb000000b00436e68ebef5so5677700lfm.19 for ; Tue, 01 Feb 2022 01:28:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r8/ZbSKxMwVb3obSs3ZqFyUezLeHOHXE9aTtb7+Fy6k=; b=HKJoFoWM9eYPPCTLNNRB8aVJgBm9AS0DHuMIeoZwdGaClkwb9ZWlrsfdiCy0Jo/Qet jXIqvfyZcA184YH/AvejJpKIeVjgAn8K+fck75iKm32OFdSi9kpyNAGSUvCBLv7FO4DI 1TOAy6r0Rv1RYuh+8DPuc5qtWnlLpu5HRvgig0A8A2tedTaOjRqwti/ccx0yAVtQT31b 8e69HdUOFndhr2/gHu53z3hTqI7xEDQOoH4+eXNO1ceBouinFZlhaMwggFSnc5Nr2VAO U1YkY+D+YTI7LnCaM/Ke3Zl35YKKEvFIrFlOMLuMgF+HwYBszFkJph/HHRyvZOf87l3t QzaQ== X-Gm-Message-State: AOAM5320mra3blr6S2YFTRyfcKT2VxIFB9/pnT6Nfs7VWYISrqq1w05q RW6dHEztGG7Uo3zPzAE6IJmLuEwYdNRH9XqBD66KRHUe2snmlRI6ONnrrMDBezxGLuKE3LgYbKp 3uZ54kMWcuUrLMBrQv7Y= X-Received: by 2002:a05:6512:31cd:: with SMTP id j13mr18888343lfe.484.1643707678963; Tue, 01 Feb 2022 01:27:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJxC76vVJT4ZFFBAGLlcn7+GPIKZeTrZuVcdMSOXUg4ysPjYqT1wIRXk+/jW3w1kWc4s3r1znwONAlIemj+fuvY= X-Received: by 2002:a05:6512:31cd:: with SMTP id j13mr18888324lfe.484.1643707678696; Tue, 01 Feb 2022 01:27:58 -0800 (PST) MIME-Version: 1.0 References: <20211206121824.3493-1-nipun.gupta@nxp.com> <20220103100129.23965-1-nipun.gupta@nxp.com> <20220103100129.23965-11-nipun.gupta@nxp.com> In-Reply-To: <20220103100129.23965-11-nipun.gupta@nxp.com> From: David Marchand Date: Tue, 1 Feb 2022 10:27:47 +0100 Message-ID: Subject: Re: [PATCH v3 10/15] net/dpaa2: support recycle loopback port To: Nipun Gupta , Jun Yang Cc: dev , Thomas Monjalon , "Yigit, Ferruh" , Hemant Agrawal , Stephen Hemminger Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello guys, On Mon, Jan 3, 2022 at 11:02 AM wrote: > diff --git a/drivers/net/dpaa2/dpaa2_recycle.c b/drivers/net/dpaa2/dpaa2_recycle.c > new file mode 100644 > index 0000000000..e274d24ead > --- /dev/null > +++ b/drivers/net/dpaa2/dpaa2_recycle.c > @@ -0,0 +1,780 @@ > +/* * SPDX-License-Identifier: BSD-3-Clause > + * > + * Copyright 2019-2021 NXP > + * > + */ > + > +#include > +#include > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "dpaa2_pmd_logs.h" > +#include > +#include > +#include > +#include > +#include > +#include "dpaa2_ethdev.h" > +#include "dpaa2_sparser.h" > +#include > + > +#include > +#include > +#include > + > +#define PAGE_SIZE (sysconf(_SC_PAGESIZE)) > +#define PAGE_MASK (~(PAGE_SIZE - 1)) This patch breaks compilation in Alpine Linux in next-net and main repositories. Can you provide a fix? Thanks. This was initially reported by UNH: http://mails.dpdk.org/archives/test-report/2022-January/250111.html FAILED: drivers/a715181@@tmp_rte_net_dpaa2@sta/net_dpaa2_dpaa2_recycle.c.o ccache cc -Idrivers/a715181@@tmp_rte_net_dpaa2@sta -Idrivers -I../drivers -Idrivers/net/dpaa2 -I../drivers/net/dpaa2 -I../drivers/net/dpaa2/base -I../drivers/net/dpaa2/mc -Ilib/ethdev -I../lib/ethdev -I. -I../ -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -Idrivers/mempool/dpaa2 -I../drivers/mempool/dpaa2 -Idrivers/bus/fslmc -I../drivers/bus/fslmc -I../drivers/bus/fslmc/mc -I../drivers/bus/fslmc/qbman/include -I../drivers/bus/fslmc/portal -Idrivers/common/dpaax -I../drivers/common/dpaax -I../drivers/common/dpaax/caamflib -Ilib/eventdev -I../lib/eventdev -Ilib/hash -I../lib/hash -Ilib/rcu -I../lib/rcu -Ilib/timer -I../lib/timer -Ilib/cryptodev -I../lib/cryptodev -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initializers -Wno-zero-length-bounds -D_GNU_SOURCE -fPIC -march=native -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.dpaa2 -MD -MQ 'drivers/a715181@@tmp_rte_net_dpaa2@sta/net_dpaa2_dpaa2_recycle.c.o' -MF 'drivers/a715181@@tmp_rte_net_dpaa2@sta/net_dpaa2_dpaa2_recycle.c.o.d' -o 'drivers/a715181@@tmp_rte_net_dpaa2@sta/net_dpaa2_dpaa2_recycle.c.o' -c ../drivers/net/dpaa2/dpaa2_recycle.c ../drivers/net/dpaa2/dpaa2_recycle.c:35: error: "PAGE_SIZE" redefined [-Werror] 35 | #define PAGE_SIZE (sysconf(_SC_PAGESIZE)) | In file included from /usr/include/fortify/stdlib.h:29, from ../lib/eal/include/rte_common.h:20, from ../lib/mbuf/rte_mbuf.h:36, from ../drivers/net/dpaa2/dpaa2_recycle.c:10: /usr/include/limits.h:97: note: this is the location of the previous definition 97 | #define PAGE_SIZE PAGESIZE | cc1: all warnings being treated as errors -- David Marchand