From: David Marchand <david.marchand@redhat.com>
To: John Levon <john.levon@nutanix.com>
Cc: dev <dev@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] eal/linux: allow hugetlbfs sub-directories
Date: Tue, 12 Oct 2021 21:03:09 +0200 [thread overview]
Message-ID: <CAJFAV8ySX4ewfchdxWHcunuJRnaavRDR=H5WcKNdBcBfZvwQgQ@mail.gmail.com> (raw)
In-Reply-To: <20211012160520.1276061-1-john.levon@nutanix.com>
On Tue, Oct 12, 2021 at 6:06 PM John Levon <john.levon@nutanix.com> wrote:
>
> get_hugepage_dir() was implemented in such a way that a --huge-dir
> option had to exactly match the mountpoint, but there's no reason for
> this restriction: DPDK might not be the only user of hugepages, and
> shouldn't assume it owns an entire mountpoint. For example, if I have
> /dev/hugepages/myapp, and /dev/hugepages/dpdk, I should be able to
> specify:
>
> --huge-dir=/dev/hugepages/dpdk/
>
> and have DPDK only use that sub-directory.
>
> Fix the implementation to allow a sub-directory within a suitable
> hugetlbfs mountpoint to be specified, preferring the closest match.
>
> Signed-off-by: John Levon <john.levon@nutanix.com>
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
> diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst
> index 54718ff367..9fe689356b 100644
> --- a/doc/guides/rel_notes/release_21_11.rst
> +++ b/doc/guides/rel_notes/release_21_11.rst
> @@ -154,7 +159,6 @@ New Features
> * Added tests to verify tunnel header verification in IPsec inbound.
> * Added tests to verify inner checksum.
>
> -
Restored this empty line: sections in doc are separated with two empty lines.
> Removed Items
> -------------
>
--
David Marchand
next prev parent reply other threads:[~2021-10-12 19:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 21:05 [dpdk-dev] [PATCH] eal: " John Levon
2021-06-25 10:44 ` [dpdk-dev] [PATCH RESEND] " John Levon
2021-07-06 9:43 ` David Marchand
2021-07-07 20:06 ` Dmitry Kozlyuk
2021-07-07 21:58 ` John Levon
2021-07-08 9:36 ` [dpdk-dev] [PATCH] " John Levon
2021-07-08 9:36 ` John Levon
2021-07-08 10:59 ` [dpdk-dev] [PATCH v3] " John Levon
2021-07-15 22:37 ` Dmitry Kozlyuk
2021-07-22 20:29 ` David Marchand
2021-07-22 21:06 ` John Levon
2021-07-23 7:29 ` Thomas Monjalon
2021-08-09 11:24 ` [dpdk-dev] [PATCH] " John Levon
2021-08-09 13:45 ` Jerin Jacob
2021-08-17 20:05 ` John Levon
2021-10-12 12:38 ` David Marchand
2021-10-12 16:05 ` [dpdk-dev] [PATCH] eal/linux: " John Levon
2021-10-12 19:03 ` David Marchand [this message]
2021-10-12 19:58 ` John Levon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8ySX4ewfchdxWHcunuJRnaavRDR=H5WcKNdBcBfZvwQgQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=john.levon@nutanix.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).