DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Didier Pallard <didier.pallard@6wind.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
	John Griffin <john.griffin@intel.com>,
	 Fiona Trahe <fiona.trahe@intel.com>,
	Deepak Kumar Jain <deepak.k.jain@intel.com>,
	 Olivier Matz <olivier.matz@6wind.com>,
	Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] common/qat: add missing kmod dependency
Date: Fri, 23 Oct 2020 18:32:16 +0200	[thread overview]
Message-ID: <CAJFAV8ySY3sFQBO30QrEfO+BK1T3Rz7rt9ZZTLh1PRrZT_CdBw@mail.gmail.com> (raw)
In-Reply-To: <20201023154457.26776-1-didier.pallard@6wind.com>

Salut Didier,

On Fri, Oct 23, 2020 at 5:45 PM Didier Pallard <didier.pallard@6wind.com> wrote:
> Dependency on kmod needed to manage crypto devices is missing
> in qat crypto pmd.
> Cc: stable@dpdk.org
> Fixes: 0880c40113ef ("drivers: advertise kmod dependencies in pmdinfo")

The Fixes: tag goes first, then Cc:, then empty line.

> Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
> ---
>  drivers/common/qat/qat_device.c | 1 +
>  1 file changed, 1 insertion(+)
> diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c
> index b050ce20e4fc..9fa142b5e5bb 100644
> --- a/drivers/common/qat/qat_device.c
> +++ b/drivers/common/qat/qat_device.c
> @@ -423,3 +423,4 @@ qat_comp_dev_destroy(struct qat_pci_device *qat_pci_dev __rte_unused)
> +RTE_PMD_REGISTER_KMOD_DEP(QAT_PCI_NAME, "* igb_uio | uio_pci_generic | vfio-pci");
> --
> 2.20.1

Reviewed-by: David Marchand <david.marchand@redhat.com>

There are some other drivers that have the issue.
If there is a volunteer, we have other drivers with the same issue
(but probably worth double checking):
$ git grep -l 'drv_flags = RTE_PCI_DRV_NEED_MAPPING' drivers/ |xargs
dirname |sort -u|while read dir; do dir=${dir%%/base}; git grep -q
RTE_PMD_REGISTER_KMOD_DEP $dir || echo $dir; done
drivers/common/qat # done

David Marchand

  reply	other threads:[~2020-10-23 16:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-23 15:44 [dpdk-dev] " Didier Pallard
2020-10-23 16:32 ` David Marchand [this message]
2020-10-23 17:20   ` [dpdk-dev] [dpdk-stable] " Trahe, Fiona
2020-10-28 11:49 ` [dpdk-dev] " Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8ySY3sFQBO30QrEfO+BK1T3Rz7rt9ZZTLh1PRrZT_CdBw@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=deepak.k.jain@intel.com \
    --cc=dev@dpdk.org \
    --cc=didier.pallard@6wind.com \
    --cc=fiona.trahe@intel.com \
    --cc=john.griffin@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).