From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3420A04DD; Fri, 23 Oct 2020 18:32:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D02D658F1; Fri, 23 Oct 2020 18:32:33 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 4E1C04C96 for ; Fri, 23 Oct 2020 18:32:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603470749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Mb/Pd19SEFEJF2zFE6UjTkTmFYaliHyAk/Jk44bP0fA=; b=i/xFrg+QY73X66HvYLkEo+EFy6i5/f+/+Y0bfJ6zZ3qDrxPn7WYQeLRfu/jOQAU51aB7Vs B0zNXy1NkfMRNFmJez0SH3kP8LxnukTfFTV7EKo0tGdCrwAHi+WeYib8yNXhMHO2bGWjC6 4d7cDYcum/Cxm0K7MS8j3rOZT6+ii2M= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-590-207zbc6LOGakRilQDBHmJQ-1; Fri, 23 Oct 2020 12:32:28 -0400 X-MC-Unique: 207zbc6LOGakRilQDBHmJQ-1 Received: by mail-vs1-f70.google.com with SMTP id q26so519386vsp.5 for ; Fri, 23 Oct 2020 09:32:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mb/Pd19SEFEJF2zFE6UjTkTmFYaliHyAk/Jk44bP0fA=; b=HYnxcsbWOlRLcRgHiICeHLQqgjPTipegoCNyeXpRmHErHNxzJ7m6KmQBDkEEVy2cdQ 3fH0ail91zCNTho2bAKVqfCPLfo9odTfhv7W2p9Ux244f/hm1xNvcdMx7oDWpMfS2Pm6 CmTbCNlzZOAwl3BxmD1MoHCNyA6Tutn0stutFMJigO6Jh7aMKrIFp1m9h7KqM+xtYcD6 LdDYXTxne1bfKThbOuegZsWDsGSCmuCeU+BPnpIdAdIDFwp5hs/P8T7L63dfKszfAnan eXjOyI9WJxohB/b+4Vr3b3tuQ1SEzs6vw+CplOco1OE/SOtLdMrArySy0pbvm+A0orS4 Z9jQ== X-Gm-Message-State: AOAM533y6D1FFmtAlCe+OgzsWN3y04g9070BNTiBQMlcI4Fx/BXz3IF0 /lyHWcCW9U1e3CLnfizHcgd7NXbwl6MImEMJlpSbL/P9ps5jpZ/nFXCtii1UwfRa2zB7NyZdOWP Mxy0qz6Od8Oml95OXtk8= X-Received: by 2002:a67:2fca:: with SMTP id v193mr2466130vsv.18.1603470747663; Fri, 23 Oct 2020 09:32:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyt8Y/bdiRh187dKHcIxhHSPG+xY/uz/crfVisDwj/o4J2XVIs1O2kf2ITWCFoKeTYFHV7zLG1afhKiBrybrsU= X-Received: by 2002:a67:2fca:: with SMTP id v193mr2466116vsv.18.1603470747438; Fri, 23 Oct 2020 09:32:27 -0700 (PDT) MIME-Version: 1.0 References: <20201023154457.26776-1-didier.pallard@6wind.com> In-Reply-To: <20201023154457.26776-1-didier.pallard@6wind.com> From: David Marchand Date: Fri, 23 Oct 2020 18:32:16 +0200 Message-ID: To: Didier Pallard Cc: dev , dpdk stable , John Griffin , Fiona Trahe , Deepak Kumar Jain , Olivier Matz , Adrien Mazarguil Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] common/qat: add missing kmod dependency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Salut Didier, On Fri, Oct 23, 2020 at 5:45 PM Didier Pallard wrote: > > Dependency on kmod needed to manage crypto devices is missing > in qat crypto pmd. > > Cc: stable@dpdk.org > Fixes: 0880c40113ef ("drivers: advertise kmod dependencies in pmdinfo") The Fixes: tag goes first, then Cc:, then empty line. > Signed-off-by: Didier Pallard > --- > drivers/common/qat/qat_device.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c > index b050ce20e4fc..9fa142b5e5bb 100644 > --- a/drivers/common/qat/qat_device.c > +++ b/drivers/common/qat/qat_device.c > @@ -423,3 +423,4 @@ qat_comp_dev_destroy(struct qat_pci_device *qat_pci_dev __rte_unused) > > RTE_PMD_REGISTER_PCI(QAT_PCI_NAME, rte_qat_pmd); > RTE_PMD_REGISTER_PCI_TABLE(QAT_PCI_NAME, pci_id_qat_map); > +RTE_PMD_REGISTER_KMOD_DEP(QAT_PCI_NAME, "* igb_uio | uio_pci_generic | vfio-pci"); > -- > 2.20.1 > Reviewed-by: David Marchand There are some other drivers that have the issue. If there is a volunteer, we have other drivers with the same issue (but probably worth double checking): $ git grep -l 'drv_flags = RTE_PCI_DRV_NEED_MAPPING' drivers/ |xargs dirname |sort -u|while read dir; do dir=${dir%%/base}; git grep -q RTE_PMD_REGISTER_KMOD_DEP $dir || echo $dir; done drivers/baseband/acc100 drivers/baseband/fpga_5gnr_fec drivers/baseband/fpga_lte_fec drivers/common/qat # done drivers/event/octeontx drivers/event/skeleton drivers/mempool/octeontx drivers/net/avp drivers/net/hinic drivers/net/octeontx drivers/regex/octeontx2 -- David Marchand