From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCC16A0093; Thu, 17 Mar 2022 11:11:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 631D3407FF; Thu, 17 Mar 2022 11:11:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7D0214067B for ; Thu, 17 Mar 2022 11:11:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647511895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JCi2w0r4cBgS8ufzpwjPW7Zmhr2aAjkodVt2IFHowBM=; b=AXFggYV6uBzZ3Yju5aTA0opt109u7ZtJTzsRFiDRuA5fEhEHyJT0okf5kYc35ZGP88UuNL dF5D44euTHJa6OqS/pIku8XWH6X/1+zEvjLF2+02rlCfm058AkO370v2A2/XmLogyoU/MM TzG5gqG3w8SfUdiEIDpSeTJJoDoYpqY= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-513-5q_DgQ3vOH-Z7eNt7TdZsQ-1; Thu, 17 Mar 2022 06:11:18 -0400 X-MC-Unique: 5q_DgQ3vOH-Z7eNt7TdZsQ-1 Received: by mail-lf1-f70.google.com with SMTP id y18-20020a197512000000b0044864aef6edso1646010lfe.7 for ; Thu, 17 Mar 2022 03:11:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JCi2w0r4cBgS8ufzpwjPW7Zmhr2aAjkodVt2IFHowBM=; b=3M5CQkFDaIRB6o1XiEz031nhZLptspY/l+xvtCDwI0oYO4BhxMI8KCclmaOnuTuPJZ S4iNCGrlKp1dZEl37yNqnCru/YIADWz+zESRQLJ/zEc/HslhebIWbQ0AiUXEZAY81EFe AfYJ981JgTTkUw56w8zuESXj1LHQC9dVemnxsyixUk0I/M3zW7GkpNRN3WauPO/tbRIU niQdoSWBi7vA/8YLlUQna0hpVceZclSnxpvTtXCS4q6QCDhJV18hNEejGw/RU5zeYRHt Dv8hmmCJkSLYOYHVO8lRKQydZlF2wyxFT17mv4eKuthFzPjhh0KUmbixbtQayVML2Tr5 gE0g== X-Gm-Message-State: AOAM533d0+v6KQ0K6Fv1getR1z2Lm/MO0HCbpsKilZcA8h+gLqI4eUog w7ta4+gWuPnGquuKT82bpCnd2sYZY/ufBwFq2V0EO94qKHyrAjxL8WrVXJ5U1WFRQrkDrRCUf3Z y/+Qk9eZB/DsXQhCtdhc= X-Received: by 2002:a2e:9cda:0:b0:247:e2d9:cde1 with SMTP id g26-20020a2e9cda000000b00247e2d9cde1mr2547445ljj.236.1647511877090; Thu, 17 Mar 2022 03:11:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxuMsrc7exZXAkd9DiO+nLS7zYJpY3dAHqtUZ6+7OQF6P39cOdvPWUas3H631YvLk15xqodJJVPxayFbBBtISg= X-Received: by 2002:a2e:9cda:0:b0:247:e2d9:cde1 with SMTP id g26-20020a2e9cda000000b00247e2d9cde1mr2547437ljj.236.1647511876871; Thu, 17 Mar 2022 03:11:16 -0700 (PDT) MIME-Version: 1.0 References: <20210304090728.26166-1-kalesh-anakkur.purayil@broadcom.com> <20210304090728.26166-3-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: From: David Marchand Date: Thu, 17 Mar 2022 11:11:05 +0100 Message-ID: Subject: Re: [dpdk-dev] [PATCH 2/3] net/bnxt: fix ver get HWRM command To: Kalesh A P , Ajit Khaparde Cc: dev , Thomas Monjalon , Kevin Traynor , Luca Boccassi Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Kalesh, Ajit, On Tue, Mar 1, 2022 at 1:53 PM David Marchand wrote: > On Thu, Mar 4, 2021 at 9:45 AM Kalesh A P > wrote: > > > > From: Kalesh AP > > > > Fix HWRM_VER_GET command to handle DEV_NOT_RDY state. > > > > Driver should fail probe if the device is not ready. > > Conversely, the HWRM_VER_GET poll after reset can safely > > retry until the existing timeout is exceeded. > > > > Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code") > > Cc: stable@dpdk.org > > > > Signed-off-by: Kalesh AP > > Reviewed-by: Somnath Kotur > > Reviewed-by: Randy Schacher > > Reviewed-by: Ajit Kumar Khaparde > > This patch makes probing fail on a RHEL9 kernel with firmwares: > firmware-version: 20.6.143.0/pkg 20.06.04.06 > and > firmware-version: 20.6.112.0 > > Simply reverting the patch fixes probing in my env. > > This was reported by our QE team which is doing sanity checks on ovs > 2.17 which uses dpdk v21.11. > https://bugzilla.redhat.com/show_bug.cgi?id=2055531 QE confirmed reverting this patch fixed initialisation in their setup. I reproduced the issue on another system with RHEL 8.5, and confirmed that reverting the patch or upgrading the firmware fix the issue. I can understand new features in a PMD might require newer firmwares. But breaking compatibility with older firmwares is a big no. If there is no other option, I will send a revert for this patch. Thanks. -- David Marchand