From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D20BA0577; Mon, 6 Apr 2020 15:22:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 50D872BE9; Mon, 6 Apr 2020 15:22:00 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 57F2A2BE2 for ; Mon, 6 Apr 2020 15:21:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586179318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WY/zvFoRNatD7HSRH2bHve1O5tNCFT/MqFEv1LFD48M=; b=M08sEhKnzh9wS3C8u19TaoqhKvRkbfMusfxAVn6/yeh5wk4tHHURKTTSDeG8cS1lSbjTon yXbj7ySF8b+Pj0lKyUOmlyKGlw8dQh6E86pzvu3PfnggVBjLqKtUvlcBO79naZovmgpUzB 6Il2Nax++FzFWlqz1bMRgAuZi/8/18A= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-72-CRNCP3vBNyeXo4HUE2WIqg-1; Mon, 06 Apr 2020 09:21:55 -0400 X-MC-Unique: CRNCP3vBNyeXo4HUE2WIqg-1 Received: by mail-vk1-f198.google.com with SMTP id v83so5674739vke.2 for ; Mon, 06 Apr 2020 06:21:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ETOLpw19O5gQtPJk4kU9lRrabrYLG/x9lhLP9vF2tgM=; b=j29S3/ZI99R8FZin9T+fD3Co2D0lJ36AlffZE25P04ny+K6KWAYWdf920wUhKCmgpH 7lptW7qy57w0CAd1UHqNb22XDx622u8rci2x1QewPqCevLHApm7uWVdwvWFXcjt9pCXJ 4mDA9EtA7DElRbS1HAHm7Jk7APycXWuxhqpIN1riufhs2sUVIQ3itWwUzyKehrVtA89Y Au0a47AofgfGo4p6S4G6R6N4oMmaJmZ5P/MIpBFOqBrrWiqsu6WKXEcEB7kvlc2Q9eaf tOSRV//RX8v2yutVhUo5zcfNbkTonljSAdTzly78L4N5JxIEwkgFvlZoZEuwJTGVhZEC xNiA== X-Gm-Message-State: AGi0PuYjGIEVwcSf7Wsx4DgDUcSis1gFqN+He/Mi9cKaD0dNu72sfLlT qPeM9ajPDpq0VRAg4v34VAwrvDL6RjFj+TbHm0TUkzrbhzfL02IecnR1DIngdlprGbBPii863o4 0rfB0dNoL8HvxRFLeF44= X-Received: by 2002:a1f:1255:: with SMTP id 82mr15006407vks.80.1586179314630; Mon, 06 Apr 2020 06:21:54 -0700 (PDT) X-Google-Smtp-Source: APiQypKst9qd4qU0vshTlCBjCYy/VkE/3lMjNWHXwPZ28ezBDFj7irhrgWEXBn1l9NpFkGx/qjqIx1YGnGA/446CljE= X-Received: by 2002:a1f:1255:: with SMTP id 82mr15006388vks.80.1586179314407; Mon, 06 Apr 2020 06:21:54 -0700 (PDT) MIME-Version: 1.0 References: <20191216075501.15669-1-skori@marvell.com> <20191216081317.30f10c9d@hermes.lan> In-Reply-To: From: David Marchand Date: Mon, 6 Apr 2020 15:21:43 +0200 Message-ID: To: Sunil Kumar Kori Cc: Stephen Hemminger , Jerin Jacob Kollanukkaran , "dev@dpdk.org" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: restricted bus scanning to allowed devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 6, 2020 at 11:32 AM Sunil Kumar Kori wrote: > It looks like there is no comment/objection on following patch and it ca= n be merged. The title does not reflect what this patch is about. I understand this as an optimisation for the pci bus scanning. I agree with Stephen comment. If you change pci_ignore_device and pci_devargs_lookup to take a rte_pci_addr as input, then pci_ignore_device can call pci_devargs_lookup itself. And pci_devargs_lookup does not need to be exported in the private header. Untested (just tried compilation), https://github.com/david-marchand/dpdk/commit/e7860231ecdce91f9f70027d4090a= 7057b8fd5f7 --=20 David Marchand