From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06DADA0C41; Thu, 4 Nov 2021 15:01:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EDE464273B; Thu, 4 Nov 2021 15:01:23 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 52E864273B for ; Thu, 4 Nov 2021 15:01:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636034481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xlKF8pTozjF9unpP6w8u6uXD904LMs+T+hddBz4V714=; b=Ff4MPW7qwo3bxLa+e6fbSkdP07ctqgJw2LnqQMnXNPQSi/L8FZ5a7W9eoSOwX6Q3ZwFdNR qVd0rdTi6hPm7sYfyLQu1THkrOBAg4zmnWDzecoprQiuH3g140XQihjPWdBNpgsELAfGWT rwQmbjRC8t3bZEQxcw6hY8AJIhlTfSQ= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-251-y16AfFq9NlyMyc4gigCkOg-1; Thu, 04 Nov 2021 10:01:20 -0400 X-MC-Unique: y16AfFq9NlyMyc4gigCkOg-1 Received: by mail-lj1-f197.google.com with SMTP id f6-20020a2e9e86000000b00211349f9ce3so2287018ljk.3 for ; Thu, 04 Nov 2021 07:01:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xlKF8pTozjF9unpP6w8u6uXD904LMs+T+hddBz4V714=; b=AaZ3YQJMJCXzsaWfL1nLPgm5463CcRSIrL72797WQi1TbYx0mY8lDut7yKB01PApni SjgzaiRZYhN0X70MVXy0Z0OpyVHrUMuXJEzCqXKSpIK87sLDnqrLUnZKH/2dTZXDKqgp x3m9orz508zD3/JmdM+izWpdtTVnrYa75nS/GYr6q130QoqJIMKnV3GNBYcgECondCpF Aaf+i+tcSrU2cs9I3XOJj2/FMxmjKuBjiUsc7z5MxonFW2vybyJmkfEqI/wuWtAUfHdZ Ft3v+KVnAiqFAKBjJYJxFQOJ5UX3pfdqnQhjpWyRn13oQC2Sl/fbd5YuvIrUABImxzcz VDhg== X-Gm-Message-State: AOAM532axjncXgf1QQSK2+DBIpFevriEUS3cC632/tei3yoNvO9r5fFx urRRUIW18JVo3YfAps2rvmS7jmiB1V3U3KsC8+UuXUEwq6zUtWh20bP2KS30kqaNtBqIT++egla yoXo/kTG2p59bgrawtHk= X-Received: by 2002:a2e:9b44:: with SMTP id o4mr22120452ljj.159.1636034478221; Thu, 04 Nov 2021 07:01:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxl073E+j/vuC/zDbpK3e4AHJkros1kwSbTCxsz4JJWOyQhciOOGEx78/PzWuOII0mJAZ+fU0pEyDj62XA18dk= X-Received: by 2002:a2e:9b44:: with SMTP id o4mr22120214ljj.159.1636034476290; Thu, 04 Nov 2021 07:01:16 -0700 (PDT) MIME-Version: 1.0 References: <20211104112644.17278-1-bingz@nvidia.com> <20211104112644.17278-3-bingz@nvidia.com> In-Reply-To: <20211104112644.17278-3-bingz@nvidia.com> From: David Marchand Date: Thu, 4 Nov 2021 15:01:04 +0100 Message-ID: To: Bing Zhao Cc: Slava Ovsiienko , Matan Azrad , dev , Raslan Darawsheh , Thomas Monjalon , Ori Kam Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/4] net/mlx5: add support for Rx queue delay drop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 4, 2021 at 12:27 PM Bing Zhao wrote: > > For an Ethernet RQ, packets received when receive WQEs are exhausted > are dropped. This behavior prevents slow or malicious software > entities at the host from affecting the network. While for hairpin > cases, even if there is no software involved during the packet > forwarding from Rx to Tx side, some hiccup in the hardware or back > pressure from Tx side may still cause the WQEs to be exhausted. In > certain scenarios it may be preferred to configure the device to > avoid such packet drops, assuming the posting of WQEs will resume > shortly. > > To support this, a new devarg "delay_drop_en" is introduced, by > default, the delay drop is enabled for hairpin Rx queues and > disabled for standard Rx queues. This value is used as a bit mask: > - bit 0: enablement of standard Rx queue > - bit 1: enablement of hairpin Rx queue > And this attribute will be applied to all Rx queues of a device. Rather than a devargs, why can't the driver use this option in the identified usecases where it makes sense? Here, hairpin. -- David Marchand